Skip to content

Commit 1de1298

Browse files
committed
error on shared modules+memory growth #3893
1 parent 61cd7c6 commit 1de1298

File tree

3 files changed

+5
-0
lines changed

3 files changed

+5
-0
lines changed

emcc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -942,6 +942,7 @@ try:
942942
shared.Settings.RELOCATABLE = 1
943943
shared.Settings.PRECISE_I64_MATH = 1 # other might use precise math, we need to be able to print it
944944
assert not use_closure_compiler, 'cannot use closure compiler on shared modules'
945+
assert not shared.Settings.ALLOW_MEMORY_GROWTH, 'memory growth is not supported with shared modules yet'
945946

946947
if shared.Settings.WASM:
947948
assert not shared.Settings.ALLOW_MEMORY_GROWTH, 'memory growth is not supported with WASM=1'

tests/runner.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -147,6 +147,7 @@ def tearDown(self):
147147

148148
def skip(self, why):
149149
print >> sys.stderr, '<skipping: %s> ' % why,
150+
return False
150151

151152
def get_dir(self):
152153
return self.working_dir

tests/test_core.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2998,6 +2998,7 @@ def test_runtimelink(self):
29982998
self.do_run(main, 'supp: 54,2\nmain: 56\nsupp see: 543\nmain see: 76\nok.')
29992999

30003000
def can_dlfcn(self):
3001+
if Settings.ALLOW_MEMORY_GROWTH == 1: return self.skip('no dlfcn with memory growth yet')
30013002
return True
30023003

30033004
def prep_dlfcn_lib(self):
@@ -3757,6 +3758,8 @@ def zzztest_dlfcn_exceptions(self): # TODO: make this work. need to forward temp
37573758
''', post_build=self.dlfcn_post_build)
37583759

37593760
def dylink_test(self, main, side, expected, header=None, main_emcc_args=[], force_c=False, need_reverse=True, auto_load=True):
3761+
if Settings.ALLOW_MEMORY_GROWTH == 1: return self.skip('no dynamic linking with memory growth yet')
3762+
37603763
if header:
37613764
open('header.h', 'w').write(header)
37623765

0 commit comments

Comments
 (0)