Extend template context in TemplateHTMLRenderer #8569
Conversation
* Pass data as a whole. * Pass processing response. * Pass current view. * Request is always available in Django templates. Actually, the data can be accessed trough the response, the request and the response trough the view.
Provide an example demonstrating this renderer can now be interoperable with JSONRenderer.
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Any maintainers able to look at this? |
|
Thanks for your time on this - I've made a comment against the issue... #5236 (comment) describing what change I'd expect to see. |
There was a problem hiding this comment.
Please follow the following suggestion from Tomchristie
Okay, so #8569 changes the behaviour more than I'd like.
I'd suggest we aim to keep things absolutely as minimal as possible here, so...
Add a test case that demonstrates the issue.
Change TemplateHTMLRenderer so that when data is a list, not a dict/dict-like then it is returned under a {"results": data} key. This has the advantage of being compatible with paginated results.
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Not sure the patch series fit all cases but works for me.
Relates: #8568
Closes: #5236