Skip to content

Commit 3190e4f

Browse files
authored
Handle service worker error in Firefox (#8272)
* Handle service worker error in Firefox See https://bugzilla.mozilla.org/show_bug.cgi?id=1429714 for more details. * Update serviceWorker.js
1 parent 0299c0e commit 3190e4f

File tree

2 files changed

+14
-6
lines changed

2 files changed

+14
-6
lines changed

packages/cra-template-typescript/template/src/serviceWorker.ts

+7-3
Original file line numberDiff line numberDiff line change
@@ -138,8 +138,12 @@ function checkValidServiceWorker(swUrl: string, config?: Config) {
138138

139139
export function unregister() {
140140
if ('serviceWorker' in navigator) {
141-
navigator.serviceWorker.ready.then(registration => {
142-
registration.unregister();
143-
});
141+
navigator.serviceWorker.ready
142+
.then(registration => {
143+
registration.unregister();
144+
})
145+
.catch(error => {
146+
console.error(error.message);
147+
});
144148
}
145149
}

packages/cra-template/template/src/serviceWorker.js

+7-3
Original file line numberDiff line numberDiff line change
@@ -130,8 +130,12 @@ function checkValidServiceWorker(swUrl, config) {
130130

131131
export function unregister() {
132132
if ('serviceWorker' in navigator) {
133-
navigator.serviceWorker.ready.then(registration => {
134-
registration.unregister();
135-
});
133+
navigator.serviceWorker.ready
134+
.then(registration => {
135+
registration.unregister();
136+
})
137+
.catch(error => {
138+
console.error(error.message);
139+
});
136140
}
137141
}

0 commit comments

Comments
 (0)