File tree 2 files changed +3
-9
lines changed
packages/react-scripts/config 2 files changed +3
-9
lines changed Original file line number Diff line number Diff line change @@ -47,7 +47,7 @@ Note that any rules set to `"error"` will stop the project from building.
47
47
48
48
There are a few things to remember:
49
49
50
- 1 . You must extend the base config, as removing it could introduce hard-to-find issues.
50
+ 1 . We highly recommend extending the base config, as removing it could introduce hard-to-find issues.
51
51
1 . When working with TypeScript, you'll need to provide an ` overrides ` object for rules that should _ only_ target TypeScript files.
52
52
53
53
In the below example:
Original file line number Diff line number Diff line change @@ -347,14 +347,8 @@ module.exports = function(webpackEnv) {
347
347
// A config couldn't be found.
348
348
}
349
349
350
- // We allow overriding the config, only if it extends our config
351
- // (`extends` can be a string or array of strings).
352
- if (
353
- process . env . EXTEND_ESLINT &&
354
- eslintConfig &&
355
- eslintConfig . extends &&
356
- eslintConfig . extends . includes ( 'react-app' )
357
- ) {
350
+ // We allow overriding the config only if the env variable is set
351
+ if ( process . env . EXTEND_ESLINT && eslintConfig ) {
358
352
return eslintConfig ;
359
353
} else {
360
354
return {
You can’t perform that action at this time.
0 commit comments