fix(react-scripts): do not set allowedHosts if undefined #11877
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can this please be merged so projects can use cra ^5 and proxying? |
|
Could this please get reviewed and merged? The issue currently prevents us from updating CRA. |
Comment on lines
+25
to
+30
| let allowedHosts; | ||
| if (!proxy || process.env.DANGEROUSLY_DISABLE_HOST_CHECK === 'true') { | ||
| allowedHosts = 'all'; | ||
| } else if (allowedHost != null) { | ||
| allowedHosts = [allowedHost]; | ||
| } |
There was a problem hiding this comment.
I think a simpler way could be something like
const disableFirewall = !proxy || process.env.DANGEROUSLY_DISABLE_HOST_CHECK === 'true';
return {
...
allowedHosts: disableFirewall ? 'all' : allowedHost ? [allowedHost] : undefined,
...
};
|
What is blocking this fix? Just encountered this bug that was reported in 2021. |
Yeah very good question |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11762.
urls.lanUrlForConfigmay beundefined, if theHOSTis set, the IP address is not private, or the IP address retrieval has failed.TEST PLAN: manual testing with the steps to reproduce #11762.