Skip to content

Commit 40c687c

Browse files
cortinicofacebook-github-bot
authored andcommitted
Allow for Android offline mirrors to be executed on developer's laptops
Summary: Before this change, the only way to update the offline mirror was to run it on a devmachine (OD won't work either due to network restriction). Developer's laptop also won't work as they would download AAPT2 for MacOS. In the offline mirror instead we need AAPT2 for Linux as that's Sandcastle runner type. This relaxes this requirement so the next time a developer has to update the offline mirror they will see the message on the diff with the command to execute, and they should be able to run the command locally (or on their devbox). Changelog: [Internal] [Changed] - Allow for Android offline mirrors to be executed on developer's laptops allow-large-files Reviewed By: cipolleschi Differential Revision: D43344651 fbshipit-source-id: 3e91adb2db45cf94d3f947aaab501d98580dc43d
1 parent 70fb2dc commit 40c687c

File tree

2 files changed

+8
-0
lines changed

2 files changed

+8
-0
lines changed

ReactAndroid/build.gradle

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -670,6 +670,12 @@ dependencies {
670670
androidTestImplementation("androidx.test:runner:${ANDROIDX_TEST_VERSION}")
671671
androidTestImplementation("androidx.test:rules:${ANDROIDX_TEST_VERSION}")
672672
androidTestImplementation("org.mockito:mockito-core:${MOCKITO_CORE_VERSION}")
673+
674+
// This compileOnly dependency is needed to be able to update the offline
675+
// mirror from a non-linux machine, while still executing inside a Linux CI
676+
// as we declare a dependency on aap2 @linux so we're sure the linux artifact
677+
// gets downloaded at some point.
678+
compileOnly("com.android.tools.build:aapt2:7.4.1-8841542:linux")
673679
}
674680

675681
react {

build.gradle.kts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -91,6 +91,8 @@ tasks.register("downloadAll") {
9191
dependsOn(":ReactAndroid:androidDependencies")
9292
dependsOn(":ReactAndroid:hermes-engine:dependencies")
9393
dependsOn(":ReactAndroid:hermes-engine:androidDependencies")
94+
dependsOn(":packages:rn-tester:android:app:dependencies")
95+
dependsOn(":packages:rn-tester:android:app:androidDependencies")
9496
}
9597

9698
tasks.register("publishAllInsideNpmPackage") {

0 commit comments

Comments
 (0)