Skip to content

Commit becb47c

Browse files
author
Riccardo Cipolleschi
committed
[Fix] Let React Native decide the Hermes version to use in the Codegen
1 parent f0054e1 commit becb47c

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

scripts/cocoapods/__tests__/codegen_utils-test.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -465,7 +465,7 @@ def get_podspec_no_fabric_no_script
465465
"RCTTypeSafety": ["99.98.97"],
466466
"React-Core": ["99.98.97"],
467467
"React-jsi": ["99.98.97"],
468-
"hermes-engine": ["99.98.97"],
468+
"hermes-engine": [],
469469
"ReactCommon/turbomodule/core": ["99.98.97"]
470470
}
471471
}

scripts/cocoapods/codegen_utils.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ def get_react_codegen_spec(package_json_file, folly_version: '2021.07.22.00', fa
118118

119119
if hermes_enabled
120120
spec[:'dependencies'].merge!({
121-
'hermes-engine': [version],
121+
'hermes-engine': [], # let React Native decide which version of Hermes Engine to be used. Otherwise, this can create conflicts.
122122
});
123123
else
124124
spec[:'dependencies'].merge!({

0 commit comments

Comments
 (0)