Skip to content

Commit dd0bf83

Browse files
Riccardo Cipolleschifacebook-github-bot
Riccardo Cipolleschi
authored andcommitted
Do not add LongLivedObject wrapper in OSS (#35491)
Summary: This change excludes the `LongLivedObject.h` file from the pod in the ReactCommon library. The file creates a problem when the `use_frameworks!` option is used in an app because there can't be two files with the same name, despite being in different paths, within the same framework. Specifically, this `LongLivedObject` is just a redirect to the other one, so it should be safe to exclude this. ## Changelog [iOS][Fixed] - Exclude redirector to `LongLivedObject.h` from ReactCommon podspec Pull Request resolved: #35491 Test Plan: 1. Manually tested in an app from RC2 Reviewed By: cortinico Differential Revision: D41548985 Pulled By: cipolleschi fbshipit-source-id: acc57fccdedb344a3aa105f2968645a049392e07
1 parent 70bb644 commit dd0bf83

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

ReactCommon/ReactCommon.podspec

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,7 @@ Pod::Spec.new do |s|
6262
sss.source_files = "react/nativemodule/core/ReactCommon/**/*.{cpp,h}",
6363
"react/nativemodule/core/platform/ios/**/*.{mm,cpp,h}"
6464
sss.dependency "React-jsidynamic", version
65+
sss.exclude_files = "react/nativemodule/core/ReactCommon/LongLivedObject.h"
6566
end
6667

6768
ss.subspec "samples" do |sss|

0 commit comments

Comments
 (0)