Revert "Ship enableFabricCompleteRootInCommitPhase (#32318)" (#32434)

This reverts commit 8759c5c /
#32318

We discovered that the experiment setup for this was faulty and we need
to re-run as a back test.

Author: jackpope

packages/react-native-renderer/src/ReactFiberConfigFabric.js

@@ -58,6 +58,7 @@ import {
 } from './ReactNativeFiberInspector';
 
 import {
+  enableFabricCompleteRootInCommitPhase,
   passChildrenWhenCloningPersistedNodes,
   enableLazyPublicInstanceInFabric,
 } from 'shared/ReactFeatureFlags';
@@ -533,14 +534,19 @@ export function finalizeContainerChildren(
   container: Container,
   newChildren: ChildSet,
 ): void {
-  // Noop - children will be finalized in replaceContainerChildren
+  if (!enableFabricCompleteRootInCommitPhase) {
+    completeRoot(container.containerTag, newChildren);
+  }
 }
 
 export function replaceContainerChildren(
   container: Container,
   newChildren: ChildSet,
 ): void {
-  completeRoot(container.containerTag, newChildren);
+  // Noop - children will be replaced in finalizeContainerChildren
+  if (enableFabricCompleteRootInCommitPhase) {
+    completeRoot(container.containerTag, newChildren);
+  }
 }
 
 export {getClosestInstanceFromNode as getInstanceFromNode};

packages/shared/ReactFeatureFlags.js

@@ -94,6 +94,11 @@ export const enableViewTransition = __EXPERIMENTAL__;
 
 export const enableSwipeTransition = __EXPERIMENTAL__;
 
+/**
+ * Switches the Fabric API from doing layout in commit work instead of complete work.
+ */
+export const enableFabricCompleteRootInCommitPhase = false;
+
 /**
  * Switches Fiber creation to a simple object instead of a constructor.
  */

packages/shared/forks/ReactFeatureFlags.native-fb-dynamic.js

@@ -23,6 +23,7 @@ export const enableHiddenSubtreeInsertionEffectCleanup = __VARIANT__;
 export const enablePersistedModeClonedFlag = __VARIANT__;
 export const enableShallowPropDiffing = __VARIANT__;
 export const passChildrenWhenCloningPersistedNodes = __VARIANT__;
+export const enableFabricCompleteRootInCommitPhase = __VARIANT__;
 export const enableSiblingPrerendering = __VARIANT__;
 export const enableUseEffectCRUDOverload = __VARIANT__;
 export const enableFastAddPropertiesInDiffing = __VARIANT__;

packages/shared/forks/ReactFeatureFlags.native-fb.js

@@ -20,6 +20,7 @@ const dynamicFlags: DynamicExportsType = (dynamicFlagsUntyped: any);
 // the exports object every time a flag is read.
 export const {
   alwaysThrottleRetries,
+  enableFabricCompleteRootInCommitPhase,
   enableHiddenSubtreeInsertionEffectCleanup,
   enableObjectFiber,
   enablePersistedModeClonedFlag,

packages/shared/forks/ReactFeatureFlags.native-oss.js

@@ -30,6 +30,7 @@ export const enableAsyncIterableChildren = false;
 export const enableCPUSuspense = false;
 export const enableCreateEventHandleAPI = false;
 export const enableDO_NOT_USE_disableStrictPassiveEffect = false;
+export const enableFabricCompleteRootInCommitPhase = false;
 export const enableMoveBefore = true;
 export const enableFizzExternalRuntime = true;
 export const enableHalt = false;

packages/shared/forks/ReactFeatureFlags.test-renderer.js

@@ -36,6 +36,7 @@ export const enableUseEffectEventHook = false;
 export const favorSafetyOverHydrationPerf = true;
 export const enableLegacyFBSupport = false;
 export const enableMoveBefore = false;
+export const enableFabricCompleteRootInCommitPhase = false;
 export const enableHiddenSubtreeInsertionEffectCleanup = false;
 export const enableHydrationLaneScheduling = true;
 

packages/shared/forks/ReactFeatureFlags.test-renderer.native-fb.js

@@ -61,6 +61,7 @@ export const renameElementSymbol = false;
 export const retryLaneExpirationMs = 5000;
 export const syncLaneExpirationMs = 250;
 export const transitionLaneExpirationMs = 5000;
+export const enableFabricCompleteRootInCommitPhase = false;
 export const enableSiblingPrerendering = true;
 export const enableUseEffectCRUDOverload = true;
 export const enableHydrationLaneScheduling = true;

packages/shared/forks/ReactFeatureFlags.test-renderer.www.js

@@ -39,6 +39,7 @@ export const favorSafetyOverHydrationPerf = true;
 export const enableLegacyFBSupport = false;
 export const enableMoveBefore = false;
 export const enableRenderableContext = false;
+export const enableFabricCompleteRootInCommitPhase = false;
 export const enableHiddenSubtreeInsertionEffectCleanup = true;
 
 export const enableRetryLaneExpiration = false;

packages/shared/forks/ReactFeatureFlags.www.js

@@ -50,6 +50,7 @@ export const enableProfilerTimer = __PROFILE__;
 export const enableProfilerCommitHooks = __PROFILE__;
 export const enableProfilerNestedUpdatePhase = __PROFILE__;
 export const enableUpdaterTracking = __PROFILE__;
+export const enableFabricCompleteRootInCommitPhase = false;
 
 export const enableSuspenseAvoidThisFallback = true;