Skip to content

Commit d1f0472

Browse files
authored
[string-refs] remove enableLogStringRefsProd flag (#31414)
We no longer need this production logging.
1 parent 3dc1e48 commit d1f0472

8 files changed

+2
-20
lines changed

packages/react/src/jsx/ReactJSXElement.js

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ import {
2323
disableStringRefs,
2424
disableDefaultPropsExceptForClasses,
2525
enableOwnerStacks,
26-
enableLogStringRefsProd,
2726
} from 'shared/ReactFeatureFlags';
2827
import {checkPropStringCoercion} from 'shared/CheckStringCoercion';
2928
import {ClassComponent} from 'react-reconciler/src/ReactWorkTags';
@@ -75,7 +74,7 @@ let didWarnAboutStringRefs;
7574
let didWarnAboutElementRef;
7675
let didWarnAboutOldJSXRuntime;
7776

78-
if (__DEV__ || enableLogStringRefsProd) {
77+
if (__DEV__) {
7978
didWarnAboutStringRefs = {};
8079
didWarnAboutElementRef = {};
8180
}
@@ -1228,16 +1227,13 @@ function stringRefAsCallbackRef(stringRef, type, owner, value) {
12281227
);
12291228
}
12301229

1231-
if (__DEV__ || enableLogStringRefsProd) {
1230+
if (__DEV__) {
12321231
if (
12331232
// Will already warn with "Function components cannot be given refs"
12341233
!(typeof type === 'function' && !isReactClass(type))
12351234
) {
12361235
const componentName = getComponentNameFromFiber(owner) || 'Component';
12371236
if (!didWarnAboutStringRefs[componentName]) {
1238-
if (enableLogStringRefsProd) {
1239-
enableLogStringRefsProd(componentName, stringRef);
1240-
}
12411237
if (__DEV__) {
12421238
console.error(
12431239
'Component "%s" contains the string ref "%s". Support for string refs ' +

packages/shared/ReactFeatureFlags.js

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -210,14 +210,6 @@ export const disableClientCache = true;
210210

211211
export const disableStringRefs = true;
212212

213-
/**
214-
* If set to a function, the function will be called with the component name
215-
* and ref string.
216-
*
217-
* NOTE: This happens also in the production build.
218-
*/
219-
export const enableLogStringRefsProd: null | ((string, string) => void) = null;
220-
221213
// Warn on any usage of ReactTestRenderer
222214
export const enableReactTestRendererWarning = true;
223215

packages/shared/forks/ReactFeatureFlags.native-fb.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,6 @@ export const enableLazyContextPropagation = true;
6565
export const enableLegacyCache = false;
6666
export const enableLegacyFBSupport = false;
6767
export const enableLegacyHidden = false;
68-
export const enableLogStringRefsProd: null | ((string, string) => void) = null;
6968
export const enableNoCloningMemoCache = false;
7069
export const enableOwnerStacks = false;
7170
export const enablePostpone = false;

packages/shared/forks/ReactFeatureFlags.native-oss.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,6 @@ export const enableContextProfiling = false;
5656
export const enableLegacyCache = false;
5757
export const enableLegacyFBSupport = false;
5858
export const enableLegacyHidden = false;
59-
export const enableLogStringRefsProd: null | ((string, string) => void) = null;
6059
export const enableNoCloningMemoCache = false;
6160
export const enableObjectFiber = false;
6261
export const enableOwnerStacks = false;

packages/shared/forks/ReactFeatureFlags.test-renderer.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,6 @@ export const enableUseEffectEventHook = false;
4444
export const favorSafetyOverHydrationPerf = true;
4545
export const enableComponentStackLocations = true;
4646
export const enableLegacyFBSupport = false;
47-
export const enableLogStringRefsProd: null | ((string, string) => void) = null;
4847
export const enableFilterEmptyStringAttributesDOM = true;
4948
export const enableGetInspectorDataForInstanceInProduction = false;
5049
export const enableFabricCompleteRootInCommitPhase = false;

packages/shared/forks/ReactFeatureFlags.test-renderer.www.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,6 @@ export const enableUseEffectEventHook = false;
4646
export const favorSafetyOverHydrationPerf = true;
4747
export const enableComponentStackLocations = true;
4848
export const enableLegacyFBSupport = false;
49-
export const enableLogStringRefsProd: null | ((string, string) => void) = null;
5049
export const enableFilterEmptyStringAttributesDOM = true;
5150
export const enableGetInspectorDataForInstanceInProduction = false;
5251
export const enableRenderableContext = false;

packages/shared/forks/ReactFeatureFlags.www-dynamic.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ export const disableStringRefs = __VARIANT__;
2222
export const enableDeferRootSchedulingToMicrotask = __VARIANT__;
2323
export const enableDO_NOT_USE_disableStrictPassiveEffect = __VARIANT__;
2424
export const enableHiddenSubtreeInsertionEffectCleanup = __VARIANT__;
25-
export const enableLogStringRefsProd: null | ((string, string) => void) = null;
2625
export const enableNoCloningMemoCache = __VARIANT__;
2726
export const enableObjectFiber = __VARIANT__;
2827
export const enableRenderableContext = __VARIANT__;

packages/shared/forks/ReactFeatureFlags.www.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ export const {
2525
enableDO_NOT_USE_disableStrictPassiveEffect,
2626
enableHiddenSubtreeInsertionEffectCleanup,
2727
enableInfiniteRenderLoopDetection,
28-
enableLogStringRefsProd,
2928
enableNoCloningMemoCache,
3029
enableObjectFiber,
3130
enableRenderableContext,

0 commit comments

Comments
 (0)