Skip to content

Commit a5aa585

Browse files
committed
Address review comments and removed unused code
1 parent f4a3931 commit a5aa585

File tree

2 files changed

+0
-14
lines changed

2 files changed

+0
-14
lines changed

firebase_admin/_http_client.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,6 @@ def close(self):
156156
self._session.close()
157157
self._session = None
158158

159-
160159
class JsonHttpClient(HttpClient):
161160
"""An HTTP client that parses response messages as JSON."""
162161

@@ -166,7 +165,6 @@ def __init__(self, **kwargs):
166165
def parse_body(self, resp):
167166
return resp.json()
168167

169-
170168
class GoogleAuthCredentialFlow(httpx.Auth):
171169
"""Google Auth Credential Auth Flow"""
172170
def __init__(self, credential: credentials.Credentials):
@@ -239,8 +237,6 @@ def auth_flow(self, request: httpx.Request) -> Generator[httpx.Request, httpx.Re
239237
break
240238
# The last yielded response is automatically returned by httpx's auth flow.
241239

242-
243-
244240
class HttpxAsyncClient():
245241
"""Async HTTP client used to make HTTP/2 calls using HTTPX.
246242

integration/conftest.py

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515
"""pytest configuration and global fixtures for integration tests."""
1616
import json
1717

18-
# import asyncio
1918
import pytest
2019
from pytest_asyncio import is_async_test
2120

@@ -73,15 +72,6 @@ def api_key(request):
7372
with open(path) as keyfile:
7473
return keyfile.read().strip()
7574

76-
# @pytest.fixture(scope="session")
77-
# def event_loop():
78-
# """Create an instance of the default event loop for test session.
79-
# This avoids early eventloop closure.
80-
# """
81-
# loop = asyncio.get_event_loop_policy().new_event_loop()
82-
# yield loop
83-
# loop.close()
84-
8575
def pytest_collection_modifyitems(items):
8676
pytest_asyncio_tests = (item for item in items if is_async_test(item))
8777
session_scope_marker = pytest.mark.asyncio(loop_scope="session")

0 commit comments

Comments
 (0)