Skip to content

Commit 91418a1

Browse files
authored
Fix data-collection-tests (#6540)
The dependencies were pulling kotlin stdlib versions that were breaking version alignment. The solution is to depend on the BOM as decribed in https://kotlinlang.org/docs/whatsnew18.html#usage-of-the-latest-kotlin-stdlib-version-in-transitive-dependencies
1 parent 6c76289 commit 91418a1

File tree

2 files changed

+2
-0
lines changed

2 files changed

+2
-0
lines changed

firebase-common/data-collection-tests/data-collection-tests.gradle.kts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ android {
3636
dependencies {
3737
implementation("com.google.firebase:firebase-common:21.0.0")
3838
implementation("com.google.firebase:firebase-components:18.0.0")
39+
implementation(platform(libs.kotlin.bom))
3940

4041
testImplementation(libs.androidx.core)
4142
testImplementation(libs.androidx.test.junit)

gradle/libs.versions.toml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,7 @@ grpc-protoc-gen-kotlin = { module = "io.grpc:protoc-gen-grpc-kotlin", version.re
6262
grpc-stub = { module = "io.grpc:grpc-stub", version.ref = "grpc" }
6363
javax-annotation-jsr250 = { module = "javax.annotation:jsr250-api", version = "1.0" }
6464
javax-inject = { module = "javax.inject:javax.inject", version = "1" }
65+
kotlin-bom = { module = "org.jetbrains.kotlin:kotlin-bom", version.ref = "kotlin" }
6566
kotlin-stdlib = { module = "org.jetbrains.kotlin:kotlin-stdlib", version.ref = "kotlin" }
6667
kotlin-stdlib-jdk8 = { module = "org.jetbrains.kotlin:kotlin-stdlib-jdk8", version.ref = "kotlin" }
6768
kotlin-coroutines-tasks = { module = "org.jetbrains.kotlinx:kotlinx-coroutines-play-services", version.ref = "coroutines" }

0 commit comments

Comments
 (0)