Skip to content

Commit 564a0f5

Browse files
committed
Fix and add more bin test.
1 parent 97e3dd3 commit 564a0f5

File tree

3 files changed

+54
-4
lines changed

3 files changed

+54
-4
lines changed
Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
const functions = require("firebase-functions");
2+
const functionsv2 = require("firebase-functions/v2");
3+
4+
exports.v1http = functions.https.onRequest((req, resp) => {
5+
resp.status(200).send("PASS");
6+
});
7+
8+
exports.v1httpPreserve = functions
9+
.runWith({ preserveExternalChanges: true })
10+
.https.onRequest((req, resp) => {
11+
resp.status(200).send("PASS");
12+
});
13+
14+
functionsv2.setGlobalOptions({ preserveExternalChanges: true });
15+
16+
exports.v2http = functionsv2.https.onRequest((req, resp) => {
17+
resp.status(200).send("PASS");
18+
});
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
{
2+
"name": "commonjs-preserve"
3+
}

scripts/bin-test/test.ts

Lines changed: 33 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,13 +14,15 @@ const TIMEOUT_M = 5_000;
1414
const TIMEOUT_S = 1_000;
1515

1616
const DEFAULT_OPTIONS = {
17-
memory: null,
17+
availableMemoryMb: null,
1818
maxInstances: null,
1919
minInstances: null,
2020
timeoutSeconds: null,
21-
vpcConnector: null,
22-
vpcConnectorEgressSettings: null,
23-
serviceAccount: null,
21+
vpc: {
22+
connector: null,
23+
egressSettings: null,
24+
},
25+
serviceAccountEmail: null,
2426
ingressSettings: null,
2527
};
2628

@@ -217,6 +219,33 @@ describe("functions.yaml", () => {
217219
},
218220
},
219221
},
222+
{
223+
name: "preserveChange",
224+
modulePath: "./scripts/bin-test/sources/commonjs-preserve",
225+
expected: {
226+
endpoints: {
227+
v1http: {
228+
...DEFAULT_V1_OPTIONS,
229+
platform: "gcfv1",
230+
entryPoint: "v1http",
231+
httpsTrigger: {},
232+
},
233+
v1httpPreserve: {
234+
platform: "gcfv1",
235+
entryPoint: "v1httpPreserve",
236+
httpsTrigger: {},
237+
},
238+
v2http: {
239+
platform: "gcfv2",
240+
entryPoint: "v2http",
241+
labels: {},
242+
httpsTrigger: {},
243+
},
244+
},
245+
requiredAPIs: [],
246+
specVersion: "v1alpha1",
247+
},
248+
},
220249
];
221250

222251
for (const tc of testcases) {

0 commit comments

Comments
 (0)