Change default endponit cfg for v1.

Author: taeold

spec/fixtures.ts

@@ -0,0 +1,16 @@
+import { ManifestEndpoint } from "../src/runtime/manifest";
+import { RESET_VALUE } from "../src/common/options";
+
+export const MINIMAL_ENDPOINT: Partial<ManifestEndpoint> = {
+  availableMemoryMb: RESET_VALUE,
+  concurrency: RESET_VALUE,
+  ingressSettings: RESET_VALUE,
+  maxInstances: RESET_VALUE,
+  minInstances: RESET_VALUE,
+  serviceAccountEmail: RESET_VALUE,
+  timeoutSeconds: RESET_VALUE,
+  vpc: {
+    connector: RESET_VALUE,
+    egressSettings: RESET_VALUE,
+  },
+};

spec/v1/providers/fixtures.ts

@@ -143,7 +143,7 @@ export function stackToWire(stack: ManifestStack): Record<string, unknown> {
  */
 export function initEndpoint(...opts: { preserveExternalChanges?: boolean }[]): ManifestEndpoint {
   const endpoint: ManifestEndpoint = {};
-  if (opts.every((opt) => !opt.preserveExternalChanges)) {
+  if (opts.every((opt) => !opt?.preserveExternalChanges)) {
     for (const key of Object.keys(RESETTABLE_OPTIONS)) {
       endpoint[key] = RESET_VALUE;
     }
@@ -180,7 +180,7 @@ export function initTaskQueueTrigger(
   ...opts: { preserveExternalChanges?: boolean }[]
 ): ManifestEndpoint["taskQueueTrigger"] {
   let taskQueueTrigger = {};
-  if (opts.every((opt) => !opt.preserveExternalChanges)) {
+  if (opts.every((opt) => !opt?.preserveExternalChanges)) {
     const retryConfig = {};
     for (const key of Object.keys(RESETTABLE_RETRY_CONFIG_OPTIONS)) {
       retryConfig[key] = RESET_VALUE;
@@ -222,7 +222,7 @@ function initScheduleTrigger(
   ...opts: { preserveExternalChanges?: boolean }[]
 ): ManifestEndpoint["scheduleTrigger"] {
   let scheduleTrigger: ManifestEndpoint["scheduleTrigger"] = { schedule };
-  if (opts.every((opt) => !opt.preserveExternalChanges)) {
+  if (opts.every((opt) => !opt?.preserveExternalChanges)) {
     const retryConfig = {};
     for (const key of Object.keys(resetOptions)) {
       retryConfig[key] = RESET_VALUE;

src/runtime/manifest.ts

@@ -20,7 +20,7 @@
 // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 // SOFTWARE.
 
-import { ManifestEndpoint } from "../../../runtime/manifest";
+import { initEndpoint, ManifestEndpoint } from "../../../runtime/manifest";
 import { ResetValue } from "../../../common/options";
 import { CloudEvent, CloudFunction } from "../../core";
 import { Expression } from "../../../params";
@@ -230,6 +230,7 @@ export function getEndpointAnnotation(
   const baseOpts = options.optionsToEndpoint(options.getGlobalOptions());
   const specificOpts = options.optionsToEndpoint(opts);
   const endpoint: ManifestEndpoint = {
+    ...initEndpoint(options.getGlobalOptions(), opts),
     platform: "gcfv2",
     ...baseOpts,
     ...specificOpts,

src/v2/providers/alerts/alerts.ts

@@ -28,7 +28,7 @@ import { DataSnapshot } from "../../common/providers/database";
 import { normalizePath } from "../../common/utilities/path";
 import { PathPattern } from "../../common/utilities/path-pattern";
 import { applyChange } from "../../common/utilities/utils";
-import { ManifestEndpoint } from "../../runtime/manifest";
+import { initEndpoint, ManifestEndpoint } from "../../runtime/manifest";
 import { CloudEvent, CloudFunction } from "../core";
 import { Expression } from "../../params";
 import { wrapTraceContext } from "../trace";
@@ -428,6 +428,7 @@ export function makeEndpoint(
     : (eventFilters.instance = instance.getValue());
 
   return {
+    ...initEndpoint(options.getGlobalOptions(), opts),
     platform: "gcfv2",
     ...baseOpts,
     ...specificOpts,

src/v2/providers/database.ts

@@ -27,7 +27,7 @@
 
 import { convertIfPresent, copyIfPresent } from "../../common/encoding";
 import { ResetValue } from "../../common/options";
-import { ManifestEndpoint } from "../../runtime/manifest";
+import { initEndpoint, ManifestEndpoint } from "../../runtime/manifest";
 import { CloudEvent, CloudFunction } from "../core";
 import { wrapTraceContext } from "../trace";
 import { Expression } from "../../params";
@@ -199,6 +199,7 @@ export function onCustomEventPublished<T = any>(
   const specificOpts = options.optionsToEndpoint(opts);
 
   const endpoint: ManifestEndpoint = {
+    ...initEndpoint(options.getGlobalOptions(), opts),
     platform: "gcfv2",
     ...baseOpts,
     ...specificOpts,

src/v2/providers/eventarc.ts

@@ -38,7 +38,7 @@ import {
   onCallHandler,
   Request,
 } from "../../common/providers/https";
-import { ManifestEndpoint } from "../../runtime/manifest";
+import { initEndpoint, ManifestEndpoint } from "../../runtime/manifest";
 import * as options from "../options";
 import { GlobalOptions, SupportedRegion } from "../options";
 import { Expression } from "../../params";
@@ -241,6 +241,7 @@ export function onRequest(
   // but optionsToTriggerAnnotations handles both cases.
   const specificOpts = options.optionsToEndpoint(opts as options.GlobalOptions);
   const endpoint: Partial<ManifestEndpoint> = {
+    ...initEndpoint(options.getGlobalOptions(), opts),
     platform: "gcfv2",
     ...baseOpts,
     ...specificOpts,
@@ -304,6 +305,7 @@ export function onCall<T = any, Return = any | Promise<any>>(
   // but optionsToEndpoint handles both cases.
   const specificOpts = options.optionsToEndpoint(opts);
   func.__endpoint = {
+    ...initEndpoint(options.getGlobalOptions(), opts),
     platform: "gcfv2",
     ...baseOpts,
     ...specificOpts,

src/v2/providers/https.ts

@@ -38,6 +38,7 @@ import { BlockingFunction } from "../../v1/cloud-functions";
 import { wrapTraceContext } from "../trace";
 import { Expression } from "../../params";
 import * as options from "../options";
+import { initEndpoint } from "../../runtime/manifest";
 
 export { AuthUserRecord, AuthBlockingEvent, HttpsError };
 
@@ -283,6 +284,7 @@ export function beforeOperation(
   const baseOptsEndpoint = options.optionsToEndpoint(options.getGlobalOptions());
   const specificOptsEndpoint = options.optionsToEndpoint(opts);
   func.__endpoint = {
+    ...initEndpoint(options.getGlobalOptions(), opts),
     platform: "gcfv2",
     ...baseOptsEndpoint,
     ...specificOptsEndpoint,

src/v2/providers/identity.ts

@@ -27,7 +27,7 @@
 
 import { copyIfPresent } from "../../common/encoding";
 import { ResetValue } from "../../common/options";
-import { ManifestEndpoint } from "../../runtime/manifest";
+import { initEndpoint, ManifestEndpoint } from "../../runtime/manifest";
 import { CloudEvent, CloudFunction } from "../core";
 import { wrapTraceContext } from "../trace";
 import { Expression } from "../../params";
@@ -306,6 +306,7 @@ export function onMessagePublished<T = any>(
   const specificOpts = options.optionsToEndpoint(opts);
 
   const endpoint: ManifestEndpoint = {
+    ...initEndpoint(options.getGlobalOptions(), opts),
     platform: "gcfv2",
     ...baseOpts,
     ...specificOpts,

src/v2/providers/pubsub.ts

@@ -20,7 +20,7 @@
 // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 // SOFTWARE.
 
-import { ManifestEndpoint } from "../../runtime/manifest";
+import { initEndpoint, ManifestEndpoint } from "../../runtime/manifest";
 import { CloudEvent, CloudFunction } from "../core";
 import { EventHandlerOptions, getGlobalOptions, optionsToEndpoint } from "../options";
 
@@ -137,6 +137,7 @@ export function onConfigUpdated(
   func.run = handler;
 
   const ep: ManifestEndpoint = {
+    ...initEndpoint(getGlobalOptions(), optsOrHandler),
     platform: "gcfv2",
     ...baseOpts,
     ...specificOpts,

src/v2/providers/remoteConfig.ts

@@ -26,6 +26,7 @@ import { copyIfPresent } from "../../common/encoding";
 import { ResetValue } from "../../common/options";
 import { timezone } from "../../common/timezone";
 import {
+  initEndpoint,
   initV2ScheduleTrigger,
   ManifestEndpoint,
   ManifestRequiredAPI,
@@ -179,6 +180,7 @@ export function onSchedule(
   const specificOptsEndpoint = options.optionsToEndpoint(separatedOpts.opts);
 
   const ep: ManifestEndpoint = {
+    ...initEndpoint(globalOpts, separatedOpts.opts),
     platform: "gcfv2",
     ...baseOptsEndpoint,
     ...specificOptsEndpoint,