Skip to content

Commit 4205069

Browse files
committed
Removed breaking change
1 parent cccd675 commit 4205069

File tree

3 files changed

+26
-11
lines changed

3 files changed

+26
-11
lines changed

common/api-review/data-connect.api.md

Lines changed: 24 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
import { AppCheckInternalComponentName } from '@firebase/app-check-interop-types';
88
import { FirebaseApp } from '@firebase/app';
99
import { FirebaseAuthInternalName } from '@firebase/auth-interop-types';
10+
import { FirebaseError } from '@firebase/util';
1011
import { LogLevelString } from '@firebase/logger';
1112
import { Provider } from '@firebase/component';
1213

@@ -23,6 +24,20 @@ export const CallerSdkTypeEnum: {
2324
readonly GeneratedAngular: "GeneratedAngular";
2425
};
2526

27+
// @public (undocumented)
28+
export type Code = DataConnectErrorCode;
29+
30+
// @public (undocumented)
31+
export const Code: {
32+
OTHER: DataConnectErrorCode;
33+
ALREADY_INITIALIZED: DataConnectErrorCode;
34+
NOT_INITIALIZED: DataConnectErrorCode;
35+
NOT_SUPPORTED: DataConnectErrorCode;
36+
INVALID_ARGUMENT: DataConnectErrorCode;
37+
PARTIAL_ERROR: DataConnectErrorCode;
38+
UNAUTHORIZED: DataConnectErrorCode;
39+
};
40+
2641
// @public
2742
export function connectDataConnectEmulator(dc: DataConnect, host: string, port?: number, sslEnabled?: boolean): void;
2843

@@ -51,20 +66,19 @@ export class DataConnect {
5166
setInitialized(): void;
5267
}
5368

69+
// @public
70+
export class DataConnectError extends FirebaseError {
71+
/* Excluded from this release type: name */
72+
constructor(code: Code, message: string);
73+
}
74+
5475
// @public (undocumented)
5576
export type DataConnectErrorCode = 'other' | 'already-initialized' | 'not-initialized' | 'not-supported' | 'invalid-argument' | 'partial-error' | 'unauthorized';
5677

5778
// @public
58-
export class DataConnectOperationError {
79+
export class DataConnectOperationError extends DataConnectError {
5980
/* Excluded from this release type: name */
60-
code: string;
61-
customData?: Record<string, unknown>;
62-
// (undocumented)
63-
message: string;
64-
name: string;
6581
readonly response: DataConnectOperationFailureResponse;
66-
// (undocumented)
67-
stack?: string;
6882
}
6983

7084
// @public (undocumented)
@@ -98,7 +112,7 @@ export interface DataConnectResult<Data, Variables> extends OpResult<Data> {
98112
// @public
99113
export interface DataConnectSubscription<Data, Variables> {
100114
// (undocumented)
101-
errCallback?: (e?: DataConnectOperationError) => void;
115+
errCallback?: (e?: DataConnectError) => void;
102116
// (undocumented)
103117
unsubscribe: () => void;
104118
// (undocumented)
@@ -149,7 +163,7 @@ export interface MutationResult<Data, Variables> extends DataConnectResult<Data,
149163
export type OnCompleteSubscription = () => void;
150164

151165
// @public
152-
export type OnErrorSubscription = (err?: DataConnectOperationError) => void;
166+
export type OnErrorSubscription = (err?: DataConnectError) => void;
153167

154168
// @public
155169
export type OnResultSubscription<Data, Variables> = (res: QueryResult<Data, Variables>) => void;

packages/data-connect/src/api/index.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,8 @@ export { setLogLevel } from '../logger';
2424
export { validateArgs } from '../util/validateArgs';
2525
export {
2626
DataConnectErrorCode,
27+
Code,
28+
DataConnectError,
2729
DataConnectOperationError,
2830
DataConnectOperationFailureResponse,
2931
DataConnectOperationFailureResponseErrorInfo

packages/data-connect/src/core/error.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,6 @@ export class DataConnectError extends FirebaseError {
4343
/** @internal */
4444
readonly name: string = 'DataConnectError';
4545

46-
/** @hideconstructor */
4746
constructor(code: Code, message: string) {
4847
super(code, message);
4948

0 commit comments

Comments
 (0)