Skip to content

Commit 70ffebf

Browse files
committed
Auto merge of rust-lang#6347 - flip1995:changelog, r=Manishearth
Changelog Rust 1.48 [Rendered](https://github.com/flip1995/rust-clippy/blob/changelog/CHANGELOG.md) This changelog is **big**. Hacktoberfest was pretty good for us, even though we had too few reviewers. changelog: none
2 parents 8325d48 + e9afdf0 commit 70ffebf

File tree

2 files changed

+134
-11
lines changed

2 files changed

+134
-11
lines changed

CHANGELOG.md

Lines changed: 115 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,117 @@ document.
66

77
## Unreleased / In Rust Nightly
88

9-
[e636b88...master](https://github.com/rust-lang/rust-clippy/compare/e636b88...master)
9+
[b20d4c1...master](https://github.com/rust-lang/rust-clippy/compare/b20d4c1...master)
10+
11+
## Rust 1.49
12+
13+
Current beta, release 2020-12-31
14+
15+
[e636b88...b20d4c1](https://github.com/rust-lang/rust-clippy/compare/e636b88...b20d4c1)
16+
17+
### New Lints
18+
19+
* [`field_reassign_with_default`] [#5911](https://github.com/rust-lang/rust-clippy/pull/5911)
20+
* [`await_holding_refcell_ref`] [#6029](https://github.com/rust-lang/rust-clippy/pull/6029)
21+
* [`disallowed_method`] [#6081](https://github.com/rust-lang/rust-clippy/pull/6081)
22+
* [`inline_asm_x86_att_syntax`] [#6092](https://github.com/rust-lang/rust-clippy/pull/6092)
23+
* [`inline_asm_x86_intel_syntax`] [#6092](https://github.com/rust-lang/rust-clippy/pull/6092)
24+
* [`from_iter_instead_of_collect`] [#6101](https://github.com/rust-lang/rust-clippy/pull/6101)
25+
* [`mut_mutex_lock`] [#6103](https://github.com/rust-lang/rust-clippy/pull/6103)
26+
* [`single_element_loop`] [#6109](https://github.com/rust-lang/rust-clippy/pull/6109)
27+
* [`manual_unwrap_or`] [#6123](https://github.com/rust-lang/rust-clippy/pull/6123)
28+
* [`large_types_passed_by_value`] [#6135](https://github.com/rust-lang/rust-clippy/pull/6135)
29+
* [`result_unit_err`] [#6157](https://github.com/rust-lang/rust-clippy/pull/6157)
30+
* [`ref_option_ref`] [#6165](https://github.com/rust-lang/rust-clippy/pull/6165)
31+
* [`manual_range_contains`] [#6177](https://github.com/rust-lang/rust-clippy/pull/6177)
32+
* [`unusual_byte_groupings`] [#6183](https://github.com/rust-lang/rust-clippy/pull/6183)
33+
* [`comparison_to_empty`] [#6226](https://github.com/rust-lang/rust-clippy/pull/6226)
34+
* [`map_collect_result_unit`] [#6227](https://github.com/rust-lang/rust-clippy/pull/6227)
35+
* [`manual_ok_or`] [#6233](https://github.com/rust-lang/rust-clippy/pull/6233)
36+
37+
### Moves and Deprecations
38+
39+
* Rename `single_char_push_str` to [`single_char_add_str`]
40+
[#6037](https://github.com/rust-lang/rust-clippy/pull/6037)
41+
* Rename `zero_width_space` to [`invisible_characters`]
42+
[#6105](https://github.com/rust-lang/rust-clippy/pull/6105)
43+
* Deprecate [`drop_bounds`] (uplifted)
44+
[#6111](https://github.com/rust-lang/rust-clippy/pull/6111)
45+
* Move [`string_lit_as_bytes`] to `nursery`
46+
[#6117](https://github.com/rust-lang/rust-clippy/pull/6117)
47+
* Move [`rc_buffer`] to `restriction`
48+
[#6128](https://github.com/rust-lang/rust-clippy/pull/6128)
49+
50+
### Enhancements
51+
52+
* [`manual_memcpy`]: Also lint when there are loop counters (and produce a
53+
reliable suggestion)
54+
[#5727](https://github.com/rust-lang/rust-clippy/pull/5727)
55+
* [`single_char_add_str`]: Also lint on `String::insert_str`
56+
[#6037](https://github.com/rust-lang/rust-clippy/pull/6037)
57+
* [`invisible_characters`]: Also lint the characters `\u{AD}` and `\u{2060}`
58+
[#6105](https://github.com/rust-lang/rust-clippy/pull/6105)
59+
* [`eq_op`]: Also lint on the `assert_*!` macro family
60+
[#6167](https://github.com/rust-lang/rust-clippy/pull/6167)
61+
* [`items_after_statements`]: Also lint in local macro expansions
62+
[#6176](https://github.com/rust-lang/rust-clippy/pull/6176)
63+
* [`unnecessary_cast`]: Also lint casts on integer and float literals
64+
[#6187](https://github.com/rust-lang/rust-clippy/pull/6187)
65+
* [`manual_unwrap_or`]: Also lint `Result::unwrap_or`
66+
[#6190](https://github.com/rust-lang/rust-clippy/pull/6190)
67+
* [`match_like_matches_macro`]: Also lint when `match` has more than two arms
68+
[#6216](https://github.com/rust-lang/rust-clippy/pull/6216)
69+
* [`integer_arithmetic`]: Better handle `/` an `%` operators
70+
[#6229](https://github.com/rust-lang/rust-clippy/pull/6229)
71+
72+
### False Positive Fixes
73+
74+
* [`needless_lifetimes`]: Bail out if the function has a `where` clause with the
75+
lifetime [#5978](https://github.com/rust-lang/rust-clippy/pull/5978)
76+
* [`explicit_counter_loop`]: No longer lints, when loop counter is used after it
77+
is incremented [#6076](https://github.com/rust-lang/rust-clippy/pull/6076)
78+
* [`or_fun_call`]: Revert changes addressing the handling of `const fn`
79+
[#6077](https://github.com/rust-lang/rust-clippy/pull/6077)
80+
* [`needless_range_loop`]: No longer lints, when the iterable is used in the
81+
range [#6102](https://github.com/rust-lang/rust-clippy/pull/6102)
82+
* [`inconsistent_digit_grouping`]: Fix bug when using floating point exponent
83+
[#6104](https://github.com/rust-lang/rust-clippy/pull/6104)
84+
* [`mistyped_literal_suffixes`]: No longer lints on the fractional part of a
85+
float (e.g. `713.32_64`)
86+
[#6114](https://github.com/rust-lang/rust-clippy/pull/6114)
87+
* [`invalid_regex`]: No longer lint on unicode characters within `bytes::Regex`
88+
[#6132](https://github.com/rust-lang/rust-clippy/pull/6132)
89+
* [`boxed_local`]: No longer lints on `extern fn` arguments
90+
[#6133](https://github.com/rust-lang/rust-clippy/pull/6133)
91+
* [`needless_lifetimes`]: Fix regression, where lifetime is used in `where`
92+
clause [#6198](https://github.com/rust-lang/rust-clippy/pull/6198)
93+
94+
### Suggestion Fixes/Improvements
95+
96+
* [`unnecessary_sort_by`]: Avoid dereferencing the suggested closure parameter
97+
[#6078](https://github.com/rust-lang/rust-clippy/pull/6078)
98+
* [`needless_arbitrary_self_type`]: Correctly handle expanded code
99+
[#6093](https://github.com/rust-lang/rust-clippy/pull/6093)
100+
* [`useless_format`]: Preserve raw strings in suggestion
101+
[#6151](https://github.com/rust-lang/rust-clippy/pull/6151)
102+
* [`empty_loop`]: Suggest alternatives
103+
[#6162](https://github.com/rust-lang/rust-clippy/pull/6162)
104+
* [`borrowed_box`]: Correctly add parentheses in suggestion
105+
[#6200](https://github.com/rust-lang/rust-clippy/pull/6200)
106+
* [`unused_unit`]: Improve suggestion formatting
107+
[#6247](https://github.com/rust-lang/rust-clippy/pull/6247)
108+
109+
### Documentation Improvements
110+
111+
* Some doc improvements:
112+
* [`rc_buffer`] [#6090](https://github.com/rust-lang/rust-clippy/pull/6090)
113+
* [`empty_loop`] [#6162](https://github.com/rust-lang/rust-clippy/pull/6162)
114+
* [`doc_markdown`]: Document problematic link text style
115+
[#6107](https://github.com/rust-lang/rust-clippy/pull/6107)
10116

11117
## Rust 1.48
12118

13-
Current beta, release 2020-11-19
119+
Current stable, released 2020-11-19
14120

15121
[09bd400...e636b88](https://github.com/rust-lang/rust-clippy/compare/09bd400...e636b88)
16122

@@ -56,15 +162,15 @@ Current beta, release 2020-11-19
56162

57163
* [`useless_attribute`]: permit allowing [`wildcard_imports`] and [`enum_glob_use`]
58164
[#5994](https://github.com/rust-lang/rust-clippy/pull/5994)
59-
* [`transmute_ptr_to_ptr`]: avoid suggesting dereferencing raw pointers in const contexts
165+
* [`transmute_ptr_to_ptr`]: avoid suggesting dereferencing raw pointers in const contexts
60166
[#5999](https://github.com/rust-lang/rust-clippy/pull/5999)
61167
* [`redundant_closure_call`]: take into account usages of the closure in nested functions and closures
62168
[#5920](https://github.com/rust-lang/rust-clippy/pull/5920)
63169
* Fix false positive in [`borrow_interior_mutable_const`] when referencing a field behind a pointer
64170
[#5949](https://github.com/rust-lang/rust-clippy/pull/5949)
65171
* [`doc_markdown`]: allow using "GraphQL" without backticks
66172
[#5996](https://github.com/rust-lang/rust-clippy/pull/5996)
67-
* [`to_string_in_display`]: avoid linting when calling `to_string()` on anything that is not `self`
173+
* [`to_string_in_display`]: avoid linting when calling `to_string()` on anything that is not `self`
68174
[#5971](https://github.com/rust-lang/rust-clippy/pull/5971)
69175
* [`indexing_slicing`] and [`out_of_bounds_indexing`] treat references to arrays as arrays
70176
[#6034](https://github.com/rust-lang/rust-clippy/pull/6034)
@@ -85,27 +191,27 @@ Current beta, release 2020-11-19
85191
[#5946](https://github.com/rust-lang/rust-clippy/pull/5946)
86192
* [`useless_conversion`]: show the type in the error message
87193
[#6035](https://github.com/rust-lang/rust-clippy/pull/6035)
88-
* [`unnecessary_mut_passed`]: discriminate between functions and methods in the error message
194+
* [`unnecessary_mut_passed`]: discriminate between functions and methods in the error message
89195
[#5892](https://github.com/rust-lang/rust-clippy/pull/5892)
90196
* [`float_cmp`] and [`float_cmp_const`]: change wording to make margin of error less ambiguous
91197
[#6043](https://github.com/rust-lang/rust-clippy/pull/6043)
92198
* [`default_trait_access`]: do not use unnecessary type parameters in the suggestion
93199
[#5993](https://github.com/rust-lang/rust-clippy/pull/5993)
94-
* [`collapsible_if`]: don't use expanded code in the suggestion
200+
* [`collapsible_if`]: don't use expanded code in the suggestion
95201
[#5992](https://github.com/rust-lang/rust-clippy/pull/5992)
96202
* Do not suggest empty format strings in [`print_with_newline`] and [`write_with_newline`]
97203
[#6042](https://github.com/rust-lang/rust-clippy/pull/6042)
98204
* [`unit_arg`]: improve the readability of the suggestion
99205
[#5931](https://github.com/rust-lang/rust-clippy/pull/5931)
100-
* [`stable_sort_primitive`]: print the type that is being sorted in the lint message
206+
* [`stable_sort_primitive`]: print the type that is being sorted in the lint message
101207
[#5935](https://github.com/rust-lang/rust-clippy/pull/5935)
102208
* Show line count and max lines in [`too_many_lines`] lint message
103209
[#6009](https://github.com/rust-lang/rust-clippy/pull/6009)
104210
* Keep parentheses in the suggestion of [`useless_conversion`] where applicable
105211
[#5900](https://github.com/rust-lang/rust-clippy/pull/5900)
106212
* [`option_map_unit_fn`] and [`result_map_unit_fn`]: print the unit type `()` explicitly
107213
[#6024](https://github.com/rust-lang/rust-clippy/pull/6024)
108-
* [`redundant_allocation`]: suggest replacing `Rc<Box<T>>` with `Rc<T>`
214+
* [`redundant_allocation`]: suggest replacing `Rc<Box<T>>` with `Rc<T>`
109215
[#5899](https://github.com/rust-lang/rust-clippy/pull/5899)
110216
* Make lint messages adhere to rustc dev guide conventions
111217
[#5893](https://github.com/rust-lang/rust-clippy/pull/5893)
@@ -128,7 +234,7 @@ Current beta, release 2020-11-19
128234

129235
## Rust 1.47
130236

131-
Current stable, released 2020-10-08
237+
Released 2020-10-08
132238

133239
[c2c07fa...09bd400](https://github.com/rust-lang/rust-clippy/compare/c2c07fa...09bd400)
134240

doc/changelog_update.md

Lines changed: 19 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,11 @@ bullet points might be helpful:
2929
* When writing the release notes for the **upcoming beta release**, you need to check
3030
out the Clippy commit of the current Rust `master`. [Link][rust_master_tools]
3131
* When writing the (forgotten) release notes for a **past stable release**, you
32-
need to select the Rust release tag from the dropdown and then check the
33-
commit of the Clippy directory:
32+
need to check out the Rust release tag of the stable release.
33+
[Link][rust_stable_tools]
34+
35+
Usually you want to wirte the changelog of the **upcoming stable release**. Make
36+
sure though, that `beta` was already branched in the Rust repository.
3437

3538
To find the commit hash, issue the following command when in a `rust-lang/rust` checkout:
3639
```
@@ -71,10 +74,24 @@ The order should roughly be:
7174
7. Documentation improvements
7275
8. Others
7376

77+
As section headers, we use:
78+
79+
```
80+
### New Lints
81+
### Moves and Deprecations
82+
### Enhancements
83+
### False Positive Fixes
84+
### Suggestion Fixes/Improvements
85+
### ICE Fixes
86+
### Documentation Improvements
87+
### Others
88+
```
89+
7490
Please also be sure to update the Beta/Unreleased sections at the top with the
7591
relevant commit ranges.
7692

7793
[changelog]: https://github.com/rust-lang/rust-clippy/blob/master/CHANGELOG.md
7894
[forge]: https://forge.rust-lang.org/
7995
[rust_master_tools]: https://github.com/rust-lang/rust/tree/master/src/tools/clippy
8096
[rust_beta_tools]: https://github.com/rust-lang/rust/tree/beta/src/tools/clippy
97+
[rust_stable_tools]: https://github.com/rust-lang/rust/releases

0 commit comments

Comments
 (0)