Skip to content

Commit f5bbd1b

Browse files
committed
Make tidy check for magic numbers that spell things
Remove existing problematic cases.
1 parent 1f3d6a6 commit f5bbd1b

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

tests/ui/unreadable_literal.fixed

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ fn main() {
3030
1_234.123_f32,
3131
1.123_4_f32,
3232
);
33-
let _bad = (0b11_0110_i64, 0xcafe_babe_usize, 123_456_f32, 1.234_567_f32);
33+
let _bad = (0b11_0110_i64, 0x1234_5678_usize, 123_456_f32, 1.234_567_f32);
3434
let _good_sci = 1.1234e1;
3535
let _bad_sci = 1.123_456e1;
3636

tests/ui/unreadable_literal.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ fn main() {
3030
1_234.123_f32,
3131
1.123_4_f32,
3232
);
33-
let _bad = (0b110110_i64, 0xcafebabe_usize, 123456_f32, 1.234567_f32);
33+
let _bad = (0b110110_i64, 0x12345678_usize, 123456_f32, 1.234567_f32);
3434
let _good_sci = 1.1234e1;
3535
let _bad_sci = 1.123456e1;
3636

tests/ui/unreadable_literal.stderr

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9,27 +9,27 @@ LL | 0x1_234_567,
99
error: long literal lacking separators
1010
--> $DIR/unreadable_literal.rs:33:17
1111
|
12-
LL | let _bad = (0b110110_i64, 0xcafebabe_usize, 123456_f32, 1.234567_f32);
12+
LL | let _bad = (0b110110_i64, 0x12345678_usize, 123456_f32, 1.234567_f32);
1313
| ^^^^^^^^^^^^ help: consider: `0b11_0110_i64`
1414
|
1515
= note: `-D clippy::unreadable-literal` implied by `-D warnings`
1616

1717
error: long literal lacking separators
1818
--> $DIR/unreadable_literal.rs:33:31
1919
|
20-
LL | let _bad = (0b110110_i64, 0xcafebabe_usize, 123456_f32, 1.234567_f32);
21-
| ^^^^^^^^^^^^^^^^ help: consider: `0xcafe_babe_usize`
20+
LL | let _bad = (0b110110_i64, 0x12345678_usize, 123456_f32, 1.234567_f32);
21+
| ^^^^^^^^^^^^^^^^ help: consider: `0x1234_5678_usize`
2222

2323
error: long literal lacking separators
2424
--> $DIR/unreadable_literal.rs:33:49
2525
|
26-
LL | let _bad = (0b110110_i64, 0xcafebabe_usize, 123456_f32, 1.234567_f32);
26+
LL | let _bad = (0b110110_i64, 0x12345678_usize, 123456_f32, 1.234567_f32);
2727
| ^^^^^^^^^^ help: consider: `123_456_f32`
2828

2929
error: long literal lacking separators
3030
--> $DIR/unreadable_literal.rs:33:61
3131
|
32-
LL | let _bad = (0b110110_i64, 0xcafebabe_usize, 123456_f32, 1.234567_f32);
32+
LL | let _bad = (0b110110_i64, 0x12345678_usize, 123456_f32, 1.234567_f32);
3333
| ^^^^^^^^^^^^ help: consider: `1.234_567_f32`
3434

3535
error: long literal lacking separators

0 commit comments

Comments
 (0)