Merge pull request #679 from martindurant/mkdir_twice

Do not ignore existing dir in local mkdir

Author: martindurant

fsspec/implementations/local.py

@@ -33,6 +33,8 @@ def __init__(self, auto_mkdir=False, **kwargs):
 
     def mkdir(self, path, create_parents=True, **kwargs):
         path = self._strip_protocol(path)
+        if self.exists(path):
+            raise FileExistsError(path)
         if create_parents:
             self.makedirs(path, exist_ok=True)
         else:

fsspec/implementations/tests/test_local.py

@@ -576,6 +576,14 @@ def test_strip_protocol_expanduser():
     assert not LocalFileSystem._strip_protocol("./").endswith("/")
 
 
+def test_mkdir_twice_faile(tmpdir):
+    fn = os.path.join(tmpdir, "test")
+    fs = fsspec.filesystem("file")
+    fs.mkdir(fn)
+    with pytest.raises(FileExistsError):
+        fs.mkdir(fn)
+
+
 def test_iterable(tmpdir):
     data = b"a\nhello\noi"
     fn = os.path.join(tmpdir, "test")