Skip to content

Commit d005ab2

Browse files
committed
Use storage url from .plist file if not setStorageUrl() hasn't been called.
- Fix weird error that NSError is not KVC compliant when storage is not configured JS - Fixed code seems to exist on several more locations but has not been fixed, since there are no tests to ensure I don't break anything.
1 parent 3ef3ce7 commit d005ab2

File tree

1 file changed

+4
-5
lines changed

1 file changed

+4
-5
lines changed

ios/Firestack/FirestackStorage.m

+4-5
Original file line numberDiff line numberDiff line change
@@ -52,14 +52,13 @@ - (dispatch_queue_t)methodQueue
5252
metadata:(NSDictionary *)metadata
5353
callback:(RCTResponseSenderBlock) callback)
5454
{
55+
FIRStorageReference *storageRef;
5556
if (urlStr == nil) {
56-
NSError *err = [[NSError alloc] init];
57-
[err setValue:@"Storage configuration error" forKey:@"name"];
58-
[err setValue:@"Call setStorageUrl() first" forKey:@"description"];
59-
return callback(@[err]);
57+
storageRef = [[FIRStorage storage] reference];
58+
} else {
59+
storageRef = [[FIRStorage storage] referenceForURL:urlStr];
6060
}
6161

62-
FIRStorageReference *storageRef = [[FIRStorage storage] referenceForURL:urlStr];
6362
FIRStorageReference *uploadRef = [storageRef child:name];
6463
FIRStorageMetadata *firmetadata = [[FIRStorageMetadata alloc] initWithDictionary:metadata];
6564

0 commit comments

Comments
 (0)