fix(sourcemaps): don't attempt to treat remote URL as a local file path (#1850)

Author: brettdh

src/utils/sourcemaps.rs

@@ -239,6 +239,14 @@ fn url_matches_extension(url: &str, extensions: &[&str]) -> bool {
         .unwrap_or(false)
 }
 
+/// Return true iff url is a remote url (not a local path or embedded sourcemap).
+fn is_remote_url(url: &str) -> bool {
+    return match Url::parse(url) {
+        Ok(url) => url.scheme() != "data",
+        Err(_) => false,
+    };
+}
+
 impl SourceMapProcessor {
     /// Creates a new sourcemap validator.
     pub fn new() -> SourceMapProcessor {
@@ -364,7 +372,14 @@ impl SourceMapProcessor {
                 continue;
             };
 
-            let sourcemap_reference = match discover_sourcemaps_location(contents) {
+            // If this is a full external URL, the code below is going to attempt
+            // to "normalize" it with the source path, resulting in a bogus path
+            // like "path/to/source/dir/https://some-static-host.example.com/path/to/foo.js.map"
+            // that can't be resolved to a source map file.
+            // Instead, we pretend we failed to discover the location, and we fall back to
+            // guessing the source map location based on the source location.
+            let location = discover_sourcemaps_location(contents).filter(|loc| !is_remote_url(loc));
+            let sourcemap_reference = match location {
                 Some(url) => SourceMapReference::from_url(url.to_string()),
                 None => match guess_sourcemap_reference(&sourcemaps, &source.url) {
                     Ok(target) => target,

tests/integration/_cases/sourcemaps/sourcemaps-inject-split-ambiguous.trycmd

@@ -9,9 +9,9 @@ $ sentry-cli sourcemaps inject ./code ./maps ./maps2 --log-level warn
 > Found 1 file
 > Analyzing 5 sources
 > Injecting debug ids
-  WARN    [..]-[..]-[..] [..]:[..]:[..].[..] +[..]:[..] Ambiguous matches for sourcemap path ./code/foo/index.js.map:
-  WARN    [..]-[..]-[..] [..]:[..]:[..].[..] +[..]:[..] ./maps/foo/index.js.map
-  WARN    [..]-[..]-[..] [..]:[..]:[..].[..] +[..]:[..] ./maps2/foo/index.js.map
+  WARN    [..]-[..]-[..] [..]:[..]:[..].[..] [..]:[..] Ambiguous matches for sourcemap path ./code/foo/index.js.map:
+  WARN    [..]-[..]-[..] [..]:[..]:[..].[..] [..]:[..] ./maps/foo/index.js.map
+  WARN    [..]-[..]-[..] [..]:[..]:[..].[..] [..]:[..] ./maps2/foo/index.js.map
 
 Source Map Debug ID Injection Report
   Modified: The following source files have been modified to have debug ids

tests/integration/_cases/sourcemaps/sourcemaps-inject.trycmd

@@ -2,17 +2,18 @@
 $ sentry-cli sourcemaps inject ./server ./static
 ? success
 > Searching ./server
-> Found 12 files
+> Found 14 files
 > Searching ./static
 > Found 8 files
-> Analyzing 20 sources
+> Analyzing 22 sources
 > Injecting debug ids
 
 Source Map Debug ID Injection Report
   Modified: The following source files have been modified to have debug ids
     [..]-[..]-[..]-[..]-[..] - ./server/app/page.js
     [..]-[..]-[..]-[..]-[..] - ./server/chunks/1.js
     [..]-[..]-[..]-[..]-[..] - ./server/dummy_embedded.js
+    [..]-[..]-[..]-[..]-[..] - ./server/dummy_hosted.js
     [..]-[..]-[..]-[..]-[..] - ./server/flight-manifest.js
     [..]-[..]-[..]-[..]-[..] - ./server/pages/_document.js
     [..]-[..]-[..]-[..]-[..] - ./server/pages/api/hello.js
@@ -21,6 +22,7 @@ Source Map Debug ID Injection Report
     [..]-[..]-[..]-[..]-[..] - ./static/chunks/app/head-172ad45600676c06.js
     [..]-[..]-[..]-[..]-[..] - ./static/chunks/pages/asdf-05b39167abbe433b.js
   Modified: The following sourcemap files have been modified to have debug ids
+    [..]-[..]-[..]-[..]-[..] - ./server/dummy_hosted.js.map
     [..]-[..]-[..]-[..]-[..] - ./server/pages/_document.js.map
     [..]-[..]-[..]-[..]-[..] - ./static/chunks/575-bb7d7e0e6de8d623.js.map
   Ignored: The following source files already have debug ids

tests/integration/_cases/sourcemaps/sourcemaps-upload-some-debugids.trycmd

@@ -5,14 +5,14 @@ $ sentry-cli sourcemaps upload tests/integration/_fixtures/upload_some_debugids
 > Analyzing 20 sources
 > Rewriting sources
 > Adding source map references
-  WARN    [..]-[..]-[..] [..]:[..]:[..].[..] +[..]:[..] Some source files don't have debug ids:
-  WARN    [..]-[..]-[..] [..]:[..]:[..].[..] +[..]:[..] - ~/server/app/page.js
-  WARN    [..]-[..]-[..] [..]:[..]:[..].[..] +[..]:[..] - ~/server/chunks/1.js
-  WARN    [..]-[..]-[..] [..]:[..]:[..].[..] +[..]:[..] - ~/server/dummy_embedded.js
-  WARN    [..]-[..]-[..] [..]:[..]:[..].[..] +[..]:[..] - ~/server/pages/_document.js
-  WARN    [..]-[..]-[..] [..]:[..]:[..].[..] +[..]:[..] - ~/server/pages/api/hello.js
-  WARN    [..]-[..]-[..] [..]:[..]:[..].[..] +[..]:[..] - ~/static/chunks/575-bb7d7e0e6de8d623.js
-  WARN    [..]-[..]-[..] [..]:[..]:[..].[..] +[..]:[..] - ~/static/chunks/pages/asdf-05b39167abbe433b.js
+  WARN    [..]-[..]-[..] [..]:[..]:[..].[..] [..]:[..] Some source files don't have debug ids:
+  WARN    [..]-[..]-[..] [..]:[..]:[..].[..] [..]:[..] - ~/server/app/page.js
+  WARN    [..]-[..]-[..] [..]:[..]:[..].[..] [..]:[..] - ~/server/chunks/1.js
+  WARN    [..]-[..]-[..] [..]:[..]:[..].[..] [..]:[..] - ~/server/dummy_embedded.js
+  WARN    [..]-[..]-[..] [..]:[..]:[..].[..] [..]:[..] - ~/server/pages/_document.js
+  WARN    [..]-[..]-[..] [..]:[..]:[..].[..] [..]:[..] - ~/server/pages/api/hello.js
+  WARN    [..]-[..]-[..] [..]:[..]:[..].[..] [..]:[..] - ~/static/chunks/575-bb7d7e0e6de8d623.js
+  WARN    [..]-[..]-[..] [..]:[..]:[..].[..] [..]:[..] - ~/static/chunks/pages/asdf-05b39167abbe433b.js
 > Bundled 20 files for upload
 > Bundle ID: [..]-[..]-[..]-[..]-[..]
 > Uploaded files to Sentry