Skip to content

Commit 073b649

Browse files
authored
ci: Fix node dependencies for CI jobs (#12484)
Ensure we run node-integration, remix, nextjs tests for changes in opentelemetry package. You can see how this PR: #12477 did not trigger node-integration tests 😬
1 parent 091cd3a commit 073b649

File tree

1 file changed

+10
-5
lines changed

1 file changed

+10
-5
lines changed

.github/workflows/build.yml

+10-5
Original file line numberDiff line numberDiff line change
@@ -108,6 +108,10 @@ jobs:
108108
- 'packages/replay-canvas/**'
109109
- 'packages/feedback/**'
110110
- 'packages/wasm/**'
111+
node: &node
112+
- *shared
113+
- 'packages/node/**'
114+
- 'packages/opentelemetry/**'
111115
browser_integration:
112116
- *shared
113117
- *browser
@@ -116,21 +120,21 @@ jobs:
116120
- *shared
117121
- *browser
118122
- 'packages/ember/**'
119-
node:
123+
node_integration:
120124
- *shared
121-
- 'packages/node/**'
125+
- *node
122126
- 'dev-packages/node-integration-tests/**'
123127
nextjs:
124128
- *shared
125129
- *browser
130+
- *node
126131
- 'packages/nextjs/**'
127-
- 'packages/node/**'
128132
- 'packages/react/**'
129133
remix:
130134
- *shared
131135
- *browser
136+
- *node
132137
- 'packages/remix/**'
133-
- 'packages/node/**'
134138
- 'packages/react/**'
135139
profiling_node:
136140
- *shared
@@ -157,6 +161,7 @@ jobs:
157161
changed_ember: ${{ steps.changed.outputs.ember }}
158162
changed_remix: ${{ steps.changed.outputs.remix }}
159163
changed_node: ${{ steps.changed.outputs.node }}
164+
changed_node_integration: ${{ steps.changed.outputs.node_integration }}
160165
changed_profiling_node: ${{ steps.changed.outputs.profiling_node }}
161166
changed_profiling_node_bindings: ${{ steps.changed.outputs.profiling_node_bindings }}
162167
changed_deno: ${{ steps.changed.outputs.deno }}
@@ -862,7 +867,7 @@ jobs:
862867
Node (${{ matrix.node }})${{ (matrix.typescript && format(' (TS {0})', matrix.typescript)) || '' }} Integration
863868
Tests
864869
needs: [job_get_metadata, job_build]
865-
if: needs.job_get_metadata.outputs.changed_node == 'true' || github.event_name != 'pull_request'
870+
if: needs.job_get_metadata.outputs.changed_node_integration == 'true' || github.event_name != 'pull_request'
866871
runs-on: ubuntu-20.04
867872
timeout-minutes: 15
868873
strategy:

0 commit comments

Comments
 (0)