Skip to content

Commit 0a4f278

Browse files
onurtemizkanlobsterkatie
onurtemizkan
and
lobsterkatie
authored
feat(tests): Run Playwright tests using bundles. (#4551)
Co-authored-by: Katie Byers <[email protected]>
1 parent ab73aa8 commit 0a4f278

File tree

46 files changed

+253
-366
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

46 files changed

+253
-366
lines changed

‎.github/workflows/build.yml

Lines changed: 21 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -276,9 +276,26 @@ jobs:
276276
${{ github.workspace }}/packages/serverless/dist-awslambda-layer/*.zip
277277
278278
job_browser_playwright_tests:
279-
name: Browser Playwright Tests
279+
name: Browser Playwright Tests (${{ matrix.bundle }} - tracing_only = ${{ matrix.tracing_only }})
280280
needs: job_build
281281
runs-on: ubuntu-latest
282+
strategy:
283+
matrix:
284+
bundle:
285+
- esm
286+
- cjs
287+
- bundle_es5
288+
- bundle_es5_min
289+
- bundle_es6
290+
- bundle_es6_min
291+
tracing_only:
292+
- true
293+
- false
294+
exclude:
295+
- bundle: esm
296+
tracing_only: true
297+
- bundle: cjs
298+
tracing_only: true
282299
steps:
283300
- name: Check out current commit (${{ github.sha }})
284301
uses: actions/checkout@v2
@@ -297,6 +314,9 @@ jobs:
297314
path: ${{ env.CACHED_BUILD_PATHS }}
298315
key: ${{ env.BUILD_CACHE_KEY }}
299316
- name: Run Playwright tests
317+
env:
318+
PW_BUNDLE: ${{ matrix.bundle }}
319+
PW_TRACING_ONLY: ${{ matrix.tracing_only }}
300320
run: |
301321
cd packages/integration-tests
302322
yarn run playwright install-deps webkit

‎packages/integration-tests/README.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,9 @@ To filter tests by their title:
5656

5757
You can refer to [Playwright documentation](https://playwright.dev/docs/test-cli) for other CLI options.
5858

59+
You can set env variable `PW_BUNDLE` to set specific build or bundle to test against.
60+
Available options: `esm`, `cjs`, `bundle_es5`, `bundle_es5_min`, `bundle_es6`, `bundle_es6_min`
61+
5962
### Troubleshooting
6063

6164
Apart from [Playwright-specific issues](https://playwright.dev/docs/troubleshooting), below are common issues that might occur while writing tests for Sentry Browser SDK.

‎packages/integration-tests/package.json

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,16 +13,21 @@
1313
"lint": "run-s lint:prettier lint:eslint",
1414
"lint:eslint": "eslint . --cache --cache-location '../../eslintcache/' --format stylish",
1515
"lint:prettier": "prettier --check \"{suites,utils}/**/*.ts\"",
16-
"test:ci": "playwright test ./suites --browser='all' --reporter='line'",
1716
"type-check": "tsc",
1817
"pretest": "yarn clean && yarn type-check",
19-
"test": "playwright test ./suites"
18+
"test": "playwright test ./suites",
19+
"test:bundle:es5": "PW_BUNDLE=bundle_es5 yarn test",
20+
"test:bundle:es5:min": "PW_BUNDLE=bundle_es5_min yarn test",
21+
"test:bundle:es6": "PW_BUNDLE=bundle_es6 yarn test",
22+
"test:bundle:es6:min": "PW_BUNDLE=bundle_es6_min yarn test",
23+
"test:cjs": "PW_BUNDLE=cjs yarn test",
24+
"test:esm": "PW_BUNDLE=esm yarn test",
25+
"test:ci": "playwright test ./suites --browser='all' --reporter='line'"
2026
},
2127
"dependencies": {
2228
"@babel/preset-typescript": "^7.16.7",
2329
"@playwright/test": "^1.17.0",
2430
"babel-loader": "^8.2.2",
25-
"handlebars-loader": "^1.7.1",
2631
"html-webpack-plugin": "^5.5.0",
2732
"playwright": "^1.17.1",
2833
"typescript": "^4.5.2",

‎packages/integration-tests/suites/public-api/addBreadcrumb/template.hbs

Lines changed: 0 additions & 11 deletions
This file was deleted.

‎packages/integration-tests/suites/public-api/captureException/template.hbs

Lines changed: 0 additions & 11 deletions
This file was deleted.

‎packages/integration-tests/suites/public-api/captureMessage/template.hbs

Lines changed: 0 additions & 11 deletions
This file was deleted.

‎packages/integration-tests/suites/public-api/configureScope/template.hbs

Lines changed: 0 additions & 11 deletions
This file was deleted.

‎packages/integration-tests/suites/public-api/setContext/template.hbs

Lines changed: 0 additions & 11 deletions
This file was deleted.

‎packages/integration-tests/suites/public-api/setExtra/template.hbs

Lines changed: 0 additions & 11 deletions
This file was deleted.

‎packages/integration-tests/suites/public-api/setExtras/template.hbs

Lines changed: 0 additions & 11 deletions
This file was deleted.

‎packages/integration-tests/suites/public-api/setTag/template.hbs

Lines changed: 0 additions & 11 deletions
This file was deleted.

‎packages/integration-tests/suites/public-api/setTags/template.hbs

Lines changed: 0 additions & 11 deletions
This file was deleted.

‎packages/integration-tests/suites/public-api/setUser/template.hbs

Lines changed: 0 additions & 11 deletions
This file was deleted.

‎packages/integration-tests/suites/public-api/showReportDialog/template.hbs

Lines changed: 0 additions & 11 deletions
This file was deleted.

‎packages/integration-tests/suites/public-api/startTransaction/template.hbs

Lines changed: 0 additions & 11 deletions
This file was deleted.

‎packages/integration-tests/suites/public-api/withScope/template.hbs

Lines changed: 0 additions & 11 deletions
This file was deleted.

‎packages/integration-tests/suites/sessions/start-session/template.hbs

Lines changed: 0 additions & 11 deletions
This file was deleted.

‎packages/integration-tests/suites/sessions/start-session/template.html

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
<html>
2+
<head>
3+
<meta charset="utf-8" />
4+
</head>
5+
<body>
6+
<a id='navigate' href="foo">Navigate</button>
7+
</body>
8+
</html>

‎packages/integration-tests/suites/sessions/update-session/template.hbs

Lines changed: 0 additions & 12 deletions
This file was deleted.

‎packages/integration-tests/suites/sessions/update-session/template.html

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
<html>
2+
<head>
3+
<meta charset="utf-8" />
4+
</head>
5+
<body>
6+
<button id="throw-error">Throw Error</button>
7+
<button id="capture-exception">Capture Exception</button>
8+
</body>
9+
</html>

‎packages/integration-tests/suites/tracing/browsertracing/backgroundtab-custom/template.hbs renamed to ‎packages/integration-tests/suites/tracing/browsertracing/backgroundtab-custom/template.html

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,9 @@
1-
<!DOCTYPE html>
21
<html>
32
<head>
4-
<script src="{{htmlWebpackPlugin.options.initialization}}"></script>
3+
<meta charset="utf-8" />
54
</head>
65
<body>
76
<button id="start-transaction">Start Transaction</button>
87
<button id="go-background">New Tab</button>
9-
<script src="{{htmlWebpackPlugin.options.subject}}"></script>
108
</body>
119
</html>

‎packages/integration-tests/suites/tracing/browsertracing/backgroundtab-pageload/template.hbs

Lines changed: 0 additions & 10 deletions
This file was deleted.

‎packages/integration-tests/suites/tracing/browsertracing/backgroundtab-pageload/template.html

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
<html>
2+
<head>
3+
<meta charset="utf-8" />
4+
</head>
5+
<body>
6+
<button id="go-background">New Tab</button>
7+
</body>
8+
</html>

‎packages/integration-tests/suites/tracing/browsertracing/meta/template.hbs

Lines changed: 0 additions & 10 deletions
This file was deleted.

‎packages/integration-tests/suites/tracing/browsertracing/meta/template.html

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
<html>
2+
<head>
3+
<meta charset="utf-8" />
4+
<meta name="sentry-trace" content="12312012123120121231201212312012-1121201211212012-1" />
5+
</head>
6+
</html>

‎packages/integration-tests/suites/tracing/browsertracing/template.hbs

Lines changed: 0 additions & 11 deletions
This file was deleted.

‎packages/integration-tests/suites/tracing/metrics/connection-rtt/template.hbs

Lines changed: 0 additions & 11 deletions
This file was deleted.

‎packages/integration-tests/suites/tracing/metrics/connection-rtt/template.html

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
<html>
2+
<head>
3+
<meta charset="utf-8" />
4+
</head>
5+
<body>
6+
<div>Rendered</div>
7+
</body>
8+
</html>

‎packages/integration-tests/suites/tracing/metrics/pageload-resource-spans/template.hbs renamed to ‎packages/integration-tests/suites/tracing/metrics/pageload-resource-spans/template.html

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,11 @@
1-
<!DOCTYPE html>
21
<html>
32
<head>
43
<meta charset="utf-8" />
5-
<title></title>
6-
<script src="{{htmlWebpackPlugin.options.initialization}}"></script>
74
</head>
85
<body>
9-
<img src="https://example.com/path/to/image.svg">
6+
<img src="https://example.com/path/to/image.svg" />
107
<script src="https://example.com/path/to/script.js"></script>
11-
<link href="https://example.com/path/to/style.css" type="text/css" rel="stylesheet">
8+
<link href="https://example.com/path/to/style.css" type="text/css" rel="stylesheet" />
129
<span>Rendered</span>
1310
</body>
1411
</html>

‎packages/integration-tests/suites/tracing/metrics/template.hbs

Lines changed: 0 additions & 12 deletions
This file was deleted.

‎packages/integration-tests/suites/tracing/metrics/web-vitals-cls/template.hbs

Lines changed: 0 additions & 12 deletions
This file was deleted.

0 commit comments

Comments
 (0)