update e2e test to test for new node

Author: mydea

dev-packages/e2e-tests/test-applications/node-exports-test-app/package.json

@@ -13,6 +13,7 @@
   },
   "dependencies": {
     "@sentry/node-experimental": "latest || *",
+    "@sentry/node": "latest || *",
     "@sentry/sveltekit": "latest || *",
     "@sentry/remix": "latest || *",
     "@sentry/astro": "latest || *",

dev-packages/e2e-tests/test-applications/node-exports-test-app/scripts/consistentExports.ts

@@ -1,38 +1,49 @@
 import * as SentryAstro from '@sentry/astro';
 import * as SentryBun from '@sentry/bun';
 import * as SentryNextJs from '@sentry/nextjs';
-import * as SentryNode from '@sentry/node-experimental';
+import * as SentryNode from '@sentry/node';
+import * as SentryNodeExperimental from '@sentry/node-experimental';
 import * as SentryRemix from '@sentry/remix';
 import * as SentryServerless from '@sentry/serverless';
 import * as SentrySvelteKit from '@sentry/sveltekit';
 
+/* List of exports that are safe to ignore / we don't require in any depending package */
+const NODE_EXPERIMENTAL_EXPORTS_IGNORE = [
+  'default',
+  // Probably generated by transpilation, no need to require it
+  '__esModule',
+];
+
 /* List of exports that are safe to ignore / we don't require in any depending package */
 const NODE_EXPORTS_IGNORE = [
   'default',
   // Probably generated by transpilation, no need to require it
   '__esModule',
-  // These Node exports were only made for type definition fixes (see #10339)
-  'Undici',
-  'Http',
-  'DebugSession',
-  'AnrIntegrationOptions',
-  'LocalVariablesIntegrationOptions',
 ];
 
+/* Sanitized list of node exports */
+const nodeExperimentalExports = Object.keys(SentryNodeExperimental).filter(
+  e => !NODE_EXPERIMENTAL_EXPORTS_IGNORE.includes(e),
+);
+const nodeExports = Object.keys(SentryNode).filter(e => !NODE_EXPORTS_IGNORE.includes(e));
+
 type Dependent = {
   package: string;
   exports: string[];
   ignoreExports?: string[];
   skip?: boolean;
+  compareWith: string[];
 };
 
 const DEPENDENTS: Dependent[] = [
   {
     package: '@sentry/astro',
+    compareWith: nodeExports,
     exports: Object.keys(SentryAstro),
   },
   {
     package: '@sentry/bun',
+    compareWith: nodeExperimentalExports,
     exports: Object.keys(SentryBun),
     ignoreExports: [
       // not supported in bun:
@@ -44,35 +55,36 @@ const DEPENDENTS: Dependent[] = [
   },
   {
     package: '@sentry/nextjs',
+    compareWith: nodeExperimentalExports,
     // Next.js doesn't require explicit exports, so we can just merge top level and `default` exports:
     // @ts-expect-error: `default` is not in the type definition but it's defined
     exports: Object.keys({ ...SentryNextJs, ...SentryNextJs.default }),
   },
   {
     package: '@sentry/remix',
+    compareWith: nodeExperimentalExports,
     exports: Object.keys(SentryRemix),
   },
   {
     package: '@sentry/serverless',
+    compareWith: nodeExperimentalExports,
     exports: Object.keys(SentryServerless),
     ignoreExports: ['cron', 'hapiErrorPlugin'],
   },
   {
     package: '@sentry/sveltekit',
+    compareWith: nodeExperimentalExports,
     exports: Object.keys(SentrySvelteKit),
   },
 ];
 
-/* Sanitized list of node exports */
-const nodeExports = Object.keys(SentryNode).filter(e => !NODE_EXPORTS_IGNORE.includes(e));
-
 console.log('🔎 Checking for consistent exports of @sentry/node exports in depending packages');
 
 const missingExports: Record<string, string[]> = {};
 const dependentsToCheck = DEPENDENTS.filter(d => !d.skip);
 
-for (const nodeExport of nodeExports) {
-  for (const dependent of dependentsToCheck) {
+for (const dependent of dependentsToCheck) {
+  for (const nodeExport of dependent.compareWith) {
     if (dependent.ignoreExports?.includes(nodeExport)) {
       continue;
     }