Skip to content

Commit 216437e

Browse files
committed
try #6
1 parent 8892f89 commit 216437e

File tree

1 file changed

+7
-8
lines changed
  • dev-packages/browser-integration-tests/suites/tracing/metrics/web-vitals-lcp

1 file changed

+7
-8
lines changed

dev-packages/browser-integration-tests/suites/tracing/metrics/web-vitals-lcp/test.ts

+7-8
Original file line numberDiff line numberDiff line change
@@ -9,29 +9,28 @@ sentryTest('should capture a LCP vital with element details.', async ({ browserN
99
if (shouldSkipTracingTest() || browserName !== 'chromium') {
1010
sentryTest.skip();
1111
}
12-
const imageSrc = 'https://example.com/path/to/image.png';
13-
const imageResponsePromise = page.waitForResponse(imageSrc);
1412
page.route('**', route => route.continue());
1513
page.route('**/path/to/image.png', async (route: Route) => {
1614
return route.fulfill({ path: `${__dirname}/assets/sentry-logo-600x179.png` });
1715
});
1816

1917
const url = await getLocalTestPath({ testDir: __dirname });
20-
const [eventData, imageResponse] = await Promise.all([
18+
const [eventData] = await Promise.all([
2119
getFirstSentryEnvelopeRequest<Event>(page),
2220
page.goto(url),
23-
imageResponsePromise,
21+
// Clicking the button before image loads will result in the button being the LCP
22+
page.waitForFunction(() => {
23+
const images = Array.from(document.querySelectorAll('img'));
24+
return images.every(img => img.complete);
25+
}),
2426
]);
2527

26-
await imageResponse?.finished();
27-
28-
// Clicking the button before image loads will result in the button being the LCP
2928
await page.locator('button').click();
3029

3130
expect(eventData.measurements).toBeDefined();
3231
expect(eventData.measurements?.lcp?.value).toBeDefined();
3332

3433
expect(eventData.contexts?.trace?.data?.['lcp.element']).toBe('body > img');
3534
expect(eventData.contexts?.trace?.data?.['lcp.size']).toBe(107400);
36-
expect(eventData.contexts?.trace?.data?.['lcp.url']).toBe(imageSrc);
35+
expect(eventData.contexts?.trace?.data?.['lcp.url']).toBe('https://example.com/path/to/image.png');
3736
});

0 commit comments

Comments
 (0)