Skip to content

Commit 3158c21

Browse files
authored
ci: Ensure cache save happens after install step (#13497)
Noticed e.g. here: https://github.com/getsentry/sentry-javascript/actions/runs/10594383971/job/29359100222 that saving of the cache was not working. I guess this only works for the combined restore/save step, but here it expects that the cached data is there immediately (which makes sense!).
1 parent 664d305 commit 3158c21

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

.github/actions/install-playwright/action.yml

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -21,15 +21,6 @@ runs:
2121
~/.cache/ms-playwright
2222
key: playwright-${{ runner.os }}-${{ steps.playwright-version.outputs.version }}
2323

24-
# Only store cache on develop branch
25-
- name: Store cached playwright binaries
26-
uses: actions/cache/save@v4
27-
if: github.event_name == 'push' && github.ref == 'refs/heads/develop'
28-
with:
29-
path: |
30-
~/.cache/ms-playwright
31-
key: playwright-${{ runner.os }}-${{ steps.playwright-version.outputs.version }}
32-
3324
# We always install all browsers, if uncached
3425
- name: Install Playwright dependencies (uncached)
3526
run: npx playwright install chromium webkit firefox --with-deps
@@ -40,3 +31,12 @@ runs:
4031
run: npx playwright install-deps ${{ inputs.browsers || 'chromium webkit firefox' }}
4132
if: steps.playwright-cache.outputs.cache-hit == 'true'
4233
shell: bash
34+
35+
# Only store cache on develop branch
36+
- name: Store cached playwright binaries
37+
uses: actions/cache/save@v4
38+
if: github.event_name == 'push' && github.ref == 'refs/heads/develop'
39+
with:
40+
path: |
41+
~/.cache/ms-playwright
42+
key: playwright-${{ runner.os }}-${{ steps.playwright-version.outputs.version }}

0 commit comments

Comments
 (0)