escape distDir in regex

Author: lobsterkatie

packages/nextjs/src/index.server.ts

@@ -1,6 +1,6 @@
 import { RewriteFrames } from '@sentry/integrations';
 import { configureScope, getCurrentHub, init as nodeInit, Integrations } from '@sentry/node';
-import { logger } from '@sentry/utils';
+import { escapeStringForRegex, logger } from '@sentry/utils';
 
 import { instrumentServer } from './utils/instrumentServer';
 import { MetadataBuilder } from './utils/metadataBuilder';
@@ -47,7 +47,7 @@ function sdkAlreadyInitialized(): boolean {
 }
 
 // webpack will replace this placeholder at build time
-const SOURCEMAP_FILENAME_REGEX = new RegExp('__rewriteFramesDistDir__');
+const SOURCEMAP_FILENAME_REGEX = new RegExp(escapeStringForRegex('__rewriteFramesDistDir__'));
 
 const defaultRewriteFramesIntegration = new RewriteFrames({
   iteratee: frame => {

packages/nextjs/test/config.test.ts

@@ -361,7 +361,9 @@ describe('webpack config', () => {
       );
     });
     describe('`RewriteFrames` ends up with correct `distDir` value', () => {
-      // TODO: this, along with any number of other parts of the build process, should be tested with an integration test
+      // TODO: this, along with any number of other parts of the build process, should be tested with an integration
+      // test (and that integration test should test custom `distDir` values with and without a `.`, to make sure the
+      // regex escaping is working)
     });
   });
 });

packages/utils/src/string.ts

@@ -101,3 +101,20 @@ export function isMatchingPattern(value: string, pattern: RegExp | string): bool
   }
   return false;
 }
+
+/**
+ * Given a string, escape characters which have meaning in the regex grammar, such that the result is safe to feed to
+ * `new RegExp()`.
+ *
+ * Based on https://github.com/sindresorhus/escape-string-regexp. Vendored to a) reduce the size by skipping the runtime
+ * type-checking, and b) ensure it gets down-compiled for old versions of Node (the published package only supports Node
+ * 12+).
+ *
+ * @param regexString The string to escape
+ * @returns An version of the string with all special regex characters escaped
+ */
+export function escapeStringForRegex(regexString: string): string {
+  // escape the hyphen separately so we can also replace it with a unicode literal hyphen, to avoid the problems
+  // discussed in https://github.com/sindresorhus/escape-string-regexp/issues/20.
+  return regexString.replace(/[|\\{}()[\]^$+*?.]/g, '\\$&').replace(/-/g, '\\x2d');
+}