Skip to content

Commit 33dda58

Browse files
committed
fix replay test
1 parent 0db0634 commit 33dda58

File tree

2 files changed

+6
-36
lines changed

2 files changed

+6
-36
lines changed

packages/replay/test/integration/coreHandlers/handleAfterSendEvent.test.ts

Lines changed: 5 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,8 @@ describe('Integration | coreHandlers | handleAfterSendEvent', () => {
3535

3636
const handler = handleAfterSendEvent(replay);
3737

38-
// With undefined response: Don't capture
39-
handler(error1, undefined);
38+
// With empty response: Don't capture
39+
handler(error1, {});
4040
// With "successful" response: Capture
4141
handler(error2, { statusCode: 200 });
4242
// With "unsuccessful" response: Don't capture
@@ -66,8 +66,8 @@ describe('Integration | coreHandlers | handleAfterSendEvent', () => {
6666

6767
const handler = handleAfterSendEvent(replay);
6868

69-
// With undefined response: Don't capture
70-
handler(transaction1, undefined);
69+
// With empty response: Don't capture
70+
handler(transaction1, {});
7171
// With "successful" response: Capture
7272
handler(transaction2, { statusCode: 200 });
7373
// With "unsuccessful" response: Don't capture
@@ -141,36 +141,6 @@ describe('Integration | coreHandlers | handleAfterSendEvent', () => {
141141
);
142142
});
143143

144-
it('allows undefined send response when using custom transport', async () => {
145-
({ replay } = await resetSdkMock({
146-
replayOptions: {
147-
stickySession: false,
148-
},
149-
sentryOptions: {
150-
replaysSessionSampleRate: 1.0,
151-
replaysOnErrorSampleRate: 0.0,
152-
},
153-
}));
154-
155-
const error1 = Error({ event_id: 'err1' });
156-
const error2 = Error({ event_id: 'err2' });
157-
const error3 = Error({ event_id: 'err3' });
158-
const error4 = Error({ event_id: 'err4' });
159-
160-
const handler = handleAfterSendEvent(replay);
161-
162-
// With undefined response: Capture
163-
handler(error1, undefined);
164-
// With "successful" response: Capture
165-
handler(error2, { statusCode: 200 });
166-
// With "unsuccessful" response: Capture
167-
handler(error3, { statusCode: 0 });
168-
// With no statusCode response: Capture
169-
handler(error4, { statusCode: undefined });
170-
171-
expect(Array.from(replay.getContext().errorIds)).toEqual(['err1', 'err2', 'err3', 'err4']);
172-
});
173-
174144
it('flushes when in buffer mode', async () => {
175145
({ replay } = await resetSdkMock({
176146
replayOptions: {
@@ -298,7 +268,7 @@ describe('Integration | coreHandlers | handleAfterSendEvent', () => {
298268

299269
expect(replay.recordingMode).toBe('buffer');
300270

301-
handler(error1, undefined);
271+
handler(error1, {});
302272

303273
expect(Array.from(replay.getContext().errorIds)).toEqual([]);
304274

packages/vercel-edge/test/wintercg-fetch.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ describe('WinterCGFetch instrumentation', () => {
2929
tracesSampleRate: 1,
3030
integrations: [],
3131
transport: () => ({
32-
send: () => Promise.resolve(undefined),
32+
send: () => Promise.resolve({}),
3333
flush: () => Promise.resolve(true),
3434
}),
3535
tracePropagationTargets: ['http://my-website.com/'],

0 commit comments

Comments
 (0)