fix(build): Strip eslint-enable comments in rollup plugin (#5112)

lobsterkatie · AbhiPrasad · commit 4d5f40fb5cc6 · 2022-05-30T14:08:48.000+02:00
The `removeESLintCommentsPlugin` rollup plugin we use during build strips all comments beginning `eslint-disable`, but misses comments beginning `eslint-enable`. This makes the regex used in that plugin more general, so that it catches all comments beginning with `eslint-`.
diff --git a/rollup/plugins/npmPlugins.js b/rollup/plugins/npmPlugins.js
@@ -104,7 +104,7 @@ export function makeRemoveESLintCommentsPlugin() {
   return regexReplace({
     patterns: [
       {
-        test: /\/[/*] eslint-disable.*\n/g,
+        test: /\/[/*] eslint-.*\n/g,
         replace: '',
       },
     ],

Original file line number	Diff line number	Diff line change
`@@ -104,7 +104,7 @@ export function makeRemoveESLintCommentsPlugin() {`
`104`	`104`	`return regexReplace({`
`105`	`105`	`patterns: [`
`106`	`106`	`{`
`107`		`- test: /\/[/] eslint-disable.\n/g,`
	`107`	`+ test: /\/[/] eslint-.\n/g,`
`108`	`108`	`replace: '',`
`109`	`109`	`},`
`110`	`110`	`],`