Skip to content

Commit 51b3dd1

Browse files
committed
build(profiling-node): Ensure we fail on cache miss & cleanup
1 parent 09f2a69 commit 51b3dd1

File tree

1 file changed

+6
-11
lines changed

1 file changed

+6
-11
lines changed

.github/workflows/build.yml

Lines changed: 6 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -410,7 +410,8 @@ jobs:
410410
uses: actions/cache/restore@v4
411411
with:
412412
key: ${{ env.BUILD_PROFILING_NODE_CACHE_TARBALL_KEY }}
413-
path: ${{ github.workspace }}/packages/*/*.tgz
413+
path: ${{ github.workspace }}/packages/profiling-node/*.tgz
414+
fail-on-cache-miss: true
414415

415416
- name: Archive artifacts
416417
uses: actions/upload-artifact@v4
@@ -1014,7 +1015,7 @@ jobs:
10141015
- name: Stores tarballs in cache
10151016
uses: actions/cache/save@v4
10161017
with:
1017-
path: ${{ github.workspace }}/packages/*/*.tgz
1018+
path: ${{ github.workspace }}/packages/profiling-node/*.tgz
10181019
key: ${{ env.BUILD_PROFILING_NODE_CACHE_TARBALL_KEY }}
10191020

10201021
job_e2e_tests:
@@ -1107,12 +1108,6 @@ jobs:
11071108
env:
11081109
DEPENDENCY_CACHE_KEY: ${{ needs.job_build.outputs.dependency_cache_key }}
11091110

1110-
- name: Restore tarball cache
1111-
uses: actions/cache/restore@v4
1112-
with:
1113-
path: ${{ github.workspace }}/packages/*/*.tgz
1114-
key: ${{ env.BUILD_PROFILING_NODE_CACHE_TARBALL_KEY }}
1115-
11161111
- name: Get node version
11171112
id: versions
11181113
run: |
@@ -1202,13 +1197,13 @@ jobs:
12021197
with:
12031198
name: profiling-node-binaries-${{ github.sha }}
12041199
path: ${{ github.workspace }}/packages/profiling-node/lib/
1205-
- name: Build Profiling tarball
1206-
run: yarn build:tarball --scope @sentry/profiling-node
1200+
12071201
- name: Restore tarball cache
12081202
uses: actions/cache/restore@v4
12091203
with:
1210-
path: ${{ github.workspace }}/packages/*/*.tgz
1204+
path: ${{ github.workspace }}/packages/profiling-node/*.tgz
12111205
key: ${{ env.BUILD_PROFILING_NODE_CACHE_TARBALL_KEY }}
1206+
fail-on-cache-miss : true
12121207

12131208
- name: Get node version
12141209
id: versions

0 commit comments

Comments
 (0)