Skip to content

Commit 5245b4f

Browse files
committed
Revert "chore: use fastify types"
This reverts commit ebcf709.
1 parent ebcf709 commit 5245b4f

File tree

7 files changed

+25
-326
lines changed

7 files changed

+25
-326
lines changed

packages/remix/package.json

+1-3
Original file line numberDiff line numberDiff line change
@@ -70,9 +70,7 @@
7070
"devDependencies": {
7171
"@remix-run/node": "^1.4.3",
7272
"@remix-run/react": "^1.4.3",
73-
"@types/express": "^4.17.14",
74-
"fastify": "^4.26.2",
75-
"typescript": "^5.4.4"
73+
"@types/express": "^4.17.14"
7674
},
7775
"peerDependencies": {
7876
"@remix-run/node": "1.x || 2.x",
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
1-
import { type ExpressCreateHandlerWrapper } from '../vendor/types';
21
import { SupportedFramework, prepareWrapCreateRequestHandler } from './shared';
32

43
/**
54
* Instruments `createRequestHandler` from `@remix-run/express`
65
*/
7-
export const wrapExpressCreateRequestHandler = prepareWrapCreateRequestHandler(SupportedFramework.Express) as ExpressCreateHandlerWrapper;
6+
export const wrapExpressCreateRequestHandler = prepareWrapCreateRequestHandler(SupportedFramework.Express);
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
1-
import { type FastifyCreateHandlerWrapper } from '../vendor/types';
21
import { SupportedFramework, prepareWrapCreateRequestHandler } from './shared';
32

43
/**
54
* Instruments `createRequestHandler` from `@mcansh/remix-fastify`
65
*/
7-
export const wrapFastifyCreateRequestHandler = prepareWrapCreateRequestHandler(SupportedFramework.Fastify) as FastifyCreateHandlerWrapper;
6+
export const wrapFastifyCreateRequestHandler = prepareWrapCreateRequestHandler(SupportedFramework.Fastify);

packages/remix/src/utils/vendor/types.ts

+1-4
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,6 @@ import type { PolymorphicRequest } from '@sentry/types';
1515
import type * as Express from 'express';
1616
import type { ComponentType } from 'react';
1717

18-
import type * as Fastify from 'fastify'
19-
2018
type Dev = {
2119
command?: string;
2220
scheme?: string;
@@ -240,9 +238,8 @@ export interface AssetsManifest {
240238
}
241239

242240
export type GenericRequestHandler = (req: any, res: any, next: any) => Promise<void>;
241+
243242
export type CreateGenericRequestHandler = (this: unknown, options: any) => GenericRequestHandler;
244-
export type ExpressCreateHandlerWrapper = (createHandler: CreateGenericRequestHandler) => (opts: CreateRequestHandlerOptions) => Express.RequestHandler
245-
export type FastifyCreateHandlerWrapper = (createHandler: CreateGenericRequestHandler) => (opts: CreateRequestHandlerOptions) => Fastify.RouteHandlerMethod;
246243

247244
export interface CreateRequestHandlerOptions {
248245
build: ServerBuild | (() => ServerBuild) | (() => Promise<ServerBuild>);

packages/remix/test/integration/test/server/utils/helpers.ts

+4-4
Original file line numberDiff line numberDiff line change
@@ -31,11 +31,11 @@ const runExpressApp = (adapter: Adapter.Builtin | Adapter.Express): Promise<http
3131
}
3232
)
3333

34-
const runFastifyApp = (): Promise<http.Server> => new Promise(async res => {
34+
const runFastifyApp = (): Promise<http.Server> => new Promise(res => {
3535
const app = fastify();
36-
await app.register(formBody);
37-
const handler = adapters[Adapter.Fastify]({ build: require('../../../build') });
38-
app.all('*', handler);
36+
app.register(formBody);
37+
// @ts-ignore
38+
app.all('*', adapters[Adapter.Fastify]({ build: require('../../../build') }));
3939
app.listen({port: 0}, (_err, _addr) => {
4040
res(app.server)
4141
});

packages/remix/tsconfig.json

+1-2
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55

66
"compilerOptions": {
77
"jsx": "react",
8-
"module": "es2020",
9-
"ignoreDeprecations": "5.0"
8+
"module": "es2020"
109
}
1110
}

0 commit comments

Comments
 (0)