Skip to content

Commit 53b5dc0

Browse files
committed
fix e2e tests
1 parent 1a2bf07 commit 53b5dc0

File tree

2 files changed

+8
-6
lines changed

2 files changed

+8
-6
lines changed

dev-packages/e2e-tests/test-applications/sveltekit-2/test/performance.server.test.ts

+4-3
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ import { waitForTransaction } from '../event-proxy-server';
33

44
test('server pageload request span has nested request span for sub request', async ({ page }) => {
55
const serverTxnEventPromise = waitForTransaction('sveltekit', txnEvent => {
6-
console.log('txnEvent', txnEvent);
76
return txnEvent?.transaction === 'GET /server-load-fetch';
87
});
98

@@ -25,10 +24,12 @@ test('server pageload request span has nested request span for sub request', asy
2524
},
2625
});
2726

28-
expect(spans).toHaveLength(3);
27+
expect(spans).toHaveLength(2);
2928

3029
expect(spans).toEqual(expect.arrayContaining([
31-
expect.objectContaining({ op: 'http.server', description: 'GET /server-load-fetch' }),
30+
// load span where the server load function initiates the sub request:
31+
expect.objectContaining({ op: 'function.sveltekit.server.load', description: '/server-load-fetch' }),
32+
// sub request span:
3233
expect.objectContaining({ op: 'http.server', description: 'GET /api/users' }),
3334
]))
3435
});

dev-packages/e2e-tests/test-applications/sveltekit/test/performance.server.test.ts

+4-3
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ import { waitForTransaction } from '../event-proxy-server';
33

44
test('server pageload request span has nested request span for sub request', async ({ page }) => {
55
const serverTxnEventPromise = waitForTransaction('sveltekit', txnEvent => {
6-
console.log('txnEvent', txnEvent);
76
return txnEvent?.transaction === 'GET /server-load-fetch';
87
});
98

@@ -25,10 +24,12 @@ test('server pageload request span has nested request span for sub request', asy
2524
},
2625
});
2726

28-
expect(spans).toHaveLength(3);
27+
expect(spans).toHaveLength(2);
2928

3029
expect(spans).toEqual(expect.arrayContaining([
31-
expect.objectContaining({ op: 'http.server', description: 'GET /server-load-fetch' }),
30+
// load span where the server load function initiates the sub request:
31+
expect.objectContaining({ op: 'function.sveltekit.server.load', description: '/server-load-fetch' }),
32+
// sub request span:
3233
expect.objectContaining({ op: 'http.server', description: 'GET /api/users' }),
3334
]))
3435
});

0 commit comments

Comments
 (0)