Skip to content

Commit 542ff1d

Browse files
AbhiPrasadonurtemizkan
authored andcommitted
fix(ember): Use ui category for span operations (#4221)
As per the new spec in https://develop.sentry.dev/sdk/performance/span-operations/#js-frameworks, we now want to prefix our ember spans operations with `ui`.
1 parent 5078ea0 commit 542ff1d

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

packages/ember/addon/instance-initializers/sentry-performance.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ export function _instrumentEmberRouter(
109109
},
110110
});
111111
transitionSpan = activeTransaction.startChild({
112-
op: 'ember.transition',
112+
op: 'ui.ember.transition',
113113
description: `route:${fromRoute} -> route:${toRoute}`,
114114
});
115115
});
@@ -173,7 +173,7 @@ function _instrumentEmberRunloop(config: EmberSentryConfig) {
173173
if ((now - currentQueueStart) * 1000 >= minQueueDuration) {
174174
activeTransaction
175175
?.startChild({
176-
op: `ember.runloop.${queue}`,
176+
op: `ui.ember.runloop.${queue}`,
177177
startTimestamp: currentQueueStart,
178178
endTimestamp: now,
179179
})
@@ -273,7 +273,7 @@ function _instrumentComponents(config: EmberSentryConfig) {
273273
},
274274

275275
after(_name: string, _timestamp: number, payload: any, _beganIndex: number) {
276-
processComponentRenderAfter(payload, beforeEntries, 'ember.component.render', minComponentDuration);
276+
processComponentRenderAfter(payload, beforeEntries, 'ui.ember.component.render', minComponentDuration);
277277
},
278278
});
279279
if (enableComponentDefinitions) {
@@ -283,7 +283,7 @@ function _instrumentComponents(config: EmberSentryConfig) {
283283
},
284284

285285
after(_name: string, _timestamp: number, payload: any, _beganIndex: number) {
286-
processComponentRenderAfter(payload, beforeComponentDefinitionEntries, 'ember.component.definition', 0);
286+
processComponentRenderAfter(payload, beforeComponentDefinitionEntries, 'ui.ember.component.definition', 0);
287287
},
288288
});
289289
}
@@ -331,7 +331,7 @@ function _instrumentInitialLoad(config: EmberSentryConfig) {
331331

332332
const transaction = getActiveTransaction();
333333
const span = transaction?.startChild({
334-
op: 'ember.initial-load',
334+
op: 'ui.ember.init',
335335
startTimestamp,
336336
});
337337
span?.finish(endTimestamp);

0 commit comments

Comments
 (0)