Skip to content

Commit 56fe6e5

Browse files
committed
skip tests correctly
1 parent 4604fc3 commit 56fe6e5

File tree

3 files changed

+6
-6
lines changed
  • dev-packages/browser-integration-tests/suites/tracing/trace-lifetime

3 files changed

+6
-6
lines changed

dev-packages/browser-integration-tests/suites/tracing/trace-lifetime/navigation/test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import { expect } from '@playwright/test';
22
import type { Event, SpanEnvelope } from '@sentry/types';
33
import { sentryTest } from '../../../../utils/fixtures';
4-
import type { EventAndTraceHeader } from '../../../../utils/helpers';
4+
import { EventAndTraceHeader, shouldSkipFeedbackTest } from '../../../../utils/helpers';
55
import {
66
eventAndTraceHeaderRequestParser,
77
getFirstSentryEnvelopeRequest,
@@ -460,7 +460,7 @@ sentryTest(
460460
sentryTest(
461461
'user feedback event after navigation has navigation traceId in headers',
462462
async ({ getLocalTestPath, page }) => {
463-
if (shouldSkipTracingTest()) {
463+
if (shouldSkipTracingTest() || shouldSkipFeedbackTest()) {
464464
sentryTest.skip();
465465
}
466466

dev-packages/browser-integration-tests/suites/tracing/trace-lifetime/pageload-meta/test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import { expect } from '@playwright/test';
22
import type { Event, SpanEnvelope } from '@sentry/types';
33
import { sentryTest } from '../../../../utils/fixtures';
4-
import type { EventAndTraceHeader } from '../../../../utils/helpers';
4+
import { EventAndTraceHeader, shouldSkipFeedbackTest } from '../../../../utils/helpers';
55
import {
66
eventAndTraceHeaderRequestParser,
77
getFirstSentryEnvelopeRequest,
@@ -431,7 +431,7 @@ sentryTest(
431431
);
432432

433433
sentryTest('user feedback event after pageload has pageload traceId in headers', async ({ getLocalTestPath, page }) => {
434-
if (shouldSkipTracingTest()) {
434+
if (shouldSkipTracingTest() || shouldSkipFeedbackTest()) {
435435
sentryTest.skip();
436436
}
437437

dev-packages/browser-integration-tests/suites/tracing/trace-lifetime/pageload/test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import { expect } from '@playwright/test';
22
import type { Event, SpanEnvelope } from '@sentry/types';
33
import { sentryTest } from '../../../../utils/fixtures';
4-
import type { EventAndTraceHeader } from '../../../../utils/helpers';
4+
import { EventAndTraceHeader, shouldSkipFeedbackTest } from '../../../../utils/helpers';
55
import {
66
eventAndTraceHeaderRequestParser,
77
getFirstSentryEnvelopeRequest,
@@ -433,7 +433,7 @@ sentryTest(
433433
);
434434

435435
sentryTest('user feedback event after pageload has pageload traceId in headers', async ({ getLocalTestPath, page }) => {
436-
if (shouldSkipTracingTest()) {
436+
if (shouldSkipTracingTest() || shouldSkipFeedbackTest()) {
437437
sentryTest.skip();
438438
}
439439

0 commit comments

Comments
 (0)