Merge branch 'cl/screenshot-integration' into ryan953/feedback-async

Author: ryan953

.craft.yml

@@ -136,6 +136,9 @@ targets:
     includeNames: /^sentry-internal-eslint-config-sdk-\d.*\.tgz$/
 
   ## 8. Deprecated packages we still release (but no packages depend on them anymore)
+  - name: npm
+    id: '@sentry/hub'
+    includeNames: /^sentry-hub-\d.*\.tgz$/
   - name: npm
     id: '@sentry/tracing'
     includeNames: /^sentry-tracing-\d.*\.tgz$/

.eslintrc.js

@@ -22,6 +22,7 @@ module.exports = {
     'test/manual/**',
     'types/**',
   ],
+  reportUnusedDisableDirectives: true,
   overrides: [
     {
       files: ['*.ts', '*.tsx', '*.d.ts'],

.github/CANARY_FAILURE_TEMPLATE.md

@@ -1,5 +1,5 @@
 ---
 title: '{{ env.TITLE }}'
-labels: 'Type: Tests'
+labels: 'Type: Tests, Waiting for: Product Owner'
 ---
 Canary tests failed: {{ env.RUN_LINK }}

.github/workflows/build.yml

@@ -517,7 +517,6 @@ jobs:
 
   job_node_unit_tests:
     name: Node (${{ matrix.node }}) Unit Tests
-    if: needs.job_get_metadata.outputs.changed_node == 'true' || github.event_name != 'pull_request'
     needs: [job_get_metadata, job_build]
     timeout-minutes: 10
     runs-on: ubuntu-20.04
@@ -901,6 +900,7 @@ jobs:
       - name: Run integration tests
         env:
           NODE_VERSION: ${{ matrix.node }}
+          TS_VERSION: ${{ matrix.typescript }}
         run: |
           cd dev-packages/node-integration-tests
           yarn test
@@ -1044,9 +1044,8 @@ jobs:
             'node-express-app',
             'create-react-app',
             'create-next-app',
-            # disabling remix e2e tests because of flakes
-            # 'create-remix-app',
-            # 'create-remix-app-v2',
+            'create-remix-app',
+            'create-remix-app-v2',
             'debug-id-sourcemaps',
             'nextjs-app-dir',
             'nextjs-14',
@@ -1058,7 +1057,8 @@ jobs:
             'sveltekit-2',
             'generic-ts3.8',
             'node-experimental-fastify-app',
-            'node-hapi-app',
+            # TODO(v8): Re-enable hapi tests
+            # 'node-hapi-app',
             'node-exports-test-app',
             'vue-3'
           ]

.github/workflows/flaky-test-detector.yml

@@ -76,7 +76,7 @@ jobs:
         with:
           list-files: json
           filters: |
-            browser_integration: dev-packages/browser-integration-tests/suites/**
+            browser_integration: dev-packages/browser-integration-tests/suites/**/test.ts
 
       - name: Detect flaky tests
         run: yarn test:detect-flaky

CHANGELOG.md

@@ -4,6 +4,25 @@
 
 - "You miss 100 percent of the chances you don't take. — Wayne Gretzky" — Michael Scott
 
+## 7.101.0
+
+- feat: Export semantic attribute keys from SDK packages (#10637)
+- feat(core): Add metric summaries to spans (#10554)
+- feat(core): Deprecate the `Hub` constructor (#10584)
+- feat(core): Make custom tracing methods return spans & set default op (#10633)
+- feat(replay): Add `getReplay` utility function (#10510)
+- fix(angular-ivy): Add `exports` field to `package.json` (#10569)
+- fix(sveltekit): Avoid capturing Http 4xx errors on the client (#10571)
+- fix(sveltekit): Properly await sourcemaps flattening (#10602)
+
+## 7.100.1
+
+This release contains build fixes for profiling-node.
+
+- build(profiling-node): make sure debug build plugin is used #10534
+- build: Only run profiling e2e test if bindings have changed #10542
+- fix(feedback): Replay breadcrumb for feedback events was incorrect #10536
+
 ## 7.100.0
 
 ### Important Changes

CODEOWNERS

@@ -1,3 +1,5 @@
-packages/replay                                   @getsentry/replay-sdk
-packages/replay-worker                            @getsentry/replay-sdk
-dev-packages/browser-integration-tests/suites/replay  @getsentry/replay-sdk
+packages/replay                                   @getsentry/replay-sdk-web
+packages/replay-worker                            @getsentry/replay-sdk-web
+packages/replay-canvas                            @getsentry/replay-sdk-web
+packages/feedback                                 @getsentry/replay-sdk-web
+dev-packages/browser-integration-tests/suites/replay  @getsentry/replay-sdk-web

MIGRATION.md

@@ -1,5 +1,48 @@
 # Upgrading from 7.x to 8.x
 
+## Removal of the `MetricsAggregator` integration class and `metricsAggregatorIntegration`
+
+The SDKs now support metrics features without any additional configuration.
+
+## Updated behaviour of `tracePropagationTargets` in the browser (HTTP tracing headers & CORS)
+
+We updated the behaviour of the SDKs when no `tracePropagationTargets` option was defined. As a reminder, you can
+provide a list of strings or RegExes that will be matched against URLs to tell the SDK, to which outgoing requests
+tracing HTTP headers should be attached to. These tracing headers are used for distributed tracing.
+
+Previously, on the browser, when `tracePropagationTargets` were not defined, they defaulted to the following:
+`['localhost', /^\/(?!\/)/]`. This meant that all request targets to that had "localhost" in the URL, or started with a
+`/` were equipped with tracing headers. This default was chosen to prevent CORS errors in your browser applications.
+However, this default had a few flaws.
+
+Going forward, when the `tracePropagationTargets` option is not set, tracing headers will be attached to all outgoing
+requests on the same origin. For example, if you're on `https://example.com/` and you send a request to
+`https://example.com/api`, the request will be traced (ie. will have trace headers attached). Requests to
+`https://api.example.com/` will not, because it is on a different origin. The same goes for all applications running on
+`localhost`.
+
+When you provide a `tracePropagationTargets` option, all of the entries you defined will now be matched be matched
+against the full URL of the outgoing request. Previously, it was only matched against what you called request APIs with.
+For example, if you made a request like `fetch("/api/posts")`, the provided `tracePropagationTargets` were only compared
+against `"/api/posts"`. Going forward they will be matched against the entire URL, for example, if you were on the page
+`https://example.com/` and you made the same request, it would be matched against `"https://example.com/api/posts"`.
+
+But that is not all. Because it would be annoying having to create matchers for the entire URL, if the request is a
+same-origin request, we also match the `tracePropagationTargets` against the resolved `pathname` of the request.
+Meaning, a matcher like `/^\/api/` would match a request call like `fetch('/api/posts')`, or
+`fetch('https://same-origin.com/api/posts')` but not `fetch('https://different-origin.com/api/posts')`.
+
+## Removal of the `tracingOrigins` option
+
+After its deprecation in v7 the `tracingOrigins` option is now removed in favor of the `tracePropagationTargets` option.
+The `tracePropagationTargets` option should be set in the `Sentry.init()` options, or in your custom `Client`s option if
+you create them. The `tracePropagationTargets` option can no longer be set in the `browserTracingIntegration()` options.
+
+## Dropping Support for React 15
+
+Sentry will no longer officially support React 15 in version 8. This means that React 15.x will be removed
+from`@sentry/react`'s peer dependencies.
+
 ## Removal of deprecated API in `@sentry/nextjs`
 
 The following previously deprecated API has been removed from the `@sentry/nextjs` package:
@@ -16,6 +59,11 @@ The following previously deprecated API has been removed from the `@sentry/nextj
 - `IS_BUILD`
 - `isBuild`
 
+## Removal of `Span` class export from SDK packages
+
+In v8, we are no longer exporting the `Span` class from SDK packages (e.g. `@sentry/browser` or `@sentry/node`).
+Internally, this class is now called `SentrySpan`, and it is no longer meant to be used by users directly.
+
 ## Removal of Severity Enum
 
 In v7 we deprecated the `Severity` enum in favor of using the `SeverityLevel` type. In v8 we removed the `Severity`
@@ -27,9 +75,36 @@ enum. If you were using the `Severity` enum, you should replace it with the `Sev
 The `Offline` integration has been removed in favor of the offline transport wrapper:
 http://docs.sentry.io/platforms/javascript/configuration/transports/#offline-caching
 
-## Other changes
+## Removal of `enableAnrDetection` and `Anr` class (##10562)
+
+The `enableAnrDetection` and `Anr` class have been removed. See the
+[docs](https://docs.sentry.io/platforms/node/configuration/application-not-responding/) for more details how to migrate
+to `anrIntegration`, the new integration for ANR detection.
+
+## Removal of `Sentry.configureScope` (#10565)
+
+The top level `Sentry.configureScope` function has been removed. Instead, you should use the `Sentry.getCurrentScope()`
+to access and mutate the current scope.
+
+## Deletion of `@sentry/hub` package (#10530)
+
+`@sentry/hub` has been removed. All exports from `@sentry.hub` should be available in `@sentry/core`.
+
+## Removal of `makeXHRTransport` transport (#10703)
+
+The `makeXHRTransport` transport has been removed. Only `makeFetchTransport` is available now. This means that the
+Sentry SDK requires the fetch API to be available in the environment.
+
+## General API Changes
 
+- The minumum supported Node version for all the SDK packages is Node 14 (#10527)
 - Remove `spanStatusfromHttpCode` in favour of `getSpanStatusFromHttpCode` (#10361)
+- Remove deprecated `deepReadDirSync` export from `@sentry/node` (#10564)
+- Remove `_eventFromIncompleteOnError` usage (#10553)
+- The `Transaction` integration in `@sentry/integrations` has been removed. There is no replacement API. (#10556)
+- `extraErrorDataIntegration` now looks at
+  [`error.cause`](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Error/cause) by
+  default.
 
 # Deprecations in 7.x
 

dev-packages/browser-integration-tests/loader-suites/loader/onLoad/customBrowserTracing/init.js

@@ -4,9 +4,8 @@ Sentry.onLoad(function () {
   Sentry.init({
     integrations: [
       // Without this syntax, this will be re-written by the test framework
-      new window['Sentry'].BrowserTracing({
-        tracePropagationTargets: ['http://localhost:1234'],
-      }),
+      window['Sentry'].browserTracingIntegration(),
     ],
+    tracePropagationTargets: ['http://localhost:1234'],
   });
 });

dev-packages/browser-integration-tests/loader-suites/loader/onLoad/customBrowserTracing/test.ts

@@ -25,11 +25,4 @@ sentryTest('should handle custom added BrowserTracing integration', async ({ get
   expect(eventData.contexts?.trace?.op).toBe('pageload');
   expect(eventData.spans?.length).toBeGreaterThan(0);
   expect(eventData.transaction_info?.source).toEqual('url');
-
-  const tracePropagationTargets = await page.evaluate(() => {
-    const browserTracing = (window as any).Sentry.getClient().getIntegrationByName('BrowserTracing');
-    return browserTracing.options.tracePropagationTargets;
-  });
-
-  expect(tracePropagationTargets).toEqual(['http://localhost:1234']);
 });

dev-packages/browser-integration-tests/package.json

@@ -49,7 +49,7 @@
     "@sentry-internal/rrweb": "2.11.0",
     "@sentry/browser": "7.100.0",
     "@sentry/tracing": "7.100.0",
-    "axios": "1.6.0",
+    "axios": "1.6.7",
     "babel-loader": "^8.2.2",
     "html-webpack-plugin": "^5.5.0",
     "pako": "^2.1.0",

dev-packages/browser-integration-tests/suites/feedback/captureFeedback/test.ts

@@ -44,6 +44,7 @@ sentryTest('should capture feedback (@sentry-internal/feedback import)', async (
   const feedbackEvent = envelopeRequestParser((await feedbackRequestPromise).request());
   expect(feedbackEvent).toEqual({
     type: 'feedback',
+    breadcrumbs: expect.any(Array),
     contexts: {
       feedback: {
         contact_email: '[email protected]',

dev-packages/browser-integration-tests/suites/feedback/captureFeedbackAndReplay/test.ts

@@ -50,15 +50,16 @@ sentryTest('should capture feedback (@sentry-internal/feedback import)', async (
 
   expect(breadcrumbs).toEqual(
     expect.arrayContaining([
-      {
+      expect.objectContaining({
         category: 'sentry.feedback',
         data: { feedbackId: expect.any(String) },
-      },
+      }),
     ]),
   );
 
   expect(feedbackEvent).toEqual({
     type: 'feedback',
+    breadcrumbs: expect.any(Array),
     contexts: {
       feedback: {
         contact_email: '[email protected]',

dev-packages/browser-integration-tests/suites/integrations/Breadcrumbs/dom/click/test.ts

@@ -78,9 +78,8 @@ sentryTest(
 
     await page.goto(url);
     await page.locator('#annotated-button').click();
-    await page.evaluate('Sentry.captureException("test exception")');
 
-    const eventData = await promise;
+    const [eventData] = await Promise.all([promise, page.evaluate('Sentry.captureException("test exception")')]);
 
     expect(eventData.breadcrumbs).toEqual([
       {

dev-packages/browser-integration-tests/suites/integrations/ContextLines/init.js

@@ -1,9 +1,9 @@
 import * as Sentry from '@sentry/browser';
-import { ContextLines } from '@sentry/integrations';
+import { contextLinesIntegration } from '@sentry/integrations';
 
 window.Sentry = Sentry;
 
 Sentry.init({
   dsn: 'https://[email protected]/1337',
-  integrations: [new ContextLines()],
+  integrations: [contextLinesIntegration()],
 });

dev-packages/browser-integration-tests/suites/integrations/httpclient/fetch/init.js

@@ -1,11 +1,11 @@
 import * as Sentry from '@sentry/browser';
-import { HttpClient } from '@sentry/integrations';
+import { httpClientIntegration } from '@sentry/integrations';
 
 window.Sentry = Sentry;
 
 Sentry.init({
   dsn: 'https://[email protected]/1337',
-  integrations: [new HttpClient()],
+  integrations: [httpClientIntegration()],
   tracesSampleRate: 1,
   sendDefaultPii: true,
 });

dev-packages/browser-integration-tests/suites/integrations/httpclient/fetch/simple/test.ts

@@ -4,6 +4,8 @@ import type { Event } from '@sentry/types';
 import { sentryTest } from '../../../../../utils/fixtures';
 import { getFirstSentryEnvelopeRequest } from '../../../../../utils/helpers';
 
+// This test rarely flakes with timeouts. The reason might be:
+// https://github.com/microsoft/playwright/issues/10376
 sentryTest(
   'should assign request and response context from a failed 500 fetch request',
   async ({ getLocalTestPath, page }) => {

dev-packages/browser-integration-tests/suites/integrations/httpclient/init.js

@@ -1,11 +1,11 @@
 import * as Sentry from '@sentry/browser';
-import { HttpClient } from '@sentry/integrations';
+import { httpClientIntegration } from '@sentry/integrations';
 
 window.Sentry = Sentry;
 
 Sentry.init({
   dsn: 'https://[email protected]/1337',
-  integrations: [new HttpClient()],
+  integrations: [httpClientIntegration()],
   tracesSampleRate: 1,
   sendDefaultPii: true,
 });

dev-packages/browser-integration-tests/suites/metrics/init.js

@@ -0,0 +1,16 @@
+import * as Sentry from '@sentry/browser';
+
+window.Sentry = Sentry;
+
+Sentry.init({
+  dsn: 'https://[email protected]/1337',
+});
+
+Sentry.metrics.increment('increment');
+Sentry.metrics.increment('increment');
+Sentry.metrics.distribution('distribution', 42);
+Sentry.metrics.distribution('distribution', 45);
+Sentry.metrics.gauge('gauge', 5);
+Sentry.metrics.gauge('gauge', 15);
+Sentry.metrics.set('set', 'nope');
+Sentry.metrics.set('set', 'another');

dev-packages/browser-integration-tests/suites/metrics/test.ts

@@ -0,0 +1,17 @@
+import { expect } from '@playwright/test';
+
+import { sentryTest } from '../../utils/fixtures';
+import { getFirstSentryEnvelopeRequest, properEnvelopeRequestParser } from '../../utils/helpers';
+
+sentryTest('collects metrics', async ({ getLocalTestUrl, page }) => {
+  const url = await getLocalTestUrl({ testDir: __dirname });
+
+  const statsdBuffer = await getFirstSentryEnvelopeRequest<Uint8Array>(page, url, properEnvelopeRequestParser);
+  const statsdString = new TextDecoder().decode(statsdBuffer);
+  // Replace all the Txxxxxx to remove the timestamps
+  const normalisedStatsdString = statsdString.replace(/T\d+\n?/g, 'T000000');
+
+  expect(normalisedStatsdString).toEqual(
+    'increment@none:2|c|T000000distribution@none:42:45|d|T000000gauge@none:15:5:15:20:2|g|T000000set@none:3387254:3443787523|s|T000000',
+  );
+});