Skip to content

Commit 5b8503d

Browse files
committed
Remove dedicated otel-v2 job in build.yml and rely on node unit tests instead
1 parent be37d67 commit 5b8503d

File tree

2 files changed

+3
-43
lines changed

2 files changed

+3
-43
lines changed

.github/workflows/build.yml

Lines changed: 0 additions & 40 deletions
Original file line numberDiff line numberDiff line change
@@ -196,9 +196,6 @@ jobs:
196196
changed_node_integration:
197197
${{ needs.job_get_metadata.outputs.changed_ci == 'true' || contains(steps.checkForAffected.outputs.affected,
198198
'@sentry-internal/node-integration-tests') }}
199-
changed_opentelemetry:
200-
${{ needs.job_get_metadata.outputs.changed_ci == 'true' || contains(steps.checkForAffected.outputs.affected,
201-
'@sentry/opentelemetry') }}
202199
changed_remix:
203200
${{ needs.job_get_metadata.outputs.changed_ci == 'true' || contains(steps.checkForAffected.outputs.affected,
204201
'@sentry/remix') }}
@@ -754,42 +751,6 @@ jobs:
754751
directory: dev-packages/node-integration-tests
755752
token: ${{ secrets.CODECOV_TOKEN }}
756753

757-
job_opentelemetry_v2_tests:
758-
name: '@sentry/opentelemetry with OpenTelemetry v2 (Node ${{ matrix.node }}) Tests'
759-
needs: [job_get_metadata, job_build]
760-
if: needs.job_build.outputs.changed_opentelemetry == 'true' || github.event_name != 'pull_request'
761-
runs-on: ubuntu-24.04
762-
timeout-minutes: 10
763-
strategy:
764-
fail-fast: false
765-
matrix:
766-
node: [18, 20, 22]
767-
steps:
768-
- name: Check out current commit (${{ needs.job_get_metadata.outputs.commit_label }})
769-
uses: actions/checkout@v4
770-
with:
771-
ref: ${{ env.HEAD_COMMIT }}
772-
- name: Set up Node
773-
uses: actions/setup-node@v4
774-
with:
775-
node-version: ${{ matrix.node }}
776-
- name: Restore caches
777-
uses: ./.github/actions/restore-cache
778-
with:
779-
dependency_cache_key: ${{ needs.job_build.outputs.dependency_cache_key }}
780-
781-
- name: Run unit tests
782-
working-directory: dev-packages/opentelemetry-v2-tests
783-
run: yarn test
784-
785-
- name: Upload test results to Codecov
786-
if: cancelled() == false
787-
continue-on-error: true
788-
uses: codecov/test-results-action@v1
789-
with:
790-
directory: dev-packages/opentelemetry-v2-tests
791-
token: ${{ secrets.CODECOV_TOKEN }}
792-
793754
job_remix_integration_tests:
794755
name: Remix (Node ${{ matrix.node }}) Tests
795756
needs: [job_get_metadata, job_build]
@@ -1133,7 +1094,6 @@ jobs:
11331094
job_node_integration_tests,
11341095
job_browser_playwright_tests,
11351096
job_browser_loader_tests,
1136-
job_opentelemetry_v2_tests,
11371097
job_remix_integration_tests,
11381098
job_e2e_tests,
11391099
job_artifacts,

package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,10 +32,10 @@
3232
"dedupe-deps:check": "yarn-deduplicate yarn.lock --list --fail",
3333
"dedupe-deps:fix": "yarn-deduplicate yarn.lock",
3434
"postpublish": "lerna run --stream --concurrency 1 postpublish",
35-
"test": "lerna run --ignore \"@sentry-internal/{browser-integration-tests,e2e-tests,integration-shims,node-integration-tests,opentelemetry-v2-tests}\" test",
36-
"test:unit": "lerna run --ignore \"@sentry-internal/{browser-integration-tests,e2e-tests,integration-shims,node-integration-tests,opentelemetry-v2-tests}\" test:unit",
35+
"test": "lerna run --ignore \"@sentry-internal/{browser-integration-tests,e2e-tests,integration-shims,node-integration-tests}\" test",
36+
"test:unit": "lerna run --ignore \"@sentry-internal/{browser-integration-tests,e2e-tests,integration-shims,node-integration-tests}\" test:unit",
3737
"test:update-snapshots": "lerna run test:update-snapshots",
38-
"test:pr": "nx affected -t test --exclude \"@sentry-internal/{browser-integration-tests,e2e-tests,integration-shims,node-integration-tests,opentelemetry-v2-tests}\"",
38+
"test:pr": "nx affected -t test --exclude \"@sentry-internal/{browser-integration-tests,e2e-tests,integration-shims,node-integration-tests}\"",
3939
"test:pr:browser": "UNIT_TEST_ENV=browser ts-node ./scripts/ci-unit-tests.ts --affected",
4040
"test:pr:node": "UNIT_TEST_ENV=node ts-node ./scripts/ci-unit-tests.ts --affected",
4141
"test:ci:browser": "UNIT_TEST_ENV=browser ts-node ./scripts/ci-unit-tests.ts",

0 commit comments

Comments
 (0)