Skip to content

Commit 5d3fcc4

Browse files
committed
fix(dev): Check out correct commit in manual GHA Build & Test workflow (#4954)
Our `Build & Test` GHA workflow can be triggered manually, and when you trigger it, you can either pick the branch to run it on or give it a specific commit to test. The former works fine, but the latter does not - though it picks up the given commit and correctly puts it in the env, it doesn't actually use that value when checking out the commit, instead always relying on the default value. This fixes that by always specifying what value to use.
1 parent 4880618 commit 5d3fcc4

File tree

1 file changed

+26
-1
lines changed

1 file changed

+26
-1
lines changed

.github/workflows/build.yml

+26-1
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,8 @@ jobs:
4141
steps:
4242
- name: Check out current commit (${{ env.HEAD_COMMIT }})
4343
uses: actions/checkout@v2
44+
with:
45+
ref: ${{ env.HEAD_COMMIT }}
4446
- name: Set up Node
4547
uses: actions/setup-node@v1
4648
# we use a hash of yarn.lock as our cache key, because if it hasn't changed, our dependencies haven't changed,
@@ -68,6 +70,8 @@ jobs:
6870
steps:
6971
- name: Check out current commit (${{ env.HEAD_COMMIT }})
7072
uses: actions/checkout@v2
73+
with:
74+
ref: ${{ env.HEAD_COMMIT }}
7175
- name: Set up Node
7276
uses: actions/setup-node@v1
7377
- name: Check dependency cache
@@ -109,6 +113,8 @@ jobs:
109113
steps:
110114
- name: Check out current commit (${{ env.HEAD_COMMIT }})
111115
uses: actions/checkout@v2
116+
with:
117+
ref: ${{ env.HEAD_COMMIT }}
112118
- name: Set up Node
113119
uses: actions/setup-node@v1
114120
with:
@@ -139,6 +145,8 @@ jobs:
139145
steps:
140146
- name: Check out current commit (${{ env.HEAD_COMMIT }})
141147
uses: actions/checkout@v2
148+
with:
149+
ref: ${{ env.HEAD_COMMIT }}
142150
- name: Set up Node
143151
uses: actions/setup-node@v1
144152
- name: Check dependency cache
@@ -162,6 +170,8 @@ jobs:
162170
steps:
163171
- name: Check out current commit (${{ env.HEAD_COMMIT }})
164172
uses: actions/checkout@v2
173+
with:
174+
ref: ${{ env.HEAD_COMMIT }}
165175
- name: Set up Node
166176
uses: actions/setup-node@v1
167177
- name: Check dependency cache
@@ -186,6 +196,8 @@ jobs:
186196
steps:
187197
- name: Check out current commit (${{ github.sha }})
188198
uses: actions/checkout@v2
199+
with:
200+
ref: ${{ env.HEAD_COMMIT }}
189201
- name: Set up Node
190202
uses: actions/setup-node@v1
191203
- name: Check dependency cache
@@ -223,6 +235,8 @@ jobs:
223235
steps:
224236
- name: Check out current commit (${{ env.HEAD_COMMIT }})
225237
uses: actions/checkout@v2
238+
with:
239+
ref: ${{ env.HEAD_COMMIT }}
226240
- name: Set up Node
227241
uses: actions/setup-node@v1
228242
with:
@@ -256,6 +270,8 @@ jobs:
256270
steps:
257271
- name: Check out current commit (${{ env.HEAD_COMMIT }})
258272
uses: actions/checkout@v2
273+
with:
274+
ref: ${{ env.HEAD_COMMIT }}
259275
- name: Set up Node
260276
uses: actions/setup-node@v1
261277
with:
@@ -288,11 +304,12 @@ jobs:
288304
steps:
289305
- name: Check out current commit (${{ env.HEAD_COMMIT }})
290306
uses: actions/checkout@v2
307+
with:
308+
ref: ${{ env.HEAD_COMMIT }}
291309
# TODO: removing `fetch-depth` below seems to have no effect, and the commit which added it had no description,
292310
# so it's not clear why it's necessary. That said, right now ember tests are xfail, so it's a little hard to
293311
# tell if it's safe to remove. Once ember tests are fixed, let's try again with it turned off, and if all goes
294312
# well, we can pull it out.
295-
with:
296313
fetch-depth: 0
297314
- name: Set up Node
298315
uses: actions/setup-node@v1
@@ -343,6 +360,8 @@ jobs:
343360
steps:
344361
- name: Check out current commit (${{ env.HEAD_COMMIT }})
345362
uses: actions/checkout@v2
363+
with:
364+
ref: ${{ env.HEAD_COMMIT }}
346365
- name: Set up Node
347366
uses: actions/setup-node@v1
348367
with:
@@ -381,6 +400,8 @@ jobs:
381400
steps:
382401
- name: Check out current commit (${{ env.HEAD_COMMIT }})
383402
uses: actions/checkout@v2
403+
with:
404+
ref: ${{ env.HEAD_COMMIT }}
384405
- name: Set up Node
385406
uses: actions/setup-node@v1
386407
- name: Check dependency cache
@@ -410,6 +431,8 @@ jobs:
410431
steps:
411432
- name: Check out current commit (${ env.HEAD_COMMIT }})
412433
uses: actions/checkout@v2
434+
with:
435+
ref: ${{ env.HEAD_COMMIT }}
413436
- name: Set up Node
414437
uses: actions/setup-node@v1
415438
with:
@@ -445,6 +468,8 @@ jobs:
445468
steps:
446469
- name: Check out current commit (${{ github.sha }})
447470
uses: actions/checkout@v2
471+
with:
472+
ref: ${{ env.HEAD_COMMIT }}
448473
- name: Set up Node
449474
uses: actions/setup-node@v1
450475
with:

0 commit comments

Comments
 (0)