fix(astro): Handle non-utf8 encoded streams in middleware (#9989)

lforst · web-flow · commit 66ea1e678819 · 2023-12-28T18:02:41.000+01:00
diff --git a/packages/astro/src/server/middleware.ts b/packages/astro/src/server/middleware.ts
@@ -162,7 +162,7 @@ async function instrumentRequest(
         const newResponseStream = new ReadableStream({
           start: async controller => {
             for await (const chunk of originalBody) {
-              const html = typeof chunk === 'string' ? chunk : decoder.decode(chunk);
+              const html = typeof chunk === 'string' ? chunk : decoder.decode(chunk, { stream: true });
               const modifiedHtml = addMetaTagToHead(html, scope, client, span);
               controller.enqueue(new TextEncoder().encode(modifiedHtml));
             }

Original file line number	Diff line number	Diff line change
`@@ -162,7 +162,7 @@ async function instrumentRequest(`
`162`	`162`	`const newResponseStream = new ReadableStream({`
`163`	`163`	`start: async controller => {`
`164`	`164`	`for await (const chunk of originalBody) {`
`165`		`- const html = typeof chunk === 'string' ? chunk : decoder.decode(chunk);`
	`165`	`+ const html = typeof chunk === 'string' ? chunk : decoder.decode(chunk, { stream: true });`
`166`	`166`	`const modifiedHtml = addMetaTagToHead(html, scope, client, span);`
`167`	`167`	`controller.enqueue(new TextEncoder().encode(modifiedHtml));`
`168`	`168`	`}`