Skip to content

Commit 774065f

Browse files
authored
chore(dev): Clean up main tsconfigs (#5114)
This does some clean up work on our two main tsconfig files, in `@sentry/typescript` and at the root level of our repo. Included changes: - Removed `pretty` - what we had is the default - Removed `noImplicitAny` and `noImplicitThis` - implied by `strict: true` - Turned off emitting types files, as we now do this separately - Moved `noErrorTruncation` up to the typescript package, so that anyone (is there anyone besides us?) using it gets the benefit of actually being able to see full errors
1 parent 6b6e746 commit 774065f

File tree

2 files changed

+3
-9
lines changed

2 files changed

+3
-9
lines changed

packages/typescript/tsconfig.json

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,18 +8,15 @@
88
"inlineSources": true,
99
"isolatedModules": true,
1010
"lib": ["es6", "dom"],
11-
// "module": "commonjs", // implied by "target" : "es5"
1211
"moduleResolution": "node",
1312
"noEmitHelpers": true,
13+
"noErrorTruncation": true,
1414
"noFallthroughCasesInSwitch": true,
15-
"noImplicitAny": true,
1615
"noImplicitReturns": true,
17-
"noImplicitThis": true,
1816
"noImplicitUseStrict": true,
1917
"noUnusedLocals": true,
2018
"noUnusedParameters": true,
2119
"preserveWatchOutput": true,
22-
"pretty": true,
2320
"sourceMap": true,
2421
"strict": true,
2522
"strictBindCallApply": false,

tsconfig.json

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,9 @@
22
"extends": "./packages/typescript/tsconfig.json",
33

44
"compilerOptions": {
5-
// TODO: turn these on once we switch to only generating types once, using `tsconfig.types.json`
6-
// "declaration": false,
7-
// "declarationMap": false,
8-
95
"allowSyntheticDefaultImports": true,
6+
"declaration": false,
7+
"declarationMap": false,
108
"types": ["node"],
11-
"noErrorTruncation": true // move me up to @sentry/typescript
129
}
1310
}

0 commit comments

Comments
 (0)