context

Author: billyvg

packages/replay/src/util/sendReplayRequest.ts

@@ -67,10 +67,10 @@ export async function sendReplayRequest({
     ...replayEvent.contexts,
     replay: {
       ...(replayEvent.contexts && replayEvent.contexts.replay),
-      replaysOnErrorSampleRate: options.sessionSampleRate,
-      replaysSessionSampleRate: options.errorSampleRate,
-    }
-  }
+      session_sample_rate: options.sessionSampleRate,
+      error_sample_rate: options.errorSampleRate,
+    },
+  };
 
   /*
   For reference, the fully built event looks something like this:

packages/replay/test/integration/errorSampleRate.test.ts

@@ -63,8 +63,12 @@ describe('Integration | errorSampleRate', () => {
       recordingPayloadHeader: { segment_id: 0 },
       replayEventPayload: expect.objectContaining({
         replay_type: 'error',
-        error_sample_rate: 1,
-        session_sample_rate: 0,
+        contexts: {
+          replay: {
+            error_sample_rate: 1,
+            session_sample_rate: 0,
+          },
+        },
       }),
       recordingData: JSON.stringify([
         { data: { isCheckout: true }, timestamp: BASE_TIMESTAMP, type: 2 },
@@ -91,8 +95,12 @@ describe('Integration | errorSampleRate', () => {
       recordingPayloadHeader: { segment_id: 1 },
       replayEventPayload: expect.objectContaining({
         replay_type: 'error',
-        error_sample_rate: 1,
-        session_sample_rate: 0,
+        contexts: {
+          replay: {
+            error_sample_rate: 1,
+            session_sample_rate: 0,
+          },
+        },
       }),
       recordingData: JSON.stringify([{ data: { isCheckout: true }, timestamp: BASE_TIMESTAMP + 5020, type: 2 }]),
     });

packages/replay/test/integration/events.test.ts

@@ -130,8 +130,12 @@ describe('Integration | events', () => {
     expect(replay).toHaveLastSentReplay({
       replayEventPayload: expect.objectContaining({
         replay_start_timestamp: (BASE_TIMESTAMP - 10000) / 1000,
-        error_sample_rate: 0,
-        session_sample_rate: 1,
+        contexts: {
+          replay: {
+            error_sample_rate: 0,
+            session_sample_rate: 1,
+          },
+        },
         urls: ['http://localhost/'], // this doesn't truly test if we are capturing the right URL as we don't change URLs, but good enough
       }),
     });

packages/replay/test/unit/util/createReplayEnvelope.test.ts

@@ -24,8 +24,12 @@ describe('Unit | util | createReplayEnvelope', () => {
       version: '7.25.0',
     },
     replay_type: 'error',
-    error_sample_rate: 0,
-    session_sample_rate: 1,
+    contexts: {
+      replay: {
+        error_sample_rate: 0,
+        session_sample_rate: 1,
+      },
+    },
     tags: {},
   };
 
@@ -53,16 +57,20 @@ describe('Unit | util | createReplayEnvelope', () => {
         [
           { type: 'replay_event' },
           {
+            contexts: {
+              replay: {
+                error_sample_rate: 0,
+                session_sample_rate: 1,
+              },
+            },
             environment: 'production',
             error_ids: ['errorId'],
-            error_sample_rate: 0,
             event_id: REPLAY_ID,
             platform: 'javascript',
             replay_id: REPLAY_ID,
             replay_type: 'error',
             sdk: { integrations: ['BrowserTracing', 'Replay'], name: 'sentry.javascript.unknown', version: '7.25.0' },
             segment_id: 3,
-            session_sample_rate: 1,
             tags: {},
             timestamp: 1670837008.634,
             trace_ids: ['traceId'],
@@ -89,16 +97,20 @@ describe('Unit | util | createReplayEnvelope', () => {
         [
           { type: 'replay_event' },
           {
+            contexts: {
+              replay: {
+                error_sample_rate: 0,
+                session_sample_rate: 1,
+              },
+            },
             environment: 'production',
             error_ids: ['errorId'],
-            error_sample_rate: 0,
             event_id: REPLAY_ID,
             platform: 'javascript',
             replay_id: REPLAY_ID,
             sdk: { integrations: ['BrowserTracing', 'Replay'], name: 'sentry.javascript.unknown', version: '7.25.0' },
             segment_id: 3,
             replay_type: 'error',
-            session_sample_rate: 1,
             tags: {},
             timestamp: 1670837008.634,
             trace_ids: ['traceId'],

packages/replay/test/unit/util/prepareReplayEvent.test.ts

@@ -48,8 +48,12 @@ describe('Unit | util | prepareReplayEvent', () => {
       replay_id: replayId,
       replay_type: 'session',
       segment_id: 3,
-      error_sample_rate: 1.0,
-      session_sample_rate: 0.1,
+      contexts: {
+        replay: {
+          error_sample_rate: 1.0,
+          session_sample_rate: 0.1,
+        },
+      },
     };
 
     const replayEvent = await prepareReplayEvent({ scope, client, replayId, event });
@@ -68,8 +72,12 @@ describe('Unit | util | prepareReplayEvent', () => {
       platform: 'javascript',
       event_id: 'replay-ID',
       environment: 'production',
-      error_sample_rate: 1.0,
-      session_sample_rate: 0.1,
+      contexts: {
+        replay: {
+          error_sample_rate: 1.0,
+          session_sample_rate: 0.1,
+        },
+      },
       sdk: {
         name: 'sentry.javascript.testSdk',
         version: '1.0.0',