Skip to content

Commit 961d3af

Browse files
authored
fix(tests): Use non-delayed success endpoints to test crashed and errored cases. (#4937)
1 parent 2593be0 commit 961d3af

File tree

3 files changed

+3
-4
lines changed
  • packages/node-integration-tests/suites/sessions

3 files changed

+3
-4
lines changed

packages/node-integration-tests/suites/sessions/crashed-session-aggregate/test.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ test('should aggregate successful and crashed sessions', async () => {
88
const envelope = await Promise.race([
99
getEnvelopeRequest(`${url}/success`),
1010
getEnvelopeRequest(`${url}/error_unhandled`),
11-
getEnvelopeRequest(`${url}/success_slow`),
11+
getEnvelopeRequest(`${url}/success_next`),
1212
]);
1313

1414
expect(envelope).toHaveLength(3);

packages/node-integration-tests/suites/sessions/errored-session-aggregate/test.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ test('should aggregate successful, crashed and erroneous sessions', async () =>
66
const url = await runServer(__dirname, `${path.resolve(__dirname, '..')}/server.ts`);
77

88
const envelope = await Promise.race([
9-
getEnvelopeRequest(`${url}/success_slow`),
9+
getEnvelopeRequest(`${url}/success`),
1010
getEnvelopeRequest(`${url}/error_handled`),
1111
getEnvelopeRequest(`${url}/error_unhandled`),
1212
]);

packages/node-integration-tests/suites/sessions/server.ts

+1-2
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,7 @@ clearInterval(flusherIntervalId);
2424
// @ts-ignore: need access to `_intervalId`
2525
flusherIntervalId = flusher?._intervalId = setInterval(() => flusher?.flush(), 1000);
2626

27-
// @ts-ignore: need access to `_intervalId` again
28-
setTimeout(() => clearInterval(flusherIntervalId), 3000);
27+
setTimeout(() => clearInterval(flusherIntervalId), 2000);
2928

3029
app.get('/test/success', (_req, res) => {
3130
res.send('Success!');

0 commit comments

Comments
 (0)