Skip to content

Commit 9e6e3a4

Browse files
lobsterkatielobsterkatie
committed
s/user/publicKey in Dsn type and class
1 parent 5f69a63 commit 9e6e3a4

File tree

4 files changed

+34
-24
lines changed

4 files changed

+34
-24
lines changed

‎packages/core/src/api.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ export class API {
7676
const dsn = this._dsnObject;
7777
const header = [`Sentry sentry_version=${SENTRY_API_VERSION}`];
7878
header.push(`sentry_client=${clientName}/${clientVersion}`);
79-
header.push(`sentry_key=${dsn.user}`);
79+
header.push(`sentry_key=${dsn.publicKey}`);
8080
if (dsn.pass) {
8181
header.push(`sentry_secret=${dsn.pass}`);
8282
}
@@ -143,7 +143,7 @@ export class API {
143143
const auth = {
144144
// We send only the minimum set of required information. See
145145
// https://github.com/getsentry/sentry-javascript/issues/2572.
146-
sentry_key: dsn.user,
146+
sentry_key: dsn.publicKey,
147147
sentry_version: SENTRY_API_VERSION,
148148
};
149149
return urlEncode(auth);

‎packages/types/src/dsn.ts

+3-1
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,10 @@ export type DsnProtocol = 'http' | 'https';
55
export interface DsnComponents {
66
/** Protocol used to connect to Sentry. */
77
protocol: DsnProtocol;
8+
/** Public authorization key (deprecated, renamed to publicKey). */
9+
user?: string;
810
/** Public authorization key. */
9-
user: string;
11+
publicKey?: string;
1012
/** Private authorization key (deprecated, optional). */
1113
pass?: string;
1214
/** Hostname of the Sentry instance. */

‎packages/utils/src/dsn.ts

+15-7
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,10 @@ const ERROR_MESSAGE = 'Invalid Dsn';
1212
export class Dsn implements DsnComponents {
1313
/** Protocol used to connect to Sentry. */
1414
public protocol!: DsnProtocol;
15-
/** Public authorization key. */
15+
/** Public authorization key (deprecated, renamed to publicKey). */
1616
public user!: string;
17+
/** Public authorization key. */
18+
public publicKey!: string;
1719
/** Private authorization key (deprecated, optional). */
1820
public pass!: string;
1921
/** Hostname of the Sentry instance. */
@@ -46,9 +48,9 @@ export class Dsn implements DsnComponents {
4648
* @param withPassword When set to true, the password will be included.
4749
*/
4850
public toString(withPassword: boolean = false): string {
49-
const { host, path, pass, port, projectId, protocol, user } = this;
51+
const { host, path, pass, port, projectId, protocol, publicKey } = this;
5052
return (
51-
`${protocol}://${user}${withPassword && pass ? `:${pass}` : ''}` +
53+
`${protocol}://${publicKey}${withPassword && pass ? `:${pass}` : ''}` +
5254
`@${host}${port ? `:${port}` : ''}/${path ? `${path}/` : path}${projectId}`
5355
);
5456
}
@@ -61,7 +63,7 @@ export class Dsn implements DsnComponents {
6163
throw new SentryError(ERROR_MESSAGE);
6264
}
6365

64-
const [protocol, user, pass = '', host, port = '', lastPath] = match.slice(1);
66+
const [protocol, publicKey, pass = '', host, port = '', lastPath] = match.slice(1);
6567
let path = '';
6668
let projectId = lastPath;
6769

@@ -78,13 +80,19 @@ export class Dsn implements DsnComponents {
7880
}
7981
}
8082

81-
this._fromComponents({ host, pass, path, projectId, port, protocol: protocol as DsnProtocol, user });
83+
this._fromComponents({ host, pass, path, projectId, port, protocol: protocol as DsnProtocol, publicKey });
8284
}
8385

8486
/** Maps Dsn components into this instance. */
8587
private _fromComponents(components: DsnComponents): void {
88+
// TODO this is for backwards compatibility, and can be removed in a future version
89+
if ('user' in components && !('publicKey' in components)) {
90+
components.publicKey = components.user;
91+
}
92+
this.user = components.publicKey || '';
93+
8694
this.protocol = components.protocol;
87-
this.user = components.user;
95+
this.publicKey = components.publicKey || '';
8896
this.pass = components.pass || '';
8997
this.host = components.host;
9098
this.port = components.port || '';
@@ -94,7 +102,7 @@ export class Dsn implements DsnComponents {
94102

95103
/** Validates this Dsn and throws on error. */
96104
private _validate(): void {
97-
['protocol', 'user', 'host', 'projectId'].forEach(component => {
105+
['protocol', 'publicKey', 'host', 'projectId'].forEach(component => {
98106
if (!this[component as keyof DsnComponents]) {
99107
throw new SentryError(`${ERROR_MESSAGE}: ${component} missing`);
100108
}

‎packages/utils/test/dsn.test.ts

+14-14
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,10 @@ describe('Dsn', () => {
1010
port: '1234',
1111
projectId: '123',
1212
protocol: 'https',
13-
user: 'abc',
13+
publicKey: 'abc',
1414
});
1515
expect(dsn.protocol).toBe('https');
16-
expect(dsn.user).toBe('abc');
16+
expect(dsn.publicKey).toBe('abc');
1717
expect(dsn.pass).toBe('xyz');
1818
expect(dsn.host).toBe('sentry.io');
1919
expect(dsn.port).toBe('1234');
@@ -26,10 +26,10 @@ describe('Dsn', () => {
2626
host: 'sentry.io',
2727
projectId: '123',
2828
protocol: 'https',
29-
user: 'abc',
29+
publicKey: 'abc',
3030
});
3131
expect(dsn.protocol).toBe('https');
32-
expect(dsn.user).toBe('abc');
32+
expect(dsn.publicKey).toBe('abc');
3333
expect(dsn.pass).toBe('');
3434
expect(dsn.host).toBe('sentry.io');
3535
expect(dsn.port).toBe('');
@@ -44,7 +44,7 @@ describe('Dsn', () => {
4444
host: '',
4545
projectId: '123',
4646
protocol: 'https',
47-
user: 'abc',
47+
publicKey: 'abc',
4848
}),
4949
).toThrow(SentryError);
5050
expect(
@@ -53,7 +53,7 @@ describe('Dsn', () => {
5353
host: 'sentry.io',
5454
projectId: '',
5555
protocol: 'https',
56-
user: 'abc',
56+
publicKey: 'abc',
5757
}),
5858
).toThrow(SentryError);
5959
expect(
@@ -62,7 +62,7 @@ describe('Dsn', () => {
6262
host: 'sentry.io',
6363
projectId: '123',
6464
protocol: '' as 'http', // Trick the type checker here
65-
user: 'abc',
65+
publicKey: 'abc',
6666
}),
6767
).toThrow(SentryError);
6868
expect(
@@ -71,7 +71,7 @@ describe('Dsn', () => {
7171
host: 'sentry.io',
7272
projectId: '123',
7373
protocol: 'https',
74-
user: '',
74+
publicKey: '',
7575
}),
7676
).toThrow(SentryError);
7777
});
@@ -83,7 +83,7 @@ describe('Dsn', () => {
8383
host: 'sentry.io',
8484
projectId: '123',
8585
protocol: 'httpx' as 'http', // Trick the type checker here
86-
user: 'abc',
86+
publicKey: 'abc',
8787
}),
8888
).toThrow(SentryError);
8989
expect(
@@ -93,7 +93,7 @@ describe('Dsn', () => {
9393
port: 'xxx',
9494
projectId: '123',
9595
protocol: 'https',
96-
user: 'abc',
96+
publicKey: 'abc',
9797
}),
9898
).toThrow(SentryError);
9999
});
@@ -103,7 +103,7 @@ describe('Dsn', () => {
103103
test('parses a valid full Dsn', () => {
104104
const dsn = new Dsn('https://abc:[email protected]:1234/123');
105105
expect(dsn.protocol).toBe('https');
106-
expect(dsn.user).toBe('abc');
106+
expect(dsn.publicKey).toBe('abc');
107107
expect(dsn.pass).toBe('xyz');
108108
expect(dsn.host).toBe('sentry.io');
109109
expect(dsn.port).toBe('1234');
@@ -114,7 +114,7 @@ describe('Dsn', () => {
114114
test('parses a valid partial Dsn', () => {
115115
const dsn = new Dsn('https://[email protected]/123/321');
116116
expect(dsn.protocol).toBe('https');
117-
expect(dsn.user).toBe('abc');
117+
expect(dsn.publicKey).toBe('abc');
118118
expect(dsn.pass).toBe('');
119119
expect(dsn.host).toBe('sentry.io');
120120
expect(dsn.port).toBe('');
@@ -125,7 +125,7 @@ describe('Dsn', () => {
125125
test('with a long path', () => {
126126
const dsn = new Dsn('https://[email protected]/sentry/custom/installation/321');
127127
expect(dsn.protocol).toBe('https');
128-
expect(dsn.user).toBe('abc');
128+
expect(dsn.publicKey).toBe('abc');
129129
expect(dsn.pass).toBe('');
130130
expect(dsn.host).toBe('sentry.io');
131131
expect(dsn.port).toBe('');
@@ -136,7 +136,7 @@ describe('Dsn', () => {
136136
test('with a query string', () => {
137137
const dsn = new Dsn('https://[email protected]/321?sample.rate=0.1&other=value');
138138
expect(dsn.protocol).toBe('https');
139-
expect(dsn.user).toBe('abc');
139+
expect(dsn.publicKey).toBe('abc');
140140
expect(dsn.pass).toBe('');
141141
expect(dsn.host).toBe('sentry.io');
142142
expect(dsn.port).toBe('');

0 commit comments

Comments
 (0)