Skip to content

Commit b3a7086

Browse files
authored
feat(solid): Rename solidjs package to solid (#12436)
1 parent 54c26cd commit b3a7086

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

44 files changed

+204
-116
lines changed

.github/workflows/build.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1014,7 +1014,7 @@ jobs:
10141014
'react-router-6-use-routes',
10151015
'react-router-5',
10161016
'react-router-6',
1017-
'solidjs',
1017+
'solid',
10181018
'svelte-5',
10191019
'sveltekit',
10201020
'sveltekit-2',

dev-packages/e2e-tests/test-applications/solidjs/package.json renamed to dev-packages/e2e-tests/test-applications/solid/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
2-
"name": "solidjs",
2+
"name": "solid",
33
"version": "0.0.0",
44
"description": "",
55
"scripts": {
@@ -28,6 +28,6 @@
2828
"dependencies": {
2929
"@solidjs/router": "^0.13.5",
3030
"solid-js": "^1.8.11",
31-
"@sentry/solidjs": "latest || *"
31+
"@sentry/solid": "latest || *"
3232
}
3333
}

dev-packages/e2e-tests/test-applications/solidjs/src/index.tsx renamed to dev-packages/e2e-tests/test-applications/solid/src/index.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/* @refresh reload */
2-
import * as Sentry from '@sentry/solidjs';
2+
import * as Sentry from '@sentry/solid';
33
import { Router, useBeforeLeave, useLocation } from '@solidjs/router';
44
import { render } from 'solid-js/web';
55
import './index.css';

dev-packages/e2e-tests/test-applications/solidjs/src/pages/errorboundaryexample.tsx renamed to dev-packages/e2e-tests/test-applications/solid/src/pages/errorboundaryexample.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import * as Sentry from '@sentry/solidjs';
1+
import * as Sentry from '@sentry/solid';
22
import { ErrorBoundary } from 'solid-js';
33

44
const SentryErrorBoundary = Sentry.withSentryErrorBoundary(ErrorBoundary);

dev-packages/e2e-tests/test-applications/solidjs/src/pages/home.tsx renamed to dev-packages/e2e-tests/test-applications/solid/src/pages/home.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ export default function Home() {
2525
class="border rounded-lg px-2 mb-2 border-red-500 text-red-500 cursor-pointer"
2626
id="errorBtn"
2727
onClick={() => {
28-
throw new Error('Error thrown from SolidJS E2E test app');
28+
throw new Error('Error thrown from Solid E2E test app');
2929
}}
3030
>
3131
Throw error

dev-packages/e2e-tests/test-applications/solidjs/start-event-proxy.mjs renamed to dev-packages/e2e-tests/test-applications/solid/start-event-proxy.mjs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,5 +2,5 @@ import { startEventProxyServer } from '@sentry-internal/test-utils';
22

33
startEventProxyServer({
44
port: 3031,
5-
proxyServerName: 'solidjs',
5+
proxyServerName: 'solid',
66
});

dev-packages/e2e-tests/test-applications/solidjs/tests/errorboundary.test.ts renamed to dev-packages/e2e-tests/test-applications/solid/tests/errorboundary.test.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import { expect, test } from '@playwright/test';
22
import { waitForError } from '@sentry-internal/test-utils';
33

44
test('captures an exception', async ({ page }) => {
5-
const errorEventPromise = waitForError('solidjs', errorEvent => {
5+
const errorEventPromise = waitForError('solid', errorEvent => {
66
return !errorEvent.type;
77
});
88

@@ -26,7 +26,7 @@ test('captures an exception', async ({ page }) => {
2626
});
2727

2828
test('captures a second exception after resetting the boundary', async ({ page }) => {
29-
const firstErrorEventPromise = waitForError('solidjs', errorEvent => {
29+
const firstErrorEventPromise = waitForError('solid', errorEvent => {
3030
return !errorEvent.type;
3131
});
3232

@@ -48,7 +48,7 @@ test('captures a second exception after resetting the boundary', async ({ page }
4848
transaction: '/error-boundary-example',
4949
});
5050

51-
const secondErrorEventPromise = waitForError('solidjs', errorEvent => {
51+
const secondErrorEventPromise = waitForError('solid', errorEvent => {
5252
return !errorEvent.type;
5353
});
5454

dev-packages/e2e-tests/test-applications/solidjs/tests/errors.test.ts renamed to dev-packages/e2e-tests/test-applications/solid/tests/errors.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import { expect, test } from '@playwright/test';
22
import { waitForError } from '@sentry-internal/test-utils';
33

44
test('sends an error', async ({ page }) => {
5-
const errorPromise = waitForError('solidjs', async errorEvent => {
5+
const errorPromise = waitForError('solid', async errorEvent => {
66
return !errorEvent.type;
77
});
88

@@ -15,7 +15,7 @@ test('sends an error', async ({ page }) => {
1515
values: [
1616
{
1717
type: 'Error',
18-
value: 'Error thrown from SolidJS E2E test app',
18+
value: 'Error thrown from Solid E2E test app',
1919
mechanism: {
2020
type: 'onerror',
2121
handled: false,

dev-packages/e2e-tests/test-applications/solidjs/tests/performance.test.ts renamed to dev-packages/e2e-tests/test-applications/solid/tests/performance.test.ts

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import { expect, test } from '@playwright/test';
22
import { waitForTransaction } from '@sentry-internal/test-utils';
33

44
test('sends a pageload transaction', async ({ page }) => {
5-
const transactionPromise = waitForTransaction('solidjs', async transactionEvent => {
5+
const transactionPromise = waitForTransaction('solid', async transactionEvent => {
66
return !!transactionEvent?.transaction && transactionEvent.contexts?.trace?.op === 'pageload';
77
});
88

@@ -23,7 +23,7 @@ test('sends a pageload transaction', async ({ page }) => {
2323
});
2424

2525
test('sends a navigation transaction', async ({ page }) => {
26-
const transactionPromise = waitForTransaction('solidjs', async transactionEvent => {
26+
const transactionPromise = waitForTransaction('solid', async transactionEvent => {
2727
return !!transactionEvent?.transaction && transactionEvent.contexts?.trace?.op === 'navigation';
2828
});
2929

@@ -35,7 +35,7 @@ test('sends a navigation transaction', async ({ page }) => {
3535
contexts: {
3636
trace: {
3737
op: 'navigation',
38-
origin: 'auto.navigation.solidjs.solidrouter',
38+
origin: 'auto.navigation.solid.solidrouter',
3939
},
4040
},
4141
transaction: '/user/5',
@@ -49,7 +49,7 @@ test('updates the transaction when using the back button', async ({ page }) => {
4949
// Solid Router sends a `-1` navigation when using the back button.
5050
// The sentry solidRouterBrowserTracingIntegration tries to update such
5151
// transactions with the proper name once the `useLocation` hook triggers.
52-
const navigationTxnPromise = waitForTransaction('solidjs', async transactionEvent => {
52+
const navigationTxnPromise = waitForTransaction('solid', async transactionEvent => {
5353
return !!transactionEvent?.transaction && transactionEvent.contexts?.trace?.op === 'navigation';
5454
});
5555

@@ -61,7 +61,7 @@ test('updates the transaction when using the back button', async ({ page }) => {
6161
contexts: {
6262
trace: {
6363
op: 'navigation',
64-
origin: 'auto.navigation.solidjs.solidrouter',
64+
origin: 'auto.navigation.solid.solidrouter',
6565
},
6666
},
6767
transaction: '/user/5',
@@ -70,7 +70,7 @@ test('updates the transaction when using the back button', async ({ page }) => {
7070
},
7171
});
7272

73-
const backNavigationTxnPromise = waitForTransaction('solidjs', async transactionEvent => {
73+
const backNavigationTxnPromise = waitForTransaction('solid', async transactionEvent => {
7474
return !!transactionEvent?.transaction && transactionEvent.contexts?.trace?.op === 'navigation';
7575
});
7676

@@ -80,7 +80,7 @@ test('updates the transaction when using the back button', async ({ page }) => {
8080
contexts: {
8181
trace: {
8282
op: 'navigation',
83-
origin: 'auto.navigation.solidjs.solidrouter',
83+
origin: 'auto.navigation.solid.solidrouter',
8484
},
8585
},
8686
transaction: '/',

dev-packages/e2e-tests/verdaccio-config/config.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ packages:
128128
unpublish: $all
129129
# proxy: npmjs # Don't proxy for E2E tests!
130130

131-
'@sentry/solidjs':
131+
'@sentry/solid':
132132
access: $all
133133
publish: $all
134134
unpublish: $all

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@
6969
"packages/replay-internal",
7070
"packages/replay-canvas",
7171
"packages/replay-worker",
72-
"packages/solidjs",
72+
"packages/solid",
7373
"packages/svelte",
7474
"packages/sveltekit",
7575
"packages/types",
File renamed without changes.
File renamed without changes.

packages/solidjs/README.md renamed to packages/solid/README.md

Lines changed: 6 additions & 6 deletions

packages/solidjs/package.json renamed to packages/solid/package.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
{
2-
"name": "@sentry/solidjs",
2+
"name": "@sentry/solid",
33
"version": "8.8.0",
4-
"description": "Official Sentry SDK for SolidJS",
4+
"description": "Official Sentry SDK for Solid",
55
"repository": "git://github.com/getsentry/sentry-javascript.git",
6-
"homepage": "https://github.com/getsentry/sentry-javascript/tree/master/packages/solidjs",
6+
"homepage": "https://github.com/getsentry/sentry-javascript/tree/master/packages/solid",
77
"author": "Sentry",
88
"license": "MIT",
99
"engines": {
@@ -71,7 +71,7 @@
7171
"build:types:watch": "tsc -p tsconfig.types.json --watch",
7272
"build:tarball": "ts-node ../../scripts/prepack.ts && npm pack ./build",
7373
"circularDepCheck": "madge --circular src/index.ts",
74-
"clean": "rimraf build coverage sentry-solidjs-*.tgz",
74+
"clean": "rimraf build coverage sentry-solid-*.tgz",
7575
"fix": "eslint . --format stylish --fix",
7676
"lint": "eslint . --format stylish",
7777
"test": "vitest run",
File renamed without changes.

packages/solidjs/src/sdk.ts renamed to packages/solid/src/sdk.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,14 +3,14 @@ import { init as browserInit } from '@sentry/browser';
33
import { applySdkMetadata } from '@sentry/core';
44

55
/**
6-
* Initializes the SolidJS SDK
6+
* Initializes the Solid SDK
77
*/
88
export function init(options: BrowserOptions): void {
99
const opts = {
1010
...options,
1111
};
1212

13-
applySdkMetadata(opts, 'solidjs');
13+
applySdkMetadata(opts, 'solid');
1414

1515
browserInit(opts);
1616
}

packages/solidjs/src/solidrouter.ts renamed to packages/solid/src/solidrouter.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ function handleNavigation(location: string): void {
7171
name: location,
7272
attributes: {
7373
[SEMANTIC_ATTRIBUTE_SENTRY_OP]: 'navigation',
74-
[SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.navigation.solidjs.solidrouter',
74+
[SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.navigation.solid.solidrouter',
7575
[SEMANTIC_ATTRIBUTE_SENTRY_SOURCE]: 'url',
7676
},
7777
});

packages/solidjs/test/sdk.test.ts renamed to packages/solid/test/sdk.test.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import { init as solidInit } from '../src/sdk';
66

77
const browserInit = vi.spyOn(SentryBrowser, 'init');
88

9-
describe('Initialize SolidJS SDk', () => {
9+
describe('Initialize Solid SDk', () => {
1010
beforeEach(() => {
1111
vi.clearAllMocks();
1212
});
@@ -19,8 +19,8 @@ describe('Initialize SolidJS SDk', () => {
1919
const expectedMetadata = {
2020
_metadata: {
2121
sdk: {
22-
name: 'sentry.javascript.solidjs',
23-
packages: [{ name: 'npm:@sentry/solidjs', version: SDK_VERSION }],
22+
name: 'sentry.javascript.solid',
23+
packages: [{ name: 'npm:@sentry/solid', version: SDK_VERSION }],
2424
version: SDK_VERSION,
2525
},
2626
},

packages/solidjs/test/solidrouter.test.tsx renamed to packages/solid/test/solidrouter.test.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,7 @@ describe('solidRouterBrowserTracingIntegration', () => {
139139
data: expect.objectContaining({
140140
[SEMANTIC_ATTRIBUTE_SENTRY_SOURCE]: 'url',
141141
[SEMANTIC_ATTRIBUTE_SENTRY_OP]: 'navigation',
142-
[SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.navigation.solidjs.solidrouter',
142+
[SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.navigation.solid.solidrouter',
143143
}),
144144
}),
145145
);
@@ -173,7 +173,7 @@ describe('solidRouterBrowserTracingIntegration', () => {
173173
data: expect.objectContaining({
174174
[SEMANTIC_ATTRIBUTE_SENTRY_SOURCE]: 'url',
175175
[SEMANTIC_ATTRIBUTE_SENTRY_OP]: 'navigation',
176-
[SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.navigation.solidjs.solidrouter',
176+
[SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.navigation.solid.solidrouter',
177177
}),
178178
}),
179179
);
File renamed without changes.
File renamed without changes.

scripts/node-unit-tests.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ const DEFAULT_SKIP_TESTS_PACKAGES = [
1515
'@sentry/vue',
1616
'@sentry/react',
1717
'@sentry/angular',
18-
'@sentry/solidjs',
18+
'@sentry/solid',
1919
'@sentry/svelte',
2020
'@sentry/profiling-node',
2121
'@sentry-internal/browser-utils',

0 commit comments

Comments
 (0)