add tests

Author: Lms24

packages/core/src/tracing/spanstatus.ts

@@ -128,10 +128,13 @@ export function spanStatusfromHttpCode(httpStatus: number): SpanStatusType {
  * Additionally, the span's status is updated, depending on the http code.
  */
 export function setHttpStatus(span: Span, httpStatus: number): void {
-  span.setAttribute('http.status_code', String(httpStatus));
-  span.setAttribute('http.response.status_code', httpStatus);
-
   // TODO (v8): Remove these calls
+  // Relay does not require us to send the status code as a tag
+  // For now, just because users might expect it to land as a tag we keep sending it.
+  // Same with data.
+  // In v8, we replace both, simply with
+  // span.setAttribute('http.response.status_code', httpStatus);
+
   // eslint-disable-next-line deprecation/deprecation
   span.setTag('http.status_code', String(httpStatus));
   // eslint-disable-next-line deprecation/deprecation

packages/core/test/lib/tracing/spanstatus.test.ts

@@ -0,0 +1,41 @@
+import { Span, setHttpStatus, spanToJSON } from '../../../src/index';
+
+describe('setHttpStatus', () => {
+  it.each([
+    [200, 'ok'],
+    [300, 'ok'],
+    [401, 'unauthenticated'],
+    [403, 'permission_denied'],
+    [404, 'not_found'],
+    [409, 'already_exists'],
+    [413, 'failed_precondition'],
+    [429, 'resource_exhausted'],
+    [455, 'invalid_argument'],
+    [501, 'unimplemented'],
+    [503, 'unavailable'],
+    [504, 'deadline_exceeded'],
+    [520, 'internal_error'],
+  ])('applies the correct span status and http status code to the span (%s - $%s)', (code, status) => {
+    const span = new Span({ name: 'test' });
+
+    setHttpStatus(span!, code);
+
+    const { status: spanStatus, data, tags } = spanToJSON(span!);
+
+    expect(spanStatus).toBe(status);
+    expect(data).toMatchObject({ 'http.response.status_code': code });
+    expect(tags).toMatchObject({ 'http.status_code': String(code) });
+  });
+
+  it("doesn't set the status for an unknown http status code", () => {
+    const span = new Span({ name: 'test' });
+
+    setHttpStatus(span!, 600);
+
+    const { status: spanStatus, data, tags } = spanToJSON(span!);
+
+    expect(spanStatus).toBeUndefined();
+    expect(data).toMatchObject({ 'http.response.status_code': 600 });
+    expect(tags).toMatchObject({ 'http.status_code': '600' });
+  });
+});