Switch back to JS for sourcemap scripts.

Author: onurtemizkan

packages/remix/.eslintrc.js

@@ -6,14 +6,6 @@ module.exports = {
   parserOptions: {
     jsx: true,
   },
-  overrides: [
-    {
-      files: ['scripts/**/*.ts'],
-      parserOptions: {
-        project: ['tsconfig.json'],
-      },
-    },
-  ],
   extends: ['../../.eslintrc.js'],
   rules: {
     '@sentry-internal/sdk/no-async-await': 'off',

packages/remix/package.json

@@ -7,7 +7,7 @@
   "author": "Sentry",
   "license": "MIT",
   "bin": {
-    "upload-sourcemaps": "build/cjs/scripts/upload-sourcemaps.js"
+    "upload-sourcemaps": "scripts/upload-sourcemaps.js"
   },
   "engines": {
     "node": ">=14"
@@ -32,8 +32,7 @@
   },
   "devDependencies": {
     "@remix-run/node": "^1.4.3",
-    "@remix-run/react": "^1.4.3",
-    "rollup-plugin-hashbang": "^3.0.0"
+    "@remix-run/react": "^1.4.3"
   },
   "peerDependencies": {
     "@remix-run/node": "^1.4.3",

packages/remix/rollup.npm.config.js

@@ -1,15 +1,7 @@
-import hashbang from 'rollup-plugin-hashbang';
-
 import { makeBaseNPMConfig, makeNPMConfigVariants } from '../../rollup/index.js';
 
 export default makeNPMConfigVariants(
   makeBaseNPMConfig({
-    entrypoints: ['src/index.server.ts', 'src/index.client.tsx', 'scripts/upload-sourcemaps.ts'],
-    packageSpecificConfig: {
-      // Rollup fails when there's a hashbang in the file
-      // Ref: https://github.com/rollup/rollup/issues/235
-      // This plugin also gives execution permissions to the output files.
-      plugins: [hashbang()],
-    },
+    entrypoints: ['src/index.server.ts', 'src/index.client.tsx'],
   }),
 );

packages/remix/scripts/createRelease.js

@@ -0,0 +1,21 @@
+const SentryCli = require('@sentry/cli');
+const sentry = new SentryCli();
+
+async function createRelease(argv, DEFAULT_URL_PREFIX, DEFAULT_BUILD_PATH) {
+  const RELEASE = argv.release || (await sentry.releases.proposeVersion());
+  const URL_PREFIX = argv.urlPrefix || DEFAULT_URL_PREFIX;
+  const BUILD_PATH = argv.buildPath || DEFAULT_BUILD_PATH;
+
+  await sentry.releases.new(RELEASE);
+
+  await sentry.releases.uploadSourceMaps(RELEASE, {
+    urlPrefix: URL_PREFIX,
+    include: [BUILD_PATH],
+  });
+
+  await sentry.releases.finalize(RELEASE);
+}
+
+module.exports = {
+  createRelease,
+};

packages/remix/scripts/createRelease.ts

@@ -1,7 +1,7 @@
 #!/usr/bin/env node
-import yargs from 'yargs';
+const yargs = require('yargs');
 
-import { createRelease } from './createRelease';
+const { createRelease } = require('./createRelease');
 
 const DEFAULT_URL_PREFIX = '~/build/';
 const DEFAULT_BUILD_PATH = 'public/build';
@@ -36,4 +36,4 @@ const argv = yargs(process.argv.slice(2))
   )
   .wrap(120).argv;
 
-void createRelease(argv, DEFAULT_URL_PREFIX, DEFAULT_BUILD_PATH);
+createRelease(argv, DEFAULT_URL_PREFIX, DEFAULT_BUILD_PATH);

packages/remix/scripts/upload-sourcemaps.ts renamed to packages/remix/scripts/upload-sourcemaps.js

@@ -17,7 +17,8 @@ jest.mock('@sentry/cli', () => {
   });
 });
 
-import { createRelease } from '../../scripts/createRelease';
+// eslint-disable-next-line @typescript-eslint/no-var-requires
+const { createRelease } = require('../../scripts/createRelease');
 
 beforeEach(() => {
   newMock.mockClear();
@@ -70,3 +71,7 @@ describe('createRelease', () => {
     expect(finalizeMock).toHaveBeenCalledWith('0.1.2.3.4');
   });
 });
+
+// To avoid `--isolatedModules` flag as we're not importing
+// anything for these tests.
+export {};

packages/remix/test/scripts/upload-sourcemaps.test.ts

@@ -1,7 +1,7 @@
 {
   "extends": "../../tsconfig.json",
 
-  "include": ["src/**/*", "scripts/**/*"],
+  "include": ["src/**/*"],
 
   "compilerOptions": {
     "jsx": "react"

packages/remix/tsconfig.json

@@ -22634,13 +22634,6 @@ ripemd160@^2.0.0, ripemd160@^2.0.1:
     hash-base "^3.0.0"
     inherits "^2.0.1"
 
-rollup-plugin-hashbang@^3.0.0:
-  version "3.0.0"
-  resolved "https://registry.yarnpkg.com/rollup-plugin-hashbang/-/rollup-plugin-hashbang-3.0.0.tgz#6173df959592ba73d2e8ce01816a37c511a5e005"
-  integrity sha512-nNC2NeNcvkklPhPCUF8Yb+2a19xI0dSBBJJ2x814+Al2BqIEWOyaGIgEjPVSjjgxhoabkJC5vbO4AeI3cxx3wg==
-  dependencies:
-    magic-string "^0.25.7"
-
 rollup-plugin-license@^2.6.1:
   version "2.6.1"
   resolved "https://registry.yarnpkg.com/rollup-plugin-license/-/rollup-plugin-license-2.6.1.tgz#20f15cc37950f362f8eefdc6e3a2e659d0cad9eb"