Skip to content

Commit c16b325

Browse files
committed
fix tests
1 parent 90831a2 commit c16b325

File tree

3 files changed

+8
-3
lines changed
  • dev-packages/browser-integration-tests/suites/tracing/trace-lifetime

3 files changed

+8
-3
lines changed

dev-packages/browser-integration-tests/suites/tracing/trace-lifetime/navigation/test.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -414,10 +414,12 @@ sentryTest(
414414
await page.locator('[data-sentry-feedback] .btn--primary').click();
415415

416416
const feedbackEvent = await feedbackEventPromise;
417+
418+
expect(feedbackEvent.type).toEqual('feedback');
419+
417420
const feedbackTraceContext = feedbackEvent.contexts?.trace;
418421

419422
expect(feedbackTraceContext).toMatchObject({
420-
op: 'navigation',
421423
trace_id: navigationTraceContext?.trace_id,
422424
span_id: expect.stringMatching(/^[0-9a-f]{16}$/),
423425
});

dev-packages/browser-integration-tests/suites/tracing/trace-lifetime/pageload-meta/test.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -393,8 +393,9 @@ sentryTest('user feedback event after pageload has pageload traceId in headers',
393393
const feedbackEvent = await feedbackEventPromise;
394394
const feedbackTraceContext = feedbackEvent.contexts?.trace;
395395

396+
expect(feedbackEvent.type).toEqual('feedback');
397+
396398
expect(feedbackTraceContext).toMatchObject({
397-
op: 'pageload',
398399
trace_id: META_TAG_TRACE_ID,
399400
parent_span_id: META_TAG_PARENT_SPAN_ID,
400401
span_id: expect.stringMatching(/^[0-9a-f]{16}$/),

dev-packages/browser-integration-tests/suites/tracing/trace-lifetime/pageload/test.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -391,10 +391,12 @@ sentryTest('user feedback event after pageload has pageload traceId in headers',
391391
await page.locator('[data-sentry-feedback] .btn--primary').click();
392392

393393
const feedbackEvent = await feedbackEventPromise;
394+
395+
expect(feedbackEvent.type).toEqual('feedback');
396+
394397
const feedbackTraceContext = feedbackEvent.contexts?.trace;
395398

396399
expect(feedbackTraceContext).toMatchObject({
397-
op: 'pageload',
398400
trace_id: pageloadTraceContext?.trace_id,
399401
span_id: expect.stringMatching(/^[0-9a-f]{16}$/),
400402
});

0 commit comments

Comments
 (0)