feat(replay): Move sample rate tags into replay_event

Similar to #6658 but waiting on getsentry/replay-backend#226

Author: billyvg

packages/replay/src/replay.ts

@@ -932,11 +932,13 @@ export class ReplayContainer implements ReplayContainerInterface {
       ...(includeReplayStartTimestamp ? { replay_start_timestamp: initialTimestamp / 1000 } : {}),
       timestamp: currentTimestamp / 1000,
       error_ids: errorIds,
+      error_sample_rate: this._options.errorSampleRate,
       trace_ids: traceIds,
       urls,
       replay_id: replayId,
-      segment_id,
       replay_type: this.session?.sampled,
+      segment_id,
+      session_sample_rate: this._options.sessionSampleRate,
     };
 
     const replayEvent = await getReplayEvent({ scope, client, event: baseEvent });
@@ -948,12 +950,6 @@ export class ReplayContainer implements ReplayContainerInterface {
       return;
     }
 
-    replayEvent.tags = {
-      ...replayEvent.tags,
-      sessionSampleRate: this._options.sessionSampleRate,
-      errorSampleRate: this._options.errorSampleRate,
-    };
-
     /*
     For reference, the fully built event looks something like this:
     {
@@ -971,6 +967,8 @@ export class ReplayContainer implements ReplayContainerInterface {
         "replay_id": "eventId",
         "segment_id": 3,
         "replay_type": "error",
+        "error_sample_rate": 1,
+        "session_sample_rate": 1,
         "platform": "javascript",
         "event_id": "generated-uuid",
         "environment": "production",
@@ -983,10 +981,7 @@ export class ReplayContainer implements ReplayContainerInterface {
             "version": "7.25.0"
         },
         "sdkProcessingMetadata": {},
-        "tags": {
-            "sessionSampleRate": 1,
-            "errorSampleRate": 0,
-        }
+        "tags": {}
     }
     */
 

packages/replay/test/unit/index.test.ts

@@ -789,11 +789,9 @@ describe('Replay', () => {
       replayEventPayload: expect.objectContaining({
         replay_start_timestamp: (BASE_TIMESTAMP - 10000) / 1000,
         urls: ['http://localhost/'], // this doesn't truly test if we are capturing the right URL as we don't change URLs, but good enough
+        error_sample_rate: 0,
         replay_type: 'session',
-        tags: expect.objectContaining({
-          errorSampleRate: 0,
-          sessionSampleRate: 1,
-        }),
+        session_sample_rate: 1,
       }),
     });
   });

packages/replay/test/unit/util/createReplayEnvelope.test.ts

@@ -24,10 +24,9 @@ describe('createReplayEnvelope', () => {
       version: '7.25.0',
     },
     replay_type: 'error',
-    tags: {
-      sessionSampleRate: 1,
-      errorSampleRate: 0,
-    },
+    error_sample_rate: 0,
+    session_sample_rate: 1,
+    tags: {},
   };
 
   const payloadWithSequence = 'payload';
@@ -56,13 +55,15 @@ describe('createReplayEnvelope', () => {
           {
             environment: 'production',
             error_ids: ['errorId'],
+            error_sample_rate: 0,
             event_id: REPLAY_ID,
             platform: 'javascript',
             replay_id: REPLAY_ID,
             replay_type: 'error',
             sdk: { integrations: ['BrowserTracing', 'Replay'], name: 'sentry.javascript.browser', version: '7.25.0' },
             segment_id: 3,
-            tags: { errorSampleRate: 0, sessionSampleRate: 1 },
+            session_sample_rate: 1,
+            tags: {},
             timestamp: 1670837008.634,
             trace_ids: ['traceId'],
             type: 'replay_event',
@@ -90,13 +91,15 @@ describe('createReplayEnvelope', () => {
           {
             environment: 'production',
             error_ids: ['errorId'],
+            error_sample_rate: 0,
             event_id: REPLAY_ID,
             platform: 'javascript',
             replay_id: REPLAY_ID,
             sdk: { integrations: ['BrowserTracing', 'Replay'], name: 'sentry.javascript.browser', version: '7.25.0' },
             segment_id: 3,
             replay_type: 'error',
-            tags: { errorSampleRate: 0, sessionSampleRate: 1 },
+            session_sample_rate: 1,
+            tags: {},
             timestamp: 1670837008.634,
             trace_ids: ['traceId'],
             type: 'replay_event',