Skip to content

Commit c98c8e7

Browse files
committed
feat(ci): Add Node 18 to test matrix
1 parent 8b16378 commit c98c8e7

File tree

1 file changed

+16
-16
lines changed

1 file changed

+16
-16
lines changed

.github/workflows/build.yml

+16-16
Original file line numberDiff line numberDiff line change
@@ -231,7 +231,7 @@ jobs:
231231
runs-on: ubuntu-latest
232232
strategy:
233233
matrix:
234-
node: [8, 10, 12, 14, 16]
234+
node: [8, 10, 12, 14, 16, 18]
235235
steps:
236236
- name: Check out current commit (${{ env.HEAD_COMMIT }})
237237
uses: actions/checkout@v2
@@ -270,7 +270,7 @@ jobs:
270270
runs-on: ubuntu-latest
271271
strategy:
272272
matrix:
273-
node: [10, 12, 14, 16]
273+
node: [10, 12, 14, 16, 18]
274274
steps:
275275
- name: Check out current commit (${{ env.HEAD_COMMIT }})
276276
uses: actions/checkout@v2
@@ -310,10 +310,10 @@ jobs:
310310
uses: actions/checkout@v2
311311
with:
312312
ref: ${{ env.HEAD_COMMIT }}
313-
# TODO: removing `fetch-depth` below seems to have no effect, and the commit which added it had no description,
314-
# so it's not clear why it's necessary. That said, right now ember tests are xfail, so it's a little hard to
315-
# tell if it's safe to remove. Once ember tests are fixed, let's try again with it turned off, and if all goes
316-
# well, we can pull it out.
313+
# TODO: removing `fetch-depth` below seems to have no effect, and the commit which added it had no description,
314+
# so it's not clear why it's necessary. That said, right now ember tests are xfail, so it's a little hard to
315+
# tell if it's safe to remove. Once ember tests are fixed, let's try again with it turned off, and if all goes
316+
# well, we can pull it out.
317317
fetch-depth: 0
318318
- name: Set up Node
319319
uses: actions/setup-node@v1
@@ -369,7 +369,7 @@ jobs:
369369
- name: Set up Node
370370
uses: actions/setup-node@v1
371371
with:
372-
node-version: '16'
372+
node-version: '18'
373373
- name: Check dependency cache
374374
uses: actions/cache@v2
375375
with:
@@ -468,7 +468,7 @@ jobs:
468468
continue-on-error: true
469469
strategy:
470470
matrix:
471-
node: [10, 12, 14, 16]
471+
node: [10, 12, 14, 16, 18]
472472
steps:
473473
- name: Check out current commit (${{ github.sha }})
474474
uses: actions/checkout@v2
@@ -503,7 +503,7 @@ jobs:
503503
runs-on: ubuntu-latest
504504
strategy:
505505
matrix:
506-
node: [8, 10, 12, 14, 16]
506+
node: [8, 10, 12, 14, 16, 18]
507507
steps:
508508
- name: Check out current commit (${{ env.HEAD_COMMIT }})
509509
uses: actions/checkout@v2
@@ -542,7 +542,7 @@ jobs:
542542
runs-on: ubuntu-latest
543543
strategy:
544544
matrix:
545-
node: [10, 12, 14, 16]
545+
node: [10, 12, 14, 16, 18]
546546
steps:
547547
- name: Check out current commit (${{ env.HEAD_COMMIT }})
548548
uses: actions/checkout@v2
@@ -583,10 +583,10 @@ jobs:
583583
uses: actions/checkout@v2
584584
with:
585585
ref: ${{ env.HEAD_COMMIT }}
586-
# TODO: removing `fetch-depth` below seems to have no effect, and the commit which added it had no description,
587-
# so it's not clear why it's necessary. That said, right now ember tests are xfail, so it's a little hard to
588-
# tell if it's safe to remove. Once ember tests are fixed, let's try again with it turned off, and if all goes
589-
# well, we can pull it out.
586+
# TODO: removing `fetch-depth` below seems to have no effect, and the commit which added it had no description,
587+
# so it's not clear why it's necessary. That said, right now ember tests are xfail, so it's a little hard to
588+
# tell if it's safe to remove. Once ember tests are fixed, let's try again with it turned off, and if all goes
589+
# well, we can pull it out.
590590
fetch-depth: 0
591591
- name: Set up Node
592592
uses: actions/setup-node@v1
@@ -640,7 +640,7 @@ jobs:
640640
- name: Set up Node
641641
uses: actions/setup-node@v1
642642
with:
643-
node-version: '16'
643+
node-version: '18'
644644
- name: Check dependency cache
645645
uses: actions/cache@v2
646646
with:
@@ -742,7 +742,7 @@ jobs:
742742
continue-on-error: true
743743
strategy:
744744
matrix:
745-
node: [10, 12, 14, 16]
745+
node: [10, 12, 14, 16, 18]
746746
steps:
747747
- name: Check out current commit (${{ github.sha }})
748748
uses: actions/checkout@v2

0 commit comments

Comments
 (0)