fix(node): Local variables skipped after Promise (#11234)

The debugger call stack does not include the `new Promise` frames that
are parsed from `error.stack`. This means that when we go through the
frames to apply the local variables, the frames don't match up and we
bail.

This patch ignores those frames when matching functions in the frames.

Author: timfish

dev-packages/node-integration-tests/suites/public-api/LocalVariables/local-variables-caught.mjs

@@ -9,12 +9,14 @@ Sentry.init({
 });
 
 class Some {
-  two(name) {
-    throw new Error('Enough!');
+  async two(name) {
+    return new Promise((_, reject) => {
+      reject(new Error('Enough!'));
+    });
   }
 }
 
-function one(name) {
+async function one(name) {
   const arr = [1, '2', null];
   const obj = {
     name,
@@ -30,12 +32,12 @@ function one(name) {
 
   const ty = new Some();
 
-  ty.two(name);
+  await ty.two(name);
 }
 
-setTimeout(() => {
+setTimeout(async () => {
   try {
-    one('some name');
+    await one('some name');
   } catch (e) {
     Sentry.captureException(e);
   }

packages/node-experimental/src/integrations/local-variables/local-variables-sync.ts

@@ -288,29 +288,31 @@ const _localVariablesSyncIntegration = ((
       return;
     }
 
-    const frameCount = exception.stacktrace?.frames?.length || 0;
+    // Filter out frames where the function name is `new Promise` since these are in the error.stack frames
+    // but do not appear in the debugger call frames
+    const frames = (exception.stacktrace?.frames || []).filter(frame => frame.function !== 'new Promise');
 
-    for (let i = 0; i < frameCount; i++) {
+    for (let i = 0; i < frames.length; i++) {
       // Sentry frames are in reverse order
-      const frameIndex = frameCount - i - 1;
+      const frameIndex = frames.length - i - 1;
 
       // Drop out if we run out of frames to match up
-      if (!exception?.stacktrace?.frames?.[frameIndex] || !cachedFrame[i]) {
+      if (!frames[frameIndex] || !cachedFrame[i]) {
         break;
       }
 
       if (
         // We need to have vars to add
         cachedFrame[i].vars === undefined ||
         // We're not interested in frames that are not in_app because the vars are not relevant
-        exception.stacktrace.frames[frameIndex].in_app === false ||
+        frames[frameIndex].in_app === false ||
         // The function names need to match
-        !functionNamesMatch(exception.stacktrace.frames[frameIndex].function, cachedFrame[i].function)
+        !functionNamesMatch(frames[frameIndex].function, cachedFrame[i].function)
       ) {
         continue;
       }
 
-      exception.stacktrace.frames[frameIndex].vars = cachedFrame[i].vars;
+      frames[frameIndex].vars = cachedFrame[i].vars;
     }
   }