Skip to content

Commit d825549

Browse files
authored
fix(build): Revert unintended Replay tsconfig changes (#6300)
This PR reverts a few changes I unintentionally comitted and merged in #6288. It caused build errors which for some reasons did not our CI's "build" step to fail but caused size-check fails in https://github.com/getsentry/sentry-javascript/actions/runs/3546454900
1 parent 7821ba7 commit d825549

File tree

5 files changed

+15
-18
lines changed

5 files changed

+15
-18
lines changed

packages/replay/.eslintrc.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ module.exports = {
4040
{
4141
files: ['worker/**/*.ts'],
4242
parserOptions: {
43-
project: ['config/tsconfig.worker.json'],
43+
project: ['./config/tsconfig.worker.json'],
4444
},
4545
},
4646
{
Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,13 @@
11
{
2-
"compilerOptions": {},
2+
"compilerOptions": {
3+
"module": "esnext",
4+
"moduleResolution": "node",
5+
"noImplicitAny": true,
6+
"noEmitOnError": false,
7+
"esModuleInterop": true,
8+
"resolveJsonModule": true,
9+
"skipLibCheck": true,
10+
"target": "es5"
11+
},
312
"exclude": ["node_modules"]
413
}

packages/replay/package.json

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -63,12 +63,6 @@
6363
"engines": {
6464
"node": ">=12"
6565
},
66-
"size-limit": [
67-
{
68-
"path": "build/npm/index.js",
69-
"limit": "4500ms"
70-
}
71-
],
7266
"volta": {
7367
"node": "14.21.1",
7468
"yarn": "1.22.19"

packages/replay/tsconfig.json

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,11 @@
11
{
22
"extends": "./config/tsconfig.core.json",
33
"compilerOptions": {
4-
"module": "esnext",
5-
"moduleResolution": "node",
6-
"noImplicitAny": true,
7-
"noEmitOnError": false,
8-
"esModuleInterop": true,
9-
"resolveJsonModule": true,
10-
"skipLibCheck": true,
11-
"types": ["node", "jest"],
12-
"target": "es5",
134
"paths": {
145
"@test": ["./test"],
156
"@test/*": ["./test/*"]
16-
}
7+
},
8+
"types": ["node", "jest"]
179
},
1810
"include": ["src/**/*.ts", "test/**/*.ts", "rollup.config.ts", "jest.config.ts", "jest.setup.ts"],
1911
"exclude": ["node_modules"]

packages/replay/worker/src/handleMessage.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,10 @@ export function handleMessage(e: MessageEvent): void {
3030
const id = e.data.id as number;
3131
const [data] = e.data.args ? JSON.parse(e.data.args) : [];
3232

33+
// @ts-ignore this syntax is actually fine
3334
if (method in handlers && typeof handlers[method] === 'function') {
3435
try {
36+
// @ts-ignore this syntax is actually fine
3537
const response = handlers[method](data);
3638
// @ts-ignore this syntax is actually fine
3739
postMessage({

0 commit comments

Comments
 (0)