Skip to content

Commit dc2777f

Browse files
committed
fix(types): remove other references to the enum
1 parent dd3aa70 commit dc2777f

File tree

10 files changed

+19
-18
lines changed

10 files changed

+19
-18
lines changed

packages/browser/src/backend.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { BaseBackend } from '@sentry/core';
2-
import { Event, EventHint, Options, Severity, Transport } from '@sentry/types';
2+
import { Event, EventHint, Options, SeverityLevel, Transport } from '@sentry/types';
33
import { supportsFetch } from '@sentry/utils';
44

55
import { eventFromException, eventFromMessage } from './eventbuilder';
@@ -45,7 +45,7 @@ export class BrowserBackend extends BaseBackend<BrowserOptions> {
4545
/**
4646
* @inheritDoc
4747
*/
48-
public eventFromMessage(message: string, level: Severity = Severity.Info, hint?: EventHint): PromiseLike<Event> {
48+
public eventFromMessage(message: string, level: SeverityLevel = 'info', hint?: EventHint): PromiseLike<Event> {
4949
return eventFromMessage(this._options, message, level, hint);
5050
}
5151

packages/browser/src/eventbuilder.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { Event, EventHint, Options, Severity } from '@sentry/types';
1+
import { Event, EventHint, Options, SeverityLevel } from '@sentry/types';
22
import {
33
addExceptionMechanism,
44
addExceptionTypeValue,
@@ -24,7 +24,7 @@ export function eventFromException(options: Options, exception: unknown, hint?:
2424
attachStacktrace: options.attachStacktrace,
2525
});
2626
addExceptionMechanism(event); // defaults to { type: 'generic', handled: true }
27-
event.level = Severity.Error;
27+
event.level = 'error';
2828
if (hint && hint.event_id) {
2929
event.event_id = hint.event_id;
3030
}
@@ -38,7 +38,7 @@ export function eventFromException(options: Options, exception: unknown, hint?:
3838
export function eventFromMessage(
3939
options: Options,
4040
message: string,
41-
level: Severity = Severity.Info,
41+
level: SeverityLevel = 'info',
4242
hint?: EventHint,
4343
): PromiseLike<Event> {
4444
const syntheticException = (hint && hint.syntheticException) || undefined;

packages/browser/src/exports.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ export {
88
Exception,
99
Response,
1010
Severity,
11+
SeverityLevel,
1112
StackFrame,
1213
Stacktrace,
1314
Status,

packages/browser/src/integrations/breadcrumbs.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -244,7 +244,7 @@ function _fetchBreadcrumb(handlerData: { [key: string]: any }): void {
244244
{
245245
category: 'fetch',
246246
data: handlerData.fetchData,
247-
level: Severity.Error,
247+
level: 'error',
248248
type: 'http',
249249
},
250250
{

packages/browser/src/integrations/globalhandlers.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
/* eslint-disable @typescript-eslint/no-unsafe-member-access */
22
import { getCurrentHub } from '@sentry/core';
3-
import { Event, EventHint, Hub, Integration, Primitive, Severity } from '@sentry/types';
3+
import { Event, EventHint, Hub, Integration, Primitive } from '@sentry/types';
44
import {
55
addExceptionMechanism,
66
addInstrumentationHandler,
@@ -146,7 +146,7 @@ function _installGlobalOnUnhandledRejectionHandler(): void {
146146
rejection: true,
147147
});
148148

149-
event.level = Severity.Error;
149+
event.level = 'error';
150150

151151
addMechanismAndCapture(hub, error, event, 'onunhandledrejection');
152152
return;

packages/core/src/basebackend.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { Event, EventHint, Options, Session, Severity, Transport } from '@sentry/types';
1+
import { Event, EventHint, Options, Session, SeverityLevel, Transport } from '@sentry/types';
22
import { logger, SentryError } from '@sentry/utils';
33

44
import { NoopTransport } from './transports/noop';
@@ -29,7 +29,7 @@ export interface Backend {
2929
eventFromException(exception: any, hint?: EventHint): PromiseLike<Event>;
3030

3131
/** Creates a {@link Event} from a plain message. */
32-
eventFromMessage(message: string, level?: Severity, hint?: EventHint): PromiseLike<Event>;
32+
eventFromMessage(message: string, level?: SeverityLevel, hint?: EventHint): PromiseLike<Event>;
3333

3434
/** Submits the event to Sentry */
3535
sendEvent(event: Event): void;
@@ -83,7 +83,7 @@ export abstract class BaseBackend<O extends Options> implements Backend {
8383
/**
8484
* @inheritDoc
8585
*/
86-
public eventFromMessage(_message: string, _level?: Severity, _hint?: EventHint): PromiseLike<Event> {
86+
public eventFromMessage(_message: string, _level?: SeverityLevel, _hint?: EventHint): PromiseLike<Event> {
8787
throw new SentryError('Backend has to implement `eventFromMessage` method');
8888
}
8989

packages/core/src/baseclient.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import {
99
Options,
1010
Outcome,
1111
SessionStatus,
12-
Severity,
12+
SeverityLevel,
1313
Transport,
1414
} from '@sentry/types';
1515
import {
@@ -127,7 +127,7 @@ export abstract class BaseClient<B extends Backend, O extends Options> implement
127127
/**
128128
* @inheritDoc
129129
*/
130-
public captureMessage(message: string, level?: Severity, hint?: EventHint, scope?: Scope): string | undefined {
130+
public captureMessage(message: string, level?: SeverityLevel, hint?: EventHint, scope?: Scope): string | undefined {
131131
let eventId: string | undefined = hint && hint.event_id;
132132

133133
const promisedEvent = isPrimitive(message)

packages/core/test/lib/base.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { Hub, Scope, Session } from '@sentry/hub';
2-
import { Event, Outcome, Severity, Span, Transport } from '@sentry/types';
2+
import { Event, Outcome, Span, Transport } from '@sentry/types';
33
import { logger, SentryError, SyncPromise } from '@sentry/utils';
44

55
import * as integrationModule from '../../src/integration';
@@ -313,7 +313,7 @@ describe('BaseClient', () => {
313313
scope.setExtra('foo', 'wat');
314314
client.captureMessage(
315315
'test message',
316-
Severity.Warning,
316+
'warning',
317317
{
318318
captureContext: {
319319
extra: {

packages/core/test/mocks/backend.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { Session } from '@sentry/hub';
2-
import { Event, Options, Severity, Transport } from '@sentry/types';
2+
import { Event, Options, SeverityLevel, Transport } from '@sentry/types';
33
import { SyncPromise } from '@sentry/utils';
44

55
import { BaseBackend } from '../../src/basebackend';
@@ -38,7 +38,7 @@ export class TestBackend extends BaseBackend<TestOptions> {
3838
});
3939
}
4040

41-
public eventFromMessage(message: string, level: Severity = Severity.Info): PromiseLike<Event> {
41+
public eventFromMessage(message: string, level: SeverityLevel = 'info'): PromiseLike<Event> {
4242
return SyncPromise.resolve({ message, level });
4343
}
4444

packages/types/src/severity.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/** JSDoc
2-
* @deprecated use string literals - if you require a type, use SeverityLevel instead.
2+
* @deprecated Use string literals - if you require type casting, cast to SeverityLevel type
33
*/
44
// eslint-disable-next-line import/export
55
export enum Severity {

0 commit comments

Comments
 (0)